Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp8992857rwb; Thu, 24 Nov 2022 06:50:09 -0800 (PST) X-Google-Smtp-Source: AA0mqf5MOIHBnKwoR0dJkKi8gLdAenP4DREaxk9SNwED1tjtGY3qyYWASNbX9EJvuUdRQ64yB/4h X-Received: by 2002:a17:90a:d38a:b0:218:a7e6:60df with SMTP id q10-20020a17090ad38a00b00218a7e660dfmr22442073pju.38.1669301409398; Thu, 24 Nov 2022 06:50:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669301409; cv=none; d=google.com; s=arc-20160816; b=IBGWkzy0HQgJxHMfRXTdf2EuaFCvvQi1ySDn9qaEO2y+r+rzhf0i0/QsH72P13rBz8 EEQBs2iEN4S91q/Kap6dZlN9UPTKayt7M3tCsZKRLyh0wVoZWfAO9vCzLD1cjH89OHzz 5Mz60uE887S5itkoXy73YGcjErEUP89dz78FYNfho5/x7El5HAYMYWcjL5Twppu8/Sll OHyvvqhLT+cX+OUB9/an0I0Og5343bJaTSpYXcDs9VPtwrdujGPukwxYpS8T5G8vKZhl oPahW3VOMA3VWv5zc0NDiIC6WHSskl8YS0e2qJ3A90Y5NvRuqedN2ShdJxtBcZgNbBr0 PnqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=i1pzz9nEWRhnBhj7DdQ4WwbJsLTF8R2tG1DieVVsKMs=; b=nixo+6a8f+mU5X7Rc9sU25alaXJJV9Yh0IQ8C5mJL9QYpPH//BR1jUfrj2/Z7NCV0g jV/LPS+pNnM8rpsSMd9sosbkzmA37AZLTxvixoOK9L7njMB6oVNFbaB2ngYtr/Ix1G/Q 0Nq1i9RQ0aSB3w19iJxGU4/dC7v3GC4VX9zfA5lAeaWcmwKk6Rgqj3qDb0UOa4ksZKSF pA6oCb3x1baLT7L9zt19ocTqO/SQU6ggzV70i7vUJUzDvocXjx49PmeUJ6NzKANfs+eu c4Q05X13S9xMGA71JDYnx8QIzj1l5Cu2mP4K+XRFqEf1sB1+0mauQBGuE4e0JWZSC8Ba jMbw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 76-20020a62154f000000b0056b86567ce9si1110838pfv.347.2022.11.24.06.49.56; Thu, 24 Nov 2022 06:50:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229808AbiKXOpR (ORCPT + 86 others); Thu, 24 Nov 2022 09:45:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229807AbiKXOpF (ORCPT ); Thu, 24 Nov 2022 09:45:05 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92463F2C05 for ; Thu, 24 Nov 2022 06:45:02 -0800 (PST) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyDT7-0002eW-QH; Thu, 24 Nov 2022 15:44:49 +0100 Received: from pengutronix.de (unknown [IPv6:2a03:f580:87bc:d400:5507:4aba:5e0a:4c27]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id D24DC128665; Thu, 24 Nov 2022 14:44:46 +0000 (UTC) Date: Thu, 24 Nov 2022 15:44:45 +0100 From: Marc Kleine-Budde To: Jiasheng Jiang Cc: rcsekar@samsung.com, wg@grandegger.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] can: m_can: Add check for devm_clk_get Message-ID: <20221124144445.edeuxa4ryzcxgkkh@pengutronix.de> References: <20221123063651.26199-1-jiasheng@iscas.ac.cn> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zadcz6b2upk7mjl4" Content-Disposition: inline In-Reply-To: <20221123063651.26199-1-jiasheng@iscas.ac.cn> X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --zadcz6b2upk7mjl4 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 23.11.2022 14:36:51, Jiasheng Jiang wrote: > Since the devm_clk_get may return error, > it should be better to add check for the cdev->hclk, > as same as cdev->cclk. >=20 > Fixes: f524f829b75a ("can: m_can: Create a m_can platform framework") > Signed-off-by: Jiasheng Jiang Applied to linux-can. Thanks, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --zadcz6b2upk7mjl4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmN/g1oACgkQrX5LkNig 011GKQf7BR7XYcW+ucxkt3SH3QKy+EH85aPtVwFIvzH1EJ4jpMvTK7aiXPne7kUP JYtIjuM9Zt11IRUnEdmarM8JAekwrzz+MJGlnFAohkv/cvccFZ2UZRdIFE/bAtIL DX34tFfXzeOiVNxuIjE5jQFitX8BH10b+Sq+ku93QhAzZjFxO815k3dohh6xFCRT eRH+Lo4uffXF6adwJcO0yoyOu/w4ADfm2DTL81MEGkSoAQZaRFavtsHZ9k5Y4YRh hIY7UEOSHeA7By9pH/Dw/HqHarIE3fJ6HvDVwwizyoqd9aP2FJFBt5lZkSUJ3tac UmBEKFXVzuR03t2OKzr07BAdXQAH6g== =mv3O -----END PGP SIGNATURE----- --zadcz6b2upk7mjl4--