Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 24 Nov 2022 15:45:32 +0100
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Jianglei Nie <niejianglei2021@163.com>
Cc:     yashi@spacecubics.com, wg@grandegger.com, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        mailhol.vincent@wanadoo.fr, stefan.maetje@esd.eu,
        socketcan@hartkopp.net, hbh25y@gmail.com,
        linux-can@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] can: mcba_usb: fix potential resource leak in
 mcba_usb_xmit_cmd()
Message-ID: <20221124144532.6u3hnvb6b2ninlxy@pengutronix.de>
References: <20221120101414.6071-1-niejianglei2021@163.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="kd4a5kaznfiyppsu"
Content-Disposition: inline
In-Reply-To: <20221120101414.6071-1-niejianglei2021@163.com>
Precedence: bulk


--kd4a5kaznfiyppsu
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 20.11.2022 18:14:14, Jianglei Nie wrote:
> mcba_usb_xmit_cmd() gets free ctx by mcba_usb_get_free_ctx(). When
> mcba_usb_xmit() fails, the ctx should be freed with mcba_usb_free_ctx()
> like mcba_usb_start_xmit() does in label "xmit_failed" to avoid potential
> resource leak.
>=20
> Fix it by calling mcba_usb_free_ctx() when mcba_usb_xmit() fails.
>=20
> Signed-off-by: Jianglei Nie <niejianglei2021@163.com>

Applied to linux-can.

Thanks,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--kd4a5kaznfiyppsu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmN/g4kACgkQrX5LkNig
010q9wgAsGR/W7WPpvudvy/7dkjbwq2fVAQGbS68F1LyfZeISBI80NaWc1PMF1lj
J329herD+T+wmhrT7WIYAXjjiSXg1P3eGdNTk3Xe7vnbKoFcmTRIHZ8cKBfyi6zP
bf0Nu3MHfoTwi642VHmm97ZH0+qdQ5mB2f0Q9+k2+Y19lBC+lGvy7op4635krQ9t
egdwUw1XnbaLFN6k8xUxVW1y36401ZMvicC/LwGVqdKk7pclYbzHdhTZ7oGP2uW3
vFrtfhsrPNK8/S3TWGmB2bIMcWF0VAHLjXIsPSCCSYxbjHzUEvjtrhjya4Boltlr
fVwu7Rxi/lDoBViwe5oo1yXbLHYy9g==
=rsFT
-----END PGP SIGNATURE-----

--kd4a5kaznfiyppsu--