Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 24 Nov 2022 15:38:24 +0100
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Yasushi SHOJI <yasushi.shoji@gmail.com>
Cc:     Vincent Mailhol <vincent.mailhol@gmail.com>,
        Yasushi SHOJI <yashi@spacecubics.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, linux-can@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] can: mcba_usb: Fix termination command argument
Message-ID: <20221124143824.u5lyi3rektjxft7o@pengutronix.de>
References: <20221123194406.80575-1-yashi@spacecubics.com>
 <CAMZ6RqJ2L6YntT23rsYEEUK=YDF2LrhB8hXwvYjciu3vzjx2hQ@mail.gmail.com>
 <CAELBRWLOKW8NCLpV=MG0_=XY4N3BaozsZCacfgaXEs-tyfzoAA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="2b5oymuqicmyslax"
Content-Disposition: inline
In-Reply-To: <CAELBRWLOKW8NCLpV=MG0_=XY4N3BaozsZCacfgaXEs-tyfzoAA@mail.gmail.com>
Precedence: bulk


--2b5oymuqicmyslax
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 24.11.2022 18:52:14, Yasushi SHOJI wrote:
> On Thu, Nov 24, 2022 at 9:53 AM Vincent Mailhol
> <vincent.mailhol@gmail.com> wrote:
> > > diff --git a/drivers/net/can/usb/mcba_usb.c b/drivers/net/can/usb/mcb=
a_usb.c
> > > index 218b098b261d..67beff1a3876 100644
> > > --- a/drivers/net/can/usb/mcba_usb.c
> > > +++ b/drivers/net/can/usb/mcba_usb.c
> > > @@ -785,9 +785,9 @@ static int mcba_set_termination(struct net_device=
 *netdev, u16 term)
> > >         };
> > >
> > >         if (term =3D=3D MCBA_TERMINATION_ENABLED)
> > > -               usb_msg.termination =3D 1;
> > > -       else
> > >                 usb_msg.termination =3D 0;
> > > +       else
> > > +               usb_msg.termination =3D 1;
> > >
> > >         mcba_usb_xmit_cmd(priv, (struct mcba_usb_msg *)&usb_msg);
> >
> > Nitpick: does it make sense to rename the field to something like
> > usb_msg.termination_disable or usb_msg.termination_off? This would
> > make it more explicit that this is a "reverse" boolean.
>=20
> I'd rather define the values like
>=20
> #define TERMINATION_ON (0)
> #define TERMINATION_OFF (1)
>=20
> So the block becomes
>=20
> if (term =3D=3D MCBA_TERMINATION_ENABLED)
>     usb_msg.termination =3D TERMINATION_ON;
> else
>     usb_msg.termination =3D TERMINATION_OFF;

Please send a v2 patch, using git send-email, as you did with the first
version. (No compressed attached patches please.)

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--2b5oymuqicmyslax
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmN/gd0ACgkQrX5LkNig
0133OwgAlfuDYqc4mfHIa8P9QiLu3aGHzuezoaoZjCyBFGYcA7asa4LMdpf1pjz7
ldCGajT5dJImf+BS5XnUPFpCU5NOvE9lEw8O8am7jF2386YFJz0f5Mb9aQ7ithOy
S6h6t0ltrfbHLEErAk6mWKYtMZAy53yyeVS0goe+SK0KVvPiuMnkoOm6v8pEON/F
y5ob4OD/kiBWfqgt3PT6Cwjc0pRuj/iLvIpgNYOV0zcybjyFubNY0tBinvnXWqPN
ChuBpKD5d/Rpl3faA0enZ+MdfrEEff+NdUvdVSUzmcCZb8740yr76UMBInYys2gu
CIBZm0t5ldgG4XZ440/i/iLs9czdUw==
=Vfvz
-----END PGP SIGNATURE-----

--2b5oymuqicmyslax--