Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp9029529rwb; Thu, 24 Nov 2022 07:14:10 -0800 (PST) X-Google-Smtp-Source: AA0mqf4sR904ei9cQqXN5+dYH3hTovUsaRi0YXKyS9GqIuRryyrGeMYJjQfDHp/P4VBM/7H120b+ X-Received: by 2002:a17:903:3287:b0:188:d4bf:dbff with SMTP id jh7-20020a170903328700b00188d4bfdbffmr18617172plb.19.1669302850256; Thu, 24 Nov 2022 07:14:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669302850; cv=none; d=google.com; s=arc-20160816; b=N7/noZYpV4PxetBH6vnjsdFm6NOsjWtPYd7V9AyGYJAY/AKs6fMZp8ml1Miesjjrpb bNGUp0HxZfkKF0jJtqbSyFvhMDu66rnmosSgR16aSaF2+TSkhrpEY97FPV770cu+Zwxk OU8dD/909SXvmRlV6z6FvHk+D2SMQ7kcuZ+MBftPKQo44B5ESqrTEugOk9E19qu+VV8a Xgfeep/xExTDER7mULpyRQZyHsLQNZKd3i9wTkjJzBa4Lo/5E55hxdAB1d9bej2Yil+M EILM1ZfCZlJ2RSDNd0MratVXUEj+hi9OBPrM411JQhinDU9CPwIcuZlngd/5hlyGMvzu 3lRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=ApPGoVDYqYHUZ2XMNIslvDhNQpZkgDCDnXsI1e7cjAM=; b=ozFT7pu8wjJStmA1SxYylJKaZ5fpINZiRHWLjNtjh426hdaM3tqL5m9qE3q0ErWcby d1rlatgRE4kjWkt9liqXBz2eBQeZBgynKYid7kLrZKmxoEpu0T6f/V2ibuDlJdMz8jQ7 YA9sIh5lT3Yrm96iqgV8GtlRlsXjZOAileFmwaiORsYsYrZAo8XovfCupJRrLUcvtCll xeqDlWeSBQZTyt9gfI3RTLRzF53BtcnRSc6+H4u1bhZgs+xbiCKCUe4UzCRhABqi9VRl Y/AgCHHD1DW83pPhmz9C0VFUqKfAv9gKmtWMW/eRI4IJ987tDpbnYgwHEJmIaKjwbatN Du5A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s5-20020a170903214500b0017f6a4fd6fbsi635232ple.123.2022.11.24.07.13.57; Thu, 24 Nov 2022 07:14:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229835AbiKXPC6 (ORCPT + 86 others); Thu, 24 Nov 2022 10:02:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229790AbiKXPCw (ORCPT ); Thu, 24 Nov 2022 10:02:52 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6A255EFB0 for ; Thu, 24 Nov 2022 07:02:50 -0800 (PST) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyDkE-0006Kb-TA; Thu, 24 Nov 2022 16:02:30 +0100 Received: from pengutronix.de (unknown [IPv6:2a03:f580:87bc:d400:5507:4aba:5e0a:4c27]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id E646A1286FC; Thu, 24 Nov 2022 15:02:27 +0000 (UTC) Date: Thu, 24 Nov 2022 16:02:26 +0100 From: Marc Kleine-Budde To: Zhang Changzhong Cc: Wolfgang Grandegger , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Raymond Tan , "Felipe Balbi (Intel)" , Jarkko Nikula , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] can: m_can: pci: add missing m_can_class_free_dev() in probe/remove methods Message-ID: <20221124150226.vxvzimlll23unt7g@pengutronix.de> References: <1668168684-6390-1-git-send-email-zhangchangzhong@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yockql4feiyza47j" Content-Disposition: inline In-Reply-To: <1668168684-6390-1-git-send-email-zhangchangzhong@huawei.com> X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --yockql4feiyza47j Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 11.11.2022 20:11:23, Zhang Changzhong wrote: > In m_can_pci_remove() and error handling path of m_can_pci_probe(), > m_can_class_free_dev() should be called to free resource allocated by > m_can_class_allocate_dev(), otherwise there will be memleak. >=20 > Fixes: cab7ffc0324f ("can: m_can: add PCI glue driver for Intel Elkhart L= ake") > Signed-off-by: Zhang Changzhong Applied to linux-can. regards, Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --yockql4feiyza47j Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmN/h34ACgkQrX5LkNig 0110kAf/awCUKjMOV4BkGa4KGpIgHzxAuo4iEfIlMEVCMK7aFdmu1ebzfWKlK5rZ 7Y8OTjjNr6f0HHYNuSqEqQj9gZzGUXbwlNhfDefAXr268p+dMQPHEdaKYgBrbFvL RBAXm8PT3ppUr7chdwrE1VhPuudHNRfC8jK7LWPMj4KF0b/r0OHKi6b1KLiBUhYo 8VmDXSc2KtFKselc7I/kOo3j5PkOp8URM+SJIpq9jtP5XxSgBNqMvS4W0Wf2MYcx XAe1xHcbiVSEvaqV5jxs+kiN1dky/ELyo/f2kBKPXkS76eFn+KQsfY/qIt+rNVFw ubIGyyIrFCry0Mv6oOORLPDgOzDwog== =Xd/+ -----END PGP SIGNATURE----- --yockql4feiyza47j--