Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp9038730rwb; Thu, 24 Nov 2022 07:20:24 -0800 (PST) X-Google-Smtp-Source: AA0mqf5+ZOGfPQlGugdCaLz6pLmwSAjWVI/cqA3zKx5vDun9UNIpYjvGwG7n0Osr+BZ5D3R1t7uL X-Received: by 2002:a17:906:9d12:b0:78a:d075:98d8 with SMTP id fn18-20020a1709069d1200b0078ad07598d8mr28345691ejc.324.1669303224095; Thu, 24 Nov 2022 07:20:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669303224; cv=none; d=google.com; s=arc-20160816; b=m7tyCHijjT+XGIsf0TNSuOvMqkHEzLOnawmc+HpJwH0vNJepa+HsjpX6pV2nWM75+j rRRopw5k4gSWRkYcvZzNCAJZ4FK5AXWt3TdHyUTWKdfwB3k2TuwMrrF3J8+/rtwfyq0y ud0/F/vpMut3XjhWmrpP4iHy+KDxz2KjWkpNCtSe5bjzemqPlP8htc+eyPMjNYWlkggj 4GqWwLuNo2N1z4vEtPT5qMNTmNRU5JCJAKPduplMrXBf+7PRNRf5v76JC5tesVo02vBn OTRFOj355Fxk+Ft6b0MLXmOnpB2nXLciR9ckHx+cr0leQsZIQULWsrBBAnwuyDQMkOjA wdDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=5UMI1DIKDAnzqSTbIOKqYqHKnG+LlUGJsP8L+VyKueg=; b=pnaQ3j+6/TYH+1CKIyGoxnjsu9Cc9fHK7LY/GX8DaZ8cVtXfNuKwYIqlIaRWRa/R/6 VxUwx/knp8HHGR7uliq/RmwZdUaAn9ESkgEGP8fBGkAs6TIuvPTaxiH8njJOO3abY+rt AGlDIgqIAoeMOkMRiOp7vPnHEtJ7bHJBUwxGdMGHXYd9IlMkO1Ce54YmGRoWDqSn9jt3 ber1BHXEYlDsboezfjmCxgb7rwBmYZHZzoOeMr0yHs7u7xdXX/fKzmYvHF97EQHl8g0F YgOBVWJkK2VuPyPVoQaGYHy05RRpTc7OxqwRaX+chl/l9JR5F9aS75mXzCYadlT+SjjD hl8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=evlXEjHn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w8-20020a50fa88000000b0045c9dbe290csi1022941edr.406.2022.11.24.07.20.03; Thu, 24 Nov 2022 07:20:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=evlXEjHn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229908AbiKXOxQ (ORCPT + 86 others); Thu, 24 Nov 2022 09:53:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229863AbiKXOwz (ORCPT ); Thu, 24 Nov 2022 09:52:55 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01D8A114BAA for ; Thu, 24 Nov 2022 06:52:04 -0800 (PST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id AE26F21AB1; Thu, 24 Nov 2022 14:52:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1669301522; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5UMI1DIKDAnzqSTbIOKqYqHKnG+LlUGJsP8L+VyKueg=; b=evlXEjHn6DGAUhPl+wGh1wQ1HXAPLcp0KiplfR5aC22HF+TF0zjZ03RjNwETt2vxSt7QEJ hbn9H+3mF5dgdFCzFaMe6mM170v0VGqYb+VI6eTBFvfpxYXRxtuHDKgG9T0JF2hh2rfak9 Ls9nfrldlkobBa/hz2qcvBxxGB+Dun4= Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 88E392C141; Thu, 24 Nov 2022 14:52:02 +0000 (UTC) Date: Thu, 24 Nov 2022 15:52:01 +0100 From: Petr Mladek To: John Ogness Cc: Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , linux-kernel@vger.kernel.org, Greg Kroah-Hartman Subject: Re: [PATCH printk v2 4/7] printk: Add struct console_buffers Message-ID: References: <20221123231400.614679-1-john.ogness@linutronix.de> <20221123231400.614679-5-john.ogness@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221123231400.614679-5-john.ogness@linutronix.de> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 2022-11-24 00:19:57, John Ogness wrote: > From: Thomas Gleixner > > Create a data structure to replace the open coded separate buffers for > regular, extended, and dropped message formatting. > > A separate @ext_text buffer is needed because info_print_ext_header() > and msg_print_ext_body() are not able to add the needed extra > information in-place. > > @ext_text can be used for dropped text because they are never used at > the same time. > > Signed-off-by: Thomas Gleixner > Signed-off-by: John Ogness If we agree to use the static buffers in struct console, feel free to use: Reviewed-by: Petr Mladek Otherwise, it should get moved into some internal header. Best Regards, Petr