Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp9227318rwb; Thu, 24 Nov 2022 09:39:35 -0800 (PST) X-Google-Smtp-Source: AA0mqf4FPBdHz0AjFiGYLvsFPAHQ7xk37Uh77sNOzE8YM50R77VmZm7XqTIx6CgGL3WBLnZBR3f0 X-Received: by 2002:aa7:84c5:0:b0:56b:f64b:b385 with SMTP id x5-20020aa784c5000000b0056bf64bb385mr15067425pfn.68.1669311574799; Thu, 24 Nov 2022 09:39:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669311574; cv=none; d=google.com; s=arc-20160816; b=048KCFkpUIsye2wi8KrW4GTwXoR0UjFXoorvQvlzn4oPpZv9GAjz7FZn9Z3/2vipMD /nfGHt+W8F4hPUN1zfAyA7xWmKecHLydnFNI24QGSWxlzexD77Eg9baGitWWPkjU1Vpz L8MBlVNxmn+Cpj5oiE9CP9dVQTqzs5Mdlq7ncEjUVgqRlUpQJl15yM1YkdYW1ICMDkTg ZK+pZ0px3GVfjo6jQtILQ+c55nwvidCRR11xppxdiQIJtTpcT+NnzvdjwgYbSDqj1OYu AiSKA+G3XjMnLsNA/H5ixmTbfBs6L5xPiFKkbDc/CaC3yr/YBlIKS62Q1/WzoNZVqt0l KysQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=ikMZIMfqE9Y1ekyjxlTJt2BymPntBowrgAbgUQvUxkM=; b=LfNnT5ywvtq7NSaJdevwPmneu3ULV5qPSFf0qV9P0VCAFoZexoiXt52coGxHeGP/1J y+/DmrBfAzHx2VxZuWSwnKCNp/96hMbC0HuBU8LDubjwLmgPvbO+W4wQHKBHADyKXHqQ aKuDHnne+3rB/b7hMrTesx3Dy3jsRpXGCsOaTUZc8PLgiJSOcG4vmoRBa8JlOalMTflv RVJdpsodNi+m6UxJ5Y4biT2qnPYD3ImlC8yWUYqOjpkPyFLpN/RsrM+CLodP6HZchLj2 cdgprgAmE+kiO8R3qsjXBJ5bS3gpiuC3yp0TFLAeS3kggbMpFg2rTFHHhJPngNQgW4VN Kczw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jlWYUTkA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s9-20020a63dc09000000b0047693f9d264si1664371pgg.833.2022.11.24.09.39.23; Thu, 24 Nov 2022 09:39:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jlWYUTkA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229491AbiKXRb3 (ORCPT + 87 others); Thu, 24 Nov 2022 12:31:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbiKXRb3 (ORCPT ); Thu, 24 Nov 2022 12:31:29 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AD6C134108 for ; Thu, 24 Nov 2022 09:31:28 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C1C00621B1 for ; Thu, 24 Nov 2022 17:31:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3DA77C433C1; Thu, 24 Nov 2022 17:31:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669311087; bh=VppZ7d9iMOH7sKJH9n8k65LOO/8jSDoMVN0wLOIpdNE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jlWYUTkAwr5it7ct0sKRZToUsswIvtTWcrHijxlecPnBBUOUTQL0F7iIQNWkIN4o1 L1IvRUAaYq7Nm4NpdyCYoKLZGIsV3CnIOFLs/bsRqmF1OqJev9y2qJUAau7yytBZHX t7/6sZugPAAKDx+TQPaPM2R3q/uZPm5bhfnq3YAScZVeyfIAjenQEfxVFo5Ig3XT7R 1lwCikOcXkfHLg+GxTWUCXwfJQnzljTEOhhhbSIFdokkChHqrxJgAnUXBWGyE1nS0m FrjG4wgpEoGRkGBH5CXUoMNvi2N0Yn/oAy81N+18KneDcD9sqY60i4XsZJOSmjhOQv /uroPFrZrjJcw== Message-ID: <8cc1c8a0-7d2c-e653-2ab9-40d040eebbb3@kernel.org> Date: Thu, 24 Nov 2022 18:31:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [for-next][PATCH 05/11] tracing/osnoise: Add osnoise/options file Content-Language: en-US To: Steven Rostedt , linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Andrew Morton , Jonathan Corbet References: <20221124145019.782980678@goodmis.org> <20221124145046.156919074@goodmis.org> From: Daniel Bristot de Oliveira In-Reply-To: <20221124145046.156919074@goodmis.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/24/22 15:50, Steven Rostedt wrote: > From: Daniel Bristot de Oliveira > > Add the tracing/osnoise/options file to control > osnoise/timerlat tracer features. It is a single > file to contain multiple features, similar to > the sched/features file. > > Reading the file displays a list of options. Writing > the OPTION_NAME enables it, writing NO_OPTION_NAME disables > it. > > The DEAFULTS is a particular option that resets the options > to the default ones. > > It uses a bitmask to keep track of the status of the option. When > needed, we can add a list of static keys, but for now > it does not justify the memory increase. > > Link: https://lkml.kernel.org/r/f8d34aefdb225d2603fcb4c02a120832a0cd3339.1668692096.git.bristot@kernel.org Hi Steve, Yesterday I sent a v2 of this patch series, adding some more options [1]. But as you already queued these, and as there is no real difference from the v1 and v2 in these code patches, I think the best way is for me to send a v3 with the additional patches, build on top of the ftrace/core. (Is it a bad idea? let me know :-)) [1] https://lore.kernel.org/lkml/cover.1669115208.git.bristot@kernel.org/ -- Daniel