Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 25 Nov 2022 08:12:16 +0800
From:   Yan Zhao <yan.y.zhao@intel.com>
To:     "Huang, Kai" <kai.huang@intel.com>
CC:     "Yamahata, Isaku" <isaku.yamahata@intel.com>,
        "sean.j.christopherson@intel.com" <sean.j.christopherson@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Christopherson,, Sean" <seanjc@google.com>,
        "Shahar, Sagi" <sagis@google.com>,
        "isaku.yamahata@gmail.com" <isaku.yamahata@gmail.com>,
        "Aktas, Erdem" <erdemaktas@google.com>,
        "dmatlack@google.com" <dmatlack@google.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>
Subject: Re: [PATCH v10 035/108] KVM: x86/mmu: Track shadow MMIO value on a
 per-VM basis
Message-ID: <Y4AIYGGEU3BdrQgV@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <cover.1667110240.git.isaku.yamahata@intel.com>
 <f1c9996fa4f4bc71b3feee8407d247aeabb8968e.1667110240.git.isaku.yamahata@intel.com>
 <Y3wvhWyIKNzczFov@yzhao56-desk.sh.intel.com>
 <887a77acc9bf96f7c7bea519ab7ebdd27fb67985.camel@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <887a77acc9bf96f7c7bea519ab7ebdd27fb67985.camel@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6gg5IEBq+4T/nm5p0pqp1gdicrpGR5gDYzdDhHzcan3AF28ZSdT3ulXYS4xm?=
 =?us-ascii?Q?U3iuIaSonMb3BNqaqfknfxGpOoDnjiZ4erwNsq6zX55WLmfy5EZWygvOtlFu?=
 =?us-ascii?Q?QW3K3roJ73XHLqLGYMGIv1sGOxaCxr3kxJsI7tHfXsSiXkkQwsYveWbYOwaG?=
 =?us-ascii?Q?mRtbF9aImW5XaRrPqq1ulq7RZm/bEMgvysVrmjKA6roL4UspplTZysyXhkSi?=
 =?us-ascii?Q?pQvxKexQgdoNM4ociNAn5gVBlnTFCjoiDlZ6xNJ0pti+Ya27fldtbun0RYw7?=
 =?us-ascii?Q?Vp+24CzZuooPTN9HYsdKPi5Apayx9SvegyutJtArnMmqqkYTTsc6BcO28kzx?=
 =?us-ascii?Q?11TNVkZDAX1LrU1xno7Ynp5J2JPdzniEPNsbUHQaudLnOZEhAQBOG2KGuw/i?=
 =?us-ascii?Q?9r6kUDAN5lT8RH1UPteXrxjeR5uozmmWWuhuRtf0NPJ7v8jnkdHNz4kIyyTz?=
 =?us-ascii?Q?3toxiofQbmCB/pn3vx0c5amZrJSj2t5mdDdFOJNmjSVqH6G0D3gXA0XekYgU?=
 =?us-ascii?Q?q4YnSvTS2PKbUrx+dJCZ9oe3Iwc3A/CWk9hoex3moGYGfupCbBQh6MvZtIUY?=
 =?us-ascii?Q?sjYlv0VqSYQ2JM20WtLiDmnvkfg6KwR1xAhigBHYJQPQY3Psbc3N59KUn2IR?=
 =?us-ascii?Q?jwC74IzttQx2ShbSJKsa7kmdwe2S7jexv+Y3Q8bVNlNvUJ4rO2b1IMm/zSFM?=
 =?us-ascii?Q?2xju6zBWB+V5LHXkKe4YXMDHLRsCeZGlnn8Xm+dUR3j7pjpNR/QaZQm/Dv82?=
 =?us-ascii?Q?Zpve+HIfxJIx+9pOlS7mEHJuFF9pjoHnp4QOCFlH6c+9+hMCl3MSUjtMXxhy?=
 =?us-ascii?Q?vNmHeiTjSmxzTjWN0i3JULBOzhTrPAvL7I9zwcH/lFHWx0PWx7YPcicEmUcR?=
 =?us-ascii?Q?BPpcSC3nc7YaZmDphXwqyIYUZZwxK6PRJuVd2DMHrXOIiJOrOSY7OVYTtogH?=
 =?us-ascii?Q?hbcpE+oxdGYgEUBnJJtmOAXq78yaEu1dOYRGkqabZg9omt+09nlZzl+JwlSA?=
 =?us-ascii?Q?aIHBC/juiVTC2l/8McQ/jXSKO764gYB4ew5ThcLu6LhRxNkKhDnXs7NfIdQw?=
 =?us-ascii?Q?K3OSmgsIJ/JS3ZCsyk/yqn9z3hOhJWFI+nCNmrtKOToUT+PGMt8yh+1vvZOx?=
 =?us-ascii?Q?8CNMzC9/ms82FLxQIhWeNFNjK/dbCHzgeQwMG4TVuaIrL14QmbATNyu9PGF6?=
 =?us-ascii?Q?1HIYWmD1V+aJUvYtohOMt329c/ITcwuPT4MBjbGjkMMLQdrY2yOhVJn/59mR?=
 =?us-ascii?Q?4ttA9e5To1BrncfUYrswNQfejgxmevbpb3g3tyHr7KNHSgxoBjXNDv7pD0tt?=
 =?us-ascii?Q?FBgq9J/1FaCBq10qHbk1r1K4thgD3TAIjpPmavhkmuTctfH30apYPnSwaMVk?=
 =?us-ascii?Q?YTluDQt/ybm8aYhg8uBzVELJDl9ZmH1JYJFbu41h4i86vFnVOdro9SsDUKDu?=
 =?us-ascii?Q?bi1tEDsc2arAgtnT6LYyx6bjzmVEoS5Y5q7+PDC+at+LeC+486vSZY0sUEBR?=
 =?us-ascii?Q?Tud3xQxpXZdV3sNYGoub1IYI92bSRMZDt/ZVHCttLSmugIh+ot1TzhIXLZjl?=
 =?us-ascii?Q?U7lLd2KU3FutszQiY9jCLr8wMQNKUyqeMzrNTx3V?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ba7ec4e0-9c97-4927-6aa2-08dace7ce8f8
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2022 00:35:10.7769
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NR4scbGDOjSMseaX2PZhuBjDutbHdrxKymJCe0FX/6NZNs9509x+AQyfzjlznaHRqKW3kamTPQmp/AhpEgQ/ow==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7513
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 25, 2022 at 08:13:48AM +0800, Huang, Kai wrote:
> On Tue, 2022-11-22 at 10:10 +0800, Yan Zhao wrote:
> > Also make enable_mmio_caching to be a per-VM value?
> > As if the shadow_mmio_value is 0, mmio_caching needs to be disabled.
> 
> If I recall correctly, Sean said we can disable TDX guests if mmio_caching is
> disabled (we also will need to change to allow enable_mmio_caching to still be
> true when mmio_value is 0).
> 
> SEV_ES has similar logic:
> 
> void __init sev_hardware_setup(void)
> {
> 
> 	...
> 
>         /*
>          * SEV-ES requires MMIO caching as KVM doesn't have access to the guest
>          * instruction stream, i.e. can't emulate in response to a #NPF and
>          * instead relies on #NPF(RSVD) being reflected into the guest as #VC
>          * (the guest can then do a #VMGEXIT to request MMIO emulation).
>          */
>         if (!enable_mmio_caching)
>                 goto out;
> 

Would enabling mmio caching in per-VM basis be better?