Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 25 Nov 2022 08:37:06 +0800
From:   Yan Zhao <yan.y.zhao@intel.com>
To:     "Huang, Kai" <kai.huang@intel.com>
CC:     "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "Christopherson,, Sean" <seanjc@google.com>,
        "Shahar, Sagi" <sagis@google.com>,
        "isaku.yamahata@gmail.com" <isaku.yamahata@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Aktas, Erdem" <erdemaktas@google.com>,
        "dmatlack@google.com" <dmatlack@google.com>,
        "sean.j.christopherson@intel.com" <sean.j.christopherson@intel.com>,
        "Yamahata, Isaku" <isaku.yamahata@intel.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH v10 035/108] KVM: x86/mmu: Track shadow MMIO value on a
 per-VM basis
Message-ID: <Y4AOMo00B0vlQfIU@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <cover.1667110240.git.isaku.yamahata@intel.com>
 <f1c9996fa4f4bc71b3feee8407d247aeabb8968e.1667110240.git.isaku.yamahata@intel.com>
 <Y3wvhWyIKNzczFov@yzhao56-desk.sh.intel.com>
 <887a77acc9bf96f7c7bea519ab7ebdd27fb67985.camel@intel.com>
 <Y4AIYGGEU3BdrQgV@yzhao56-desk.sh.intel.com>
 <8e14a7732a2d873846d07c4ec467fb7c48b2307f.camel@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <8e14a7732a2d873846d07c4ec467fb7c48b2307f.camel@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2Dklsmy9yWDgfbhNrwBd4ENDf+5g+5MAuurZRz3jJjRGiLfBh0OjmELmV2k1?=
 =?us-ascii?Q?8DrtHswtvHlQ6K7paEA6dFSCy9X6cRBC9OBmfunooY1pliHwawt7n6sBs6Ea?=
 =?us-ascii?Q?DqO96AQNmdXRSlaH2MUTxHGNGfn/o7q1F0IOn4+U8UxPuZ+DtJwpA+ZJNPsp?=
 =?us-ascii?Q?B0oplcNMx7e0G3yZB/AQrMVLqgmxEfqo0DvGUTbGjlCaMysfvSzrP/QRSBz3?=
 =?us-ascii?Q?G1rbbqPPUk0PR7x7czmvfQflh6gCBpzEBpZoyaMr6wKd5Il+Inh5j/q+bQwv?=
 =?us-ascii?Q?4l72jFjHY6AuBWS6ykttTvgti2MLzJKo/gDl6bJrS6hD1qGzcITaTWh4S8Rx?=
 =?us-ascii?Q?LB3qalRW5lz4g2mGIbN0ivjAZBj+WVHR2855hLvxnYj5xVKmRgika6mEitOv?=
 =?us-ascii?Q?n6ODmaBUV6iDIK5kOzE5ZdJvKJYg5BxddPW2uqP1BUrZkRbypq/miUSQvGei?=
 =?us-ascii?Q?t0LeQcAD+jiqOXFFlRDRf4xnvo8MvDMgJk5+8i2BKg1TQ77vlHBcGYM7nQ7S?=
 =?us-ascii?Q?Rw1DvwwJFGP5iCXVZYrXXeEO3glVhYuuYFTROKnGIeyjZCX5mdo9Asw+2/nP?=
 =?us-ascii?Q?RPb/plYR4ckGTo6Z2RPk/fw81YiL9h7u81BBa4ClznIeI0gqO9+40poxya+g?=
 =?us-ascii?Q?M+MALVwnB8Cx61LWeT/QcF9ILFblGjjggEMfy2x1KPiisurzcIBmWHojFpSA?=
 =?us-ascii?Q?yho9sDNDbnJ5Q7jwuV3uDw1VT1ktKPiXxpzspZsISPmvADovNU/MSqq5B8KY?=
 =?us-ascii?Q?xVBDPmeD47A++PvtbSl8cx8Ea97Kd3f55COcemyFQ9FNB8MaJyExPYcUm2Ad?=
 =?us-ascii?Q?6RYvx2RAZe2cPSw4+14nEE7+kfySH1MMnzBT7n5/3eSowe0L7tDmpBTi/+1E?=
 =?us-ascii?Q?NYXPUgubGjLWxb8o2TFvEVBHA5F9Q65be1tBh7Z+B0ApvhZL2zY7qDTn93td?=
 =?us-ascii?Q?7e/Lko2SysA1rCgLQO+ffAu+TX7L+X2ylHAuNg9wqZaU8p8OrH3OE0ju7uB7?=
 =?us-ascii?Q?I6Jv6NZV6Om/tKB4Fi7cycFnaiVoJCC+sJrFxCCknQact3TJ9lLOryVW3fTU?=
 =?us-ascii?Q?QiwuPK8IqiT1a8/lwEgvoCPR9YZyaCPMAi21MlvIcN/mZY7fGptOM7lSxiiE?=
 =?us-ascii?Q?Xn3ysCJCGwpYPf5/6tznS26yVxU/wQNED9ZpvVNe5a9LtXWUkvsv9yX6UFX3?=
 =?us-ascii?Q?hRxk1m7b/iVte7rguE5orK2H8xVrDkOGbUvAxT5eINeU7szXdjVZz5JGqpF/?=
 =?us-ascii?Q?s+c2PX441GInvGv+rdxq3Kkm8pcVVI1tB6ixo57AXwfWeJI1Aj80wSpi3EyH?=
 =?us-ascii?Q?OTQOX8s4Lce6PqDuuCgkql4pa+mg414VGUabzT43UzeILUGgVNvS8ezKnOQP?=
 =?us-ascii?Q?RP9GopzmNExxosmdpexbOV29gTBFzlstRMvu9BvZHbxq6OuwKbHMj3EK5wjW?=
 =?us-ascii?Q?IYypVzjVxD/tE5dM3JnN8IILrPnSEbLmAA8c07KmlbnaNLvMEyL5mLbF/AO4?=
 =?us-ascii?Q?jxuv6wFqKOeFXakiS67knJx81fj97/JXY6BuLC44Uogv4IFBGA9pFhKc9Gc5?=
 =?us-ascii?Q?cl466GlItfVNbQRqlKJmgWlhrj4Rzu/Bk+uosTsu?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 47ea8ecc-a59f-4c7d-c5c1-08dace806437
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2022 01:00:05.9952
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +Oym8FWaUpSNIBrr8s/nFOQCTq908/RTm5so7w+xOYem3qdg6p+SeGY/pzM1DYQEnXLY9bPTr2dn93/SXJ8tdA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6114
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 25, 2022 at 08:45:01AM +0800, Huang, Kai wrote:
> On Fri, 2022-11-25 at 08:12 +0800, Yan Zhao wrote:
> > On Fri, Nov 25, 2022 at 08:13:48AM +0800, Huang, Kai wrote:
> > > On Tue, 2022-11-22 at 10:10 +0800, Yan Zhao wrote:
> > > > Also make enable_mmio_caching to be a per-VM value?
> > > > As if the shadow_mmio_value is 0, mmio_caching needs to be disabled.
> > > 
> > > If I recall correctly, Sean said we can disable TDX guests if mmio_caching is
> > > disabled (we also will need to change to allow enable_mmio_caching to still be
> > > true when mmio_value is 0).
> > > 
> > > SEV_ES has similar logic:
> > > 
> > > void __init sev_hardware_setup(void)
> > > {
> > > 
> > > 	...
> > > 
> > >         /*
> > >          * SEV-ES requires MMIO caching as KVM doesn't have access to the guest
> > >          * instruction stream, i.e. can't emulate in response to a #NPF and
> > >          * instead relies on #NPF(RSVD) being reflected into the guest as #VC
> > >          * (the guest can then do a #VMGEXIT to request MMIO emulation).
> > >          */
> > >         if (!enable_mmio_caching)
> > >                 goto out;
> > > 
> > 
> > Would enabling mmio caching in per-VM basis be better?
> > 
> 
> We need Paolo/Sean to decide.
> 
> The thing is TDX guests always require mmio_caching being enabled.  For VMX
> guests, normally we will always enable mmio_caching too.  So I think per-VM
> basis mmio_caching is not that useful.
With per-VM basis enabling, I think we can get rid of the kvm_gfn_shared_mask(kvm)
in below code and also in handle_abnormal_pfn()

static inline bool is_mmio_spte(struct kvm *kvm, u64 spte)
{
        return (spte & shadow_mmio_mask) == kvm->arch.shadow_mmio_value &&
               likely(enable_mmio_caching || kvm_gfn_shared_mask(kvm));
}

Thanks
Yan