Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 25 Nov 2022 09:01:50 +0100
From:   Wolfram Sang <wsa@kernel.org>
To:     ye.xingchen@zte.com.cn
Cc:     linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: Use device_match_of_node()
Message-ID: <Y4B2bnfLS4A9VS/s@ninjato>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>, ye.xingchen@zte.com.cn,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
References: <202211251551030468773@zte.com.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Fie70k562p6YCs3c"
Content-Disposition: inline
In-Reply-To: <202211251551030468773@zte.com.cn>
Precedence: bulk


--Fie70k562p6YCs3c
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Fri, Nov 25, 2022 at 03:51:03PM +0800, ye.xingchen@zte.com.cn wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
>=20
> Replace the open-code with device_match_of_node().

Frankly, I don't like it. It doesn't look more readable and it doesn't
prevent from subtle bugs. device_match_of_node() was introduced when you
are *iterating* over a list of devices, see the commit which introduced
it. I think replacing every 'open coded' version with this helper is a
bad idea.

Happy hacking,

   Wolfram

>=20
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
>  drivers/i2c/i2c-core-of.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/i2c/i2c-core-of.c b/drivers/i2c/i2c-core-of.c
> index 3ed74aa4b44b..307a0adf6bc1 100644
> --- a/drivers/i2c/i2c-core-of.c
> +++ b/drivers/i2c/i2c-core-of.c
> @@ -115,11 +115,11 @@ void of_i2c_register_devices(struct i2c_adapter *ad=
ap)
>=20
>  static int of_dev_or_parent_node_match(struct device *dev, const void *d=
ata)
>  {
> -	if (dev->of_node =3D=3D data)
> +	if (device_match_of_node(dev, data))
>  		return 1;
>=20
>  	if (dev->parent)
> -		return dev->parent->of_node =3D=3D data;
> +		return device_match_of_node(dev->parent, data);
>=20
>  	return 0;
>  }
> --=20
> 2.25.1

--Fie70k562p6YCs3c
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmOAdmoACgkQFA3kzBSg
KbYCpw/+MqP4qdy3I5kIkeapx187nEBYcPkPmZ6DRn7oqxmwcD0PJ/d5Rjbm/T+t
SSX5Yy+EgPE3QImPsJ+zlVuDzbKZ/I2PXugwKjPBJkMxbOOZVNbsMks1thsAV3GN
IquB3iG7LZRgHH4bv+i7wDvsalG/SufMpDMs9/x4PuAKpX/IZwuceTpy9ZB87z0j
si+KBB99XWHPlUF2CI2bZhXEyFYOoqoKU8Ms2cmGOjrNCmbEs1T0sQyLpkgjsEit
rVWMew9rATX+3ptm6GnGBhony7NIZ9KE3xY7IdY//6GE0jZbV+/PGDWplbeRkBI1
MaspQM4qJwJcFxt965J9HkNDPtD9ToXAkpXG77WQvGxWhw+0iRsJ/6CdtGZUj7Jz
jQ4HscQ8P0h4D2hZAvp4Nmh4LSnop1wYP9t++RK0gdUlHJT+cRz6j3dnaHEidVp5
KMhuO53l5zH4BhpBy3gEhvsH4WR6+wEkNu44hkTkJvtdKWFKUugr8BwGvrOaQSWQ
aO1/8/YsTHdZAEbfFlqpzUfsa3T30D2egqDGDSbEj+5GLFST7muzZhdkHCPB6Q9E
i7/oDgC2IINmyTe/IjLKKfypza0p4ed65mZRqVcEwTCueisclo8daw6wXyS9jrYi
H8eOuqfiabURrJwgTfMM4QgycT8+TAwttg7bYpogttGoVLM6OGg=
=uKqc
-----END PGP SIGNATURE-----

--Fie70k562p6YCs3c--