Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 25 Nov 2022 16:55:17 +0800
From:   Gao Xiang <hsiangkao@linux.alibaba.com>
To:     Hou Tao <houtao@huaweicloud.com>
Cc:     Jia Zhu <zhujia.zj@bytedance.com>, linux-erofs@lists.ozlabs.org,
        Gao Xiang <xiang@kernel.org>, Chao Yu <chao@kernel.org>,
        Yue Hu <huyue2@coolpad.com>,
        Jeffle Xu <jefflexu@linux.alibaba.com>, houtao1@huawei.com,
        linux-kernel@vger.kernel.org
Subject: Re: [External] [PATCH] erofs: check the uniqueness of fsid in shared
 domain in advance
Message-ID: <Y4CC9dqtuHEITdlt@B-P7TQMD6M-0146.local>
References: <20221125074057.2229083-1-houtao@huaweicloud.com>
 <49b2b8e4-39d0-983c-23c6-f18232a7dff3@bytedance.com>
 <86bf6991-d46b-be95-06a7-87829e8c5e33@huaweicloud.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <86bf6991-d46b-be95-06a7-87829e8c5e33@huaweicloud.com>
Precedence: bulk


Hi Tao,

On Fri, Nov 25, 2022 at 04:39:47PM +0800, Hou Tao wrote:
> Hi,
> 
> On 11/25/2022 4:25 PM, Jia Zhu wrote:
> > Hi Tao,
> > We've noticed this warning during development. It seems not a bug, so
> > I ignored that.
> > Many thanks for cacthing and clearing up the annoying warning.
> Yes, it is not a bug. The duplicated mount will fail with -EEXIST even without
> the patch. But it is a bit scary to see such warning in dmesg, so just fix it.

Thanks for the catch.

IMO, a WARN is indeed a bug, we cannot rely on this.

Overall the patch itself looks good to me as well, please help Cc LKML
mailing list as well in v2...

Thanks,
Gao Xiang