Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp10151643rwb; Fri, 25 Nov 2022 01:27:46 -0800 (PST) X-Google-Smtp-Source: AA0mqf5YXrQb3GjgbMK6F/jHSdcstiKRP5GY0Wvl5zpjr096pQI8o2KGn3GhzCvGa07bWcberij/ X-Received: by 2002:a63:d751:0:b0:46f:f87c:fb1a with SMTP id w17-20020a63d751000000b0046ff87cfb1amr17766124pgi.214.1669368465933; Fri, 25 Nov 2022 01:27:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669368465; cv=none; d=google.com; s=arc-20160816; b=huGLaRGxfG+ZtCKyC84pY88wOgbYh6rXBsYVj0zyL3kfmOWYX/6ZjanrpxKY8WUlHK tUxLJ0pJpwRZsEmp9BhTA/BjpTPV/cYjf9dG4Vw25WKlYjRh2t0mqFXvs803aNd6QJxE Orddu+Vk4BXg7oJf8txBIfDaxg908VBeyfJuUmZGsJdazPX7r/VnkG3QTnbWUbijvZbp ShmeU67+7iDkhvrCzkNRyS52myFwVFFfhHWJ8m4ZexKEOD8oRrJnug5bTFw9w/xGcae0 MY5AZ2x+2NVEz5Sfyl8J4ksraAW31xhkgtY0qOwSj6CRzUnZVlbpFNAzCo0KFokL6AEq KTWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=aM06WcTZjzdi1OfstxExKnHz/Ke53sYbxOypw6DqCPg=; b=kr2K1zpywUWyCFwv3LtaeN2QnL6mHLROANQjcmReUJBqP8xrJnQSneENxfUjjORSnF IkoVCOIU5hTTjg1lRgtSU2AgMyq+B4RHL97oeU9JK94QOrsc5Dbd//NJvcYL0Hrf/kc3 MT/OdJxRafGUgeYc0hGAAK5QX/72COJT2qHI5CgrkaR3qJ5DQYuE4dD0AzdMCtfMq2rg 7CFzXYUnv96fqWuuNKv/3AeyBh8/s+XrQImirYn1ZYJd2JilFaNT0mwzZxHI7FAxxcuv 3MsdWctqoeIwx4+RngstuPdEKQv3QGozx5XHu1062MrJVAnACvJss7ACl6QqYQIo0g3y Xj3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Lrg+6l16; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t4-20020a17090aba8400b001fe41707a2esi4207225pjr.90.2022.11.25.01.27.33; Fri, 25 Nov 2022 01:27:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Lrg+6l16; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229775AbiKYJXf (ORCPT + 86 others); Fri, 25 Nov 2022 04:23:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229734AbiKYJX3 (ORCPT ); Fri, 25 Nov 2022 04:23:29 -0500 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 910D02316E for ; Fri, 25 Nov 2022 01:23:27 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id ja4-20020a05600c556400b003cf6e77f89cso5995664wmb.0 for ; Fri, 25 Nov 2022 01:23:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=aM06WcTZjzdi1OfstxExKnHz/Ke53sYbxOypw6DqCPg=; b=Lrg+6l16RJUHoZfs0fpSgTYZuo6wFHJrFZQcqPDmMvF+nmDd90VQZpODE2pSlIUKmI UqPRNqgnfS4QF6kvUpSKfMfczk9Hd6trNBEQzXjkjH+LUdLjKQ/18nqe7wSVePBFR7L5 BiwqDqGynaGPblg+WDWfsdA/PHWkV1v23Wir6Aa0d6Ma2xC35QuZ2D6Rco2PyeLFUzYo mahpdWUcn4yGjYCqanY4/tf0r6zPvIgJo5xBEbUWeu0XT04AS+gbZeb98nALq0sIe12v Wv49040oaDZaLEu5Z9r0E8ONLprcc0VzfMbCXAhWPGsR8GGzQl6RxQg9scd8SOmAB4Rs MVBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aM06WcTZjzdi1OfstxExKnHz/Ke53sYbxOypw6DqCPg=; b=iRWZqes9iaat6xV3t7MT/EaDScceFyENEVzbG01bSbOo4xmI31bPpjtwwtZZkCAnOm QzrNOoOOYR/u1R6zsKSsNZwZoA87e8SZQMbZ5wFFSf1P/ogUrEqjt7S/QLqriq5kk6Ax XrNrf7KS+BEhzBVZGuH2A06N4iyoPB3FS77A98XzwAFZHZ7A/LNQkYnKqt1DAjE5itt3 2vzNBs1Jzq7sPayMgTVqHrnfKb8e8dqW1SvPWqOaVlx3eXUyyhAIjD8sbnnTHqjrhhNs AeVYvESsGojQgQa+PaLSkuKAcbnh6of8ok0nG/2827MZX2j2LWQ9umjL4dij6ATglvta XK3w== X-Gm-Message-State: ANoB5pmW3HTDJE3v9CrXuIlzm6r54HllGCBeC82avJ7nlS0XaFyjiqh7 PaGN3mmypPvMvdtKpMJ8IYnKJg== X-Received: by 2002:a1c:a381:0:b0:3cf:4d14:5705 with SMTP id m123-20020a1ca381000000b003cf4d145705mr15085304wme.35.1669368205984; Fri, 25 Nov 2022 01:23:25 -0800 (PST) Received: from linaro.org ([94.52.112.99]) by smtp.gmail.com with ESMTPSA id l9-20020a05600c2cc900b003c7087f6c9asm8731576wmc.32.2022.11.25.01.23.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Nov 2022 01:23:25 -0800 (PST) Date: Fri, 25 Nov 2022 11:23:23 +0200 From: Abel Vesa To: Dario Binacchi Cc: linux-kernel@vger.kernel.org, Amarula patchwork , michael@amarulasolutions.com, Abel Vesa , Fabio Estevam , Michael Turquette , NXP Linux Team , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [PATCH] clk: imx: rename imx_obtain_fixed_clk_hw() to imx_get_clk_hw_by_name() Message-ID: References: <20221113180839.1625832-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221113180839.1625832-1-dario.binacchi@amarulasolutions.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22-11-13 19:08:39, Dario Binacchi wrote: > The imx_obtain_fixed_clk_hw name was wrong and misleading. Renaming it > to imx_get_clk_hw_by_name clarifies the purpose of the function, and > will allow it to be used not only for fixed rate clocks but also in > wider contexts. > > No functional changes intended. > > The replacements were made with the following command: > > grep -rl 'imx_obtain_fixed_clk_hw' ./ | \ > xargs sed -i 's/imx_obtain_fixed_clk_hw/imx_get_clk_hw_by_name/g' > > Tested on a BSH SystemMaster (SMM) S2 board. > > Signed-off-by: Dario Binacchi Applied, thanks! > > --- > > drivers/clk/imx/clk-imx6sll.c | 8 ++++---- > drivers/clk/imx/clk-imx6sx.c | 12 ++++++------ > drivers/clk/imx/clk-imx6ul.c | 8 ++++---- > drivers/clk/imx/clk-imx7d.c | 4 ++-- > drivers/clk/imx/clk-imx7ulp.c | 10 +++++----- > drivers/clk/imx/clk-imx8mm.c | 12 ++++++------ > drivers/clk/imx/clk-imx8mn.c | 12 ++++++------ > drivers/clk/imx/clk-imx8mp.c | 12 ++++++------ > drivers/clk/imx/clk-imx8mq.c | 14 +++++++------- > drivers/clk/imx/clk-imx93.c | 6 +++--- > drivers/clk/imx/clk-imxrt1050.c | 2 +- > drivers/clk/imx/clk.c | 5 ++--- > drivers/clk/imx/clk.h | 3 +-- > 13 files changed, 53 insertions(+), 55 deletions(-) > > diff --git a/drivers/clk/imx/clk-imx6sll.c b/drivers/clk/imx/clk-imx6sll.c > index 31d777f30039..1c9351649eab 100644 > --- a/drivers/clk/imx/clk-imx6sll.c > +++ b/drivers/clk/imx/clk-imx6sll.c > @@ -91,12 +91,12 @@ static void __init imx6sll_clocks_init(struct device_node *ccm_node) > > hws[IMX6SLL_CLK_DUMMY] = imx_clk_hw_fixed("dummy", 0); > > - hws[IMX6SLL_CLK_CKIL] = imx_obtain_fixed_clk_hw(ccm_node, "ckil"); > - hws[IMX6SLL_CLK_OSC] = imx_obtain_fixed_clk_hw(ccm_node, "osc"); > + hws[IMX6SLL_CLK_CKIL] = imx_get_clk_hw_by_name(ccm_node, "ckil"); > + hws[IMX6SLL_CLK_OSC] = imx_get_clk_hw_by_name(ccm_node, "osc"); > > /* ipp_di clock is external input */ > - hws[IMX6SLL_CLK_IPP_DI0] = imx_obtain_fixed_clk_hw(ccm_node, "ipp_di0"); > - hws[IMX6SLL_CLK_IPP_DI1] = imx_obtain_fixed_clk_hw(ccm_node, "ipp_di1"); > + hws[IMX6SLL_CLK_IPP_DI0] = imx_get_clk_hw_by_name(ccm_node, "ipp_di0"); > + hws[IMX6SLL_CLK_IPP_DI1] = imx_get_clk_hw_by_name(ccm_node, "ipp_di1"); > > np = of_find_compatible_node(NULL, NULL, "fsl,imx6sll-anatop"); > base = of_iomap(np, 0); > diff --git a/drivers/clk/imx/clk-imx6sx.c b/drivers/clk/imx/clk-imx6sx.c > index 598f3cf4eba4..b378531240e6 100644 > --- a/drivers/clk/imx/clk-imx6sx.c > +++ b/drivers/clk/imx/clk-imx6sx.c > @@ -132,16 +132,16 @@ static void __init imx6sx_clocks_init(struct device_node *ccm_node) > > hws[IMX6SX_CLK_DUMMY] = imx_clk_hw_fixed("dummy", 0); > > - hws[IMX6SX_CLK_CKIL] = imx_obtain_fixed_clk_hw(ccm_node, "ckil"); > - hws[IMX6SX_CLK_OSC] = imx_obtain_fixed_clk_hw(ccm_node, "osc"); > + hws[IMX6SX_CLK_CKIL] = imx_get_clk_hw_by_name(ccm_node, "ckil"); > + hws[IMX6SX_CLK_OSC] = imx_get_clk_hw_by_name(ccm_node, "osc"); > > /* ipp_di clock is external input */ > - hws[IMX6SX_CLK_IPP_DI0] = imx_obtain_fixed_clk_hw(ccm_node, "ipp_di0"); > - hws[IMX6SX_CLK_IPP_DI1] = imx_obtain_fixed_clk_hw(ccm_node, "ipp_di1"); > + hws[IMX6SX_CLK_IPP_DI0] = imx_get_clk_hw_by_name(ccm_node, "ipp_di0"); > + hws[IMX6SX_CLK_IPP_DI1] = imx_get_clk_hw_by_name(ccm_node, "ipp_di1"); > > /* Clock source from external clock via CLK1/2 PAD */ > - hws[IMX6SX_CLK_ANACLK1] = imx_obtain_fixed_clk_hw(ccm_node, "anaclk1"); > - hws[IMX6SX_CLK_ANACLK2] = imx_obtain_fixed_clk_hw(ccm_node, "anaclk2"); > + hws[IMX6SX_CLK_ANACLK1] = imx_get_clk_hw_by_name(ccm_node, "anaclk1"); > + hws[IMX6SX_CLK_ANACLK2] = imx_get_clk_hw_by_name(ccm_node, "anaclk2"); > > np = of_find_compatible_node(NULL, NULL, "fsl,imx6sx-anatop"); > base = of_iomap(np, 0); > diff --git a/drivers/clk/imx/clk-imx6ul.c b/drivers/clk/imx/clk-imx6ul.c > index 520b100bff4b..67a7a77ca540 100644 > --- a/drivers/clk/imx/clk-imx6ul.c > +++ b/drivers/clk/imx/clk-imx6ul.c > @@ -126,12 +126,12 @@ static void __init imx6ul_clocks_init(struct device_node *ccm_node) > > hws[IMX6UL_CLK_DUMMY] = imx_clk_hw_fixed("dummy", 0); > > - hws[IMX6UL_CLK_CKIL] = imx_obtain_fixed_clk_hw(ccm_node, "ckil"); > - hws[IMX6UL_CLK_OSC] = imx_obtain_fixed_clk_hw(ccm_node, "osc"); > + hws[IMX6UL_CLK_CKIL] = imx_get_clk_hw_by_name(ccm_node, "ckil"); > + hws[IMX6UL_CLK_OSC] = imx_get_clk_hw_by_name(ccm_node, "osc"); > > /* ipp_di clock is external input */ > - hws[IMX6UL_CLK_IPP_DI0] = imx_obtain_fixed_clk_hw(ccm_node, "ipp_di0"); > - hws[IMX6UL_CLK_IPP_DI1] = imx_obtain_fixed_clk_hw(ccm_node, "ipp_di1"); > + hws[IMX6UL_CLK_IPP_DI0] = imx_get_clk_hw_by_name(ccm_node, "ipp_di0"); > + hws[IMX6UL_CLK_IPP_DI1] = imx_get_clk_hw_by_name(ccm_node, "ipp_di1"); > > np = of_find_compatible_node(NULL, NULL, "fsl,imx6ul-anatop"); > base = of_iomap(np, 0); > diff --git a/drivers/clk/imx/clk-imx7d.c b/drivers/clk/imx/clk-imx7d.c > index cbf8131c63f7..d681b6c4b29a 100644 > --- a/drivers/clk/imx/clk-imx7d.c > +++ b/drivers/clk/imx/clk-imx7d.c > @@ -391,8 +391,8 @@ static void __init imx7d_clocks_init(struct device_node *ccm_node) > hws = clk_hw_data->hws; > > hws[IMX7D_CLK_DUMMY] = imx_clk_hw_fixed("dummy", 0); > - hws[IMX7D_OSC_24M_CLK] = imx_obtain_fixed_clk_hw(ccm_node, "osc"); > - hws[IMX7D_CKIL] = imx_obtain_fixed_clk_hw(ccm_node, "ckil"); > + hws[IMX7D_OSC_24M_CLK] = imx_get_clk_hw_by_name(ccm_node, "osc"); > + hws[IMX7D_CKIL] = imx_get_clk_hw_by_name(ccm_node, "ckil"); > > np = of_find_compatible_node(NULL, NULL, "fsl,imx7d-anatop"); > base = of_iomap(np, 0); > diff --git a/drivers/clk/imx/clk-imx7ulp.c b/drivers/clk/imx/clk-imx7ulp.c > index b6e45e77ee39..208a0ab80d5e 100644 > --- a/drivers/clk/imx/clk-imx7ulp.c > +++ b/drivers/clk/imx/clk-imx7ulp.c > @@ -59,11 +59,11 @@ static void __init imx7ulp_clk_scg1_init(struct device_node *np) > > hws[IMX7ULP_CLK_DUMMY] = imx_clk_hw_fixed("dummy", 0); > > - hws[IMX7ULP_CLK_ROSC] = imx_obtain_fixed_clk_hw(np, "rosc"); > - hws[IMX7ULP_CLK_SOSC] = imx_obtain_fixed_clk_hw(np, "sosc"); > - hws[IMX7ULP_CLK_SIRC] = imx_obtain_fixed_clk_hw(np, "sirc"); > - hws[IMX7ULP_CLK_FIRC] = imx_obtain_fixed_clk_hw(np, "firc"); > - hws[IMX7ULP_CLK_UPLL] = imx_obtain_fixed_clk_hw(np, "upll"); > + hws[IMX7ULP_CLK_ROSC] = imx_get_clk_hw_by_name(np, "rosc"); > + hws[IMX7ULP_CLK_SOSC] = imx_get_clk_hw_by_name(np, "sosc"); > + hws[IMX7ULP_CLK_SIRC] = imx_get_clk_hw_by_name(np, "sirc"); > + hws[IMX7ULP_CLK_FIRC] = imx_get_clk_hw_by_name(np, "firc"); > + hws[IMX7ULP_CLK_UPLL] = imx_get_clk_hw_by_name(np, "upll"); > > /* SCG1 */ > base = of_iomap(np, 0); > diff --git a/drivers/clk/imx/clk-imx8mm.c b/drivers/clk/imx/clk-imx8mm.c > index b6d275855b36..cb44e8148e53 100644 > --- a/drivers/clk/imx/clk-imx8mm.c > +++ b/drivers/clk/imx/clk-imx8mm.c > @@ -312,12 +312,12 @@ static int imx8mm_clocks_probe(struct platform_device *pdev) > hws = clk_hw_data->hws; > > hws[IMX8MM_CLK_DUMMY] = imx_clk_hw_fixed("dummy", 0); > - hws[IMX8MM_CLK_24M] = imx_obtain_fixed_clk_hw(np, "osc_24m"); > - hws[IMX8MM_CLK_32K] = imx_obtain_fixed_clk_hw(np, "osc_32k"); > - hws[IMX8MM_CLK_EXT1] = imx_obtain_fixed_clk_hw(np, "clk_ext1"); > - hws[IMX8MM_CLK_EXT2] = imx_obtain_fixed_clk_hw(np, "clk_ext2"); > - hws[IMX8MM_CLK_EXT3] = imx_obtain_fixed_clk_hw(np, "clk_ext3"); > - hws[IMX8MM_CLK_EXT4] = imx_obtain_fixed_clk_hw(np, "clk_ext4"); > + hws[IMX8MM_CLK_24M] = imx_get_clk_hw_by_name(np, "osc_24m"); > + hws[IMX8MM_CLK_32K] = imx_get_clk_hw_by_name(np, "osc_32k"); > + hws[IMX8MM_CLK_EXT1] = imx_get_clk_hw_by_name(np, "clk_ext1"); > + hws[IMX8MM_CLK_EXT2] = imx_get_clk_hw_by_name(np, "clk_ext2"); > + hws[IMX8MM_CLK_EXT3] = imx_get_clk_hw_by_name(np, "clk_ext3"); > + hws[IMX8MM_CLK_EXT4] = imx_get_clk_hw_by_name(np, "clk_ext4"); > > np = of_find_compatible_node(NULL, NULL, "fsl,imx8mm-anatop"); > base = of_iomap(np, 0); > diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c > index d37c45b676ab..c765d1219cbf 100644 > --- a/drivers/clk/imx/clk-imx8mn.c > +++ b/drivers/clk/imx/clk-imx8mn.c > @@ -332,12 +332,12 @@ static int imx8mn_clocks_probe(struct platform_device *pdev) > hws = clk_hw_data->hws; > > hws[IMX8MN_CLK_DUMMY] = imx_clk_hw_fixed("dummy", 0); > - hws[IMX8MN_CLK_24M] = imx_obtain_fixed_clk_hw(np, "osc_24m"); > - hws[IMX8MN_CLK_32K] = imx_obtain_fixed_clk_hw(np, "osc_32k"); > - hws[IMX8MN_CLK_EXT1] = imx_obtain_fixed_clk_hw(np, "clk_ext1"); > - hws[IMX8MN_CLK_EXT2] = imx_obtain_fixed_clk_hw(np, "clk_ext2"); > - hws[IMX8MN_CLK_EXT3] = imx_obtain_fixed_clk_hw(np, "clk_ext3"); > - hws[IMX8MN_CLK_EXT4] = imx_obtain_fixed_clk_hw(np, "clk_ext4"); > + hws[IMX8MN_CLK_24M] = imx_get_clk_hw_by_name(np, "osc_24m"); > + hws[IMX8MN_CLK_32K] = imx_get_clk_hw_by_name(np, "osc_32k"); > + hws[IMX8MN_CLK_EXT1] = imx_get_clk_hw_by_name(np, "clk_ext1"); > + hws[IMX8MN_CLK_EXT2] = imx_get_clk_hw_by_name(np, "clk_ext2"); > + hws[IMX8MN_CLK_EXT3] = imx_get_clk_hw_by_name(np, "clk_ext3"); > + hws[IMX8MN_CLK_EXT4] = imx_get_clk_hw_by_name(np, "clk_ext4"); > > np = of_find_compatible_node(NULL, NULL, "fsl,imx8mn-anatop"); > base = of_iomap(np, 0); > diff --git a/drivers/clk/imx/clk-imx8mp.c b/drivers/clk/imx/clk-imx8mp.c > index 652ae58c2735..b6d03cf5b1ce 100644 > --- a/drivers/clk/imx/clk-imx8mp.c > +++ b/drivers/clk/imx/clk-imx8mp.c > @@ -436,12 +436,12 @@ static int imx8mp_clocks_probe(struct platform_device *pdev) > hws = clk_hw_data->hws; > > hws[IMX8MP_CLK_DUMMY] = imx_clk_hw_fixed("dummy", 0); > - hws[IMX8MP_CLK_24M] = imx_obtain_fixed_clk_hw(np, "osc_24m"); > - hws[IMX8MP_CLK_32K] = imx_obtain_fixed_clk_hw(np, "osc_32k"); > - hws[IMX8MP_CLK_EXT1] = imx_obtain_fixed_clk_hw(np, "clk_ext1"); > - hws[IMX8MP_CLK_EXT2] = imx_obtain_fixed_clk_hw(np, "clk_ext2"); > - hws[IMX8MP_CLK_EXT3] = imx_obtain_fixed_clk_hw(np, "clk_ext3"); > - hws[IMX8MP_CLK_EXT4] = imx_obtain_fixed_clk_hw(np, "clk_ext4"); > + hws[IMX8MP_CLK_24M] = imx_get_clk_hw_by_name(np, "osc_24m"); > + hws[IMX8MP_CLK_32K] = imx_get_clk_hw_by_name(np, "osc_32k"); > + hws[IMX8MP_CLK_EXT1] = imx_get_clk_hw_by_name(np, "clk_ext1"); > + hws[IMX8MP_CLK_EXT2] = imx_get_clk_hw_by_name(np, "clk_ext2"); > + hws[IMX8MP_CLK_EXT3] = imx_get_clk_hw_by_name(np, "clk_ext3"); > + hws[IMX8MP_CLK_EXT4] = imx_get_clk_hw_by_name(np, "clk_ext4"); > > hws[IMX8MP_AUDIO_PLL1_REF_SEL] = imx_clk_hw_mux("audio_pll1_ref_sel", anatop_base + 0x0, 0, 2, pll_ref_sels, ARRAY_SIZE(pll_ref_sels)); > hws[IMX8MP_AUDIO_PLL2_REF_SEL] = imx_clk_hw_mux("audio_pll2_ref_sel", anatop_base + 0x14, 0, 2, pll_ref_sels, ARRAY_SIZE(pll_ref_sels)); > diff --git a/drivers/clk/imx/clk-imx8mq.c b/drivers/clk/imx/clk-imx8mq.c > index 882dcad4817d..2bcaec19a999 100644 > --- a/drivers/clk/imx/clk-imx8mq.c > +++ b/drivers/clk/imx/clk-imx8mq.c > @@ -297,13 +297,13 @@ static int imx8mq_clocks_probe(struct platform_device *pdev) > hws = clk_hw_data->hws; > > hws[IMX8MQ_CLK_DUMMY] = imx_clk_hw_fixed("dummy", 0); > - hws[IMX8MQ_CLK_32K] = imx_obtain_fixed_clk_hw(np, "ckil"); > - hws[IMX8MQ_CLK_25M] = imx_obtain_fixed_clk_hw(np, "osc_25m"); > - hws[IMX8MQ_CLK_27M] = imx_obtain_fixed_clk_hw(np, "osc_27m"); > - hws[IMX8MQ_CLK_EXT1] = imx_obtain_fixed_clk_hw(np, "clk_ext1"); > - hws[IMX8MQ_CLK_EXT2] = imx_obtain_fixed_clk_hw(np, "clk_ext2"); > - hws[IMX8MQ_CLK_EXT3] = imx_obtain_fixed_clk_hw(np, "clk_ext3"); > - hws[IMX8MQ_CLK_EXT4] = imx_obtain_fixed_clk_hw(np, "clk_ext4"); > + hws[IMX8MQ_CLK_32K] = imx_get_clk_hw_by_name(np, "ckil"); > + hws[IMX8MQ_CLK_25M] = imx_get_clk_hw_by_name(np, "osc_25m"); > + hws[IMX8MQ_CLK_27M] = imx_get_clk_hw_by_name(np, "osc_27m"); > + hws[IMX8MQ_CLK_EXT1] = imx_get_clk_hw_by_name(np, "clk_ext1"); > + hws[IMX8MQ_CLK_EXT2] = imx_get_clk_hw_by_name(np, "clk_ext2"); > + hws[IMX8MQ_CLK_EXT3] = imx_get_clk_hw_by_name(np, "clk_ext3"); > + hws[IMX8MQ_CLK_EXT4] = imx_get_clk_hw_by_name(np, "clk_ext4"); > > np = of_find_compatible_node(NULL, NULL, "fsl,imx8mq-anatop"); > base = of_iomap(np, 0); > diff --git a/drivers/clk/imx/clk-imx93.c b/drivers/clk/imx/clk-imx93.c > index 99cff1fd108b..e6f05709d8c2 100644 > --- a/drivers/clk/imx/clk-imx93.c > +++ b/drivers/clk/imx/clk-imx93.c > @@ -270,9 +270,9 @@ static int imx93_clocks_probe(struct platform_device *pdev) > clks = clk_hw_data->hws; > > clks[IMX93_CLK_DUMMY] = imx_clk_hw_fixed("dummy", 0); > - clks[IMX93_CLK_24M] = imx_obtain_fixed_clk_hw(np, "osc_24m"); > - clks[IMX93_CLK_32K] = imx_obtain_fixed_clk_hw(np, "osc_32k"); > - clks[IMX93_CLK_EXT1] = imx_obtain_fixed_clk_hw(np, "clk_ext1"); > + clks[IMX93_CLK_24M] = imx_get_clk_hw_by_name(np, "osc_24m"); > + clks[IMX93_CLK_32K] = imx_get_clk_hw_by_name(np, "osc_32k"); > + clks[IMX93_CLK_EXT1] = imx_get_clk_hw_by_name(np, "clk_ext1"); > > clks[IMX93_CLK_SYS_PLL_PFD0] = imx_clk_hw_fixed("sys_pll_pfd0", 1000000000); > clks[IMX93_CLK_SYS_PLL_PFD0_DIV2] = imx_clk_hw_fixed_factor("sys_pll_pfd0_div2", > diff --git a/drivers/clk/imx/clk-imxrt1050.c b/drivers/clk/imx/clk-imxrt1050.c > index 9539d35588ee..d7c978b63ed5 100644 > --- a/drivers/clk/imx/clk-imxrt1050.c > +++ b/drivers/clk/imx/clk-imxrt1050.c > @@ -50,7 +50,7 @@ static int imxrt1050_clocks_probe(struct platform_device *pdev) > clk_hw_data->num = IMXRT1050_CLK_END; > hws = clk_hw_data->hws; > > - hws[IMXRT1050_CLK_OSC] = imx_obtain_fixed_clk_hw(np, "osc"); > + hws[IMXRT1050_CLK_OSC] = imx_get_clk_hw_by_name(np, "osc"); > > anp = of_find_compatible_node(NULL, NULL, "fsl,imxrt-anatop"); > pll_base = of_iomap(anp, 0); > diff --git a/drivers/clk/imx/clk.c b/drivers/clk/imx/clk.c > index 5582f18dd632..b636cc099d96 100644 > --- a/drivers/clk/imx/clk.c > +++ b/drivers/clk/imx/clk.c > @@ -110,8 +110,7 @@ struct clk_hw *imx_obtain_fixed_clock_hw( > return __clk_get_hw(clk); > } > > -struct clk_hw * imx_obtain_fixed_clk_hw(struct device_node *np, > - const char *name) > +struct clk_hw *imx_get_clk_hw_by_name(struct device_node *np, const char *name) > { > struct clk *clk; > > @@ -121,7 +120,7 @@ struct clk_hw * imx_obtain_fixed_clk_hw(struct device_node *np, > > return __clk_get_hw(clk); > } > -EXPORT_SYMBOL_GPL(imx_obtain_fixed_clk_hw); > +EXPORT_SYMBOL_GPL(imx_get_clk_hw_by_name); > > /* > * This fixups the register CCM_CSCMR1 write value. > diff --git a/drivers/clk/imx/clk.h b/drivers/clk/imx/clk.h > index dd49f90110e8..689b3ad927c0 100644 > --- a/drivers/clk/imx/clk.h > +++ b/drivers/clk/imx/clk.h > @@ -288,8 +288,7 @@ struct clk * imx_obtain_fixed_clock( > struct clk_hw *imx_obtain_fixed_clock_hw( > const char *name, unsigned long rate); > > -struct clk_hw *imx_obtain_fixed_clk_hw(struct device_node *np, > - const char *name); > +struct clk_hw *imx_get_clk_hw_by_name(struct device_node *np, const char *name); > > struct clk_hw *imx_clk_hw_gate_exclusive(const char *name, const char *parent, > void __iomem *reg, u8 shift, u32 exclusive_mask); > -- > 2.32.0 >