Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Pass (protection.outlook.com: domain of amd.com designates
 165.204.84.17 as permitted sender) receiver=protection.outlook.com;
 client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C
Message-ID: <6ed85ced-1d85-5620-881e-943fa4bc71d9@amd.com>
Date:   Fri, 25 Nov 2022 10:24:24 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH v11 4/6] firmware: xilinx: Add shutdown/wakeup APIs
Content-Language: en-US
To:     Tanmay Shah <tanmay.shah@amd.com>, <andersson@kernel.org>,
        <mathieu.poirier@linaro.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>
CC:     <bill.mills@linaro.org>, <linux-remoteproc@vger.kernel.org>,
        <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, Ben Levinsky <ben.levinsky@amd.com>
References: <20221114233940.2096237-1-tanmay.shah@amd.com>
 <20221114233940.2096237-5-tanmay.shah@amd.com>
From:   Michal Simek <michal.simek@amd.com>
In-Reply-To: <20221114233940.2096237-5-tanmay.shah@amd.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2022 09:24:54.4129
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: b0adc978-6a31-4911-23d1-08dacec6e9a2
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com]
X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT086.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7505
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/15/22 00:39, Tanmay Shah wrote:
> From: Ben Levinsky <ben.levinsky@amd.com>
> 
> Add shutdown/wakeup a resource eemi operations to shutdown
> or bringup a resource.
> 
> Note alignment of args matches convention of other fn's in this file.
> The reason being that the long fn name results in aligned args that
> otherwise go over 80 chars so shift right to avoid this
> 
> Signed-off-by: Ben Levinsky <ben.levinsky@amd.com>
> Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
> ---
> 
> Changes in v11:
>    - Rebase on latest rproc-next branch and resolve merge conflicts
> 
> Changes in v10:
>    - None
> 
> Changes in v9:
>    - None
> 
> Changes in v8:
>    - None
> 
> Changes in v7:
>    - None
> 
> Changes in v6:
>    - None
> 
> Changes in v5:
>    - None
> 
> Changes in v4:
>    - None
> 
> Changes in v3:
>    - None
> 
>   drivers/firmware/xilinx/zynqmp.c     | 35 ++++++++++++++++++++++++++++
>   include/linux/firmware/xlnx-zynqmp.h | 23 ++++++++++++++++++
>   2 files changed, 58 insertions(+)
> 
> diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
> index ff5cabe70a2b..1865e43ed7e7 100644
> --- a/drivers/firmware/xilinx/zynqmp.c
> +++ b/drivers/firmware/xilinx/zynqmp.c
> @@ -1159,6 +1159,41 @@ int zynqmp_pm_release_node(const u32 node)
>   }
>   EXPORT_SYMBOL_GPL(zynqmp_pm_release_node);
>   
> +/**
> + * zynqmp_pm_force_pwrdwn - PM call to request for another PU or subsystem to
> + *             be powered down forcefully
> + * @node:  Node ID of the targeted PU or subsystem
> + * @ack:   Flag to specify whether acknowledge is requested
> + *
> + * Return: status, either success or error+reason
> + */
> +int zynqmp_pm_force_pwrdwn(const u32 node,
> +			   const enum zynqmp_pm_request_ack ack)
> +{
> +	return zynqmp_pm_invoke_fn(PM_FORCE_POWERDOWN, node, ack, 0, 0, NULL);
> +}
> +EXPORT_SYMBOL_GPL(zynqmp_pm_force_pwrdwn);
> +
> +/**
> + * zynqmp_pm_request_wake - PM call to wake up selected master or subsystem
> + * @node:  Node ID of the master or subsystem
> + * @set_addr:  Specifies whether the address argument is relevant
> + * @address:   Address from which to resume when woken up
> + * @ack:   Flag to specify whether acknowledge requested
> + *
> + * Return: status, either success or error+reason
> + */
> +int zynqmp_pm_request_wake(const u32 node,
> +			   const bool set_addr,
> +			   const u64 address,
> +			   const enum zynqmp_pm_request_ack ack)
> +{
> +	/* set_addr flag is encoded into 1st bit of address */
> +	return zynqmp_pm_invoke_fn(PM_REQUEST_WAKEUP, node, address | set_addr,
> +				   address >> 32, ack, NULL);
> +}
> +EXPORT_SYMBOL_GPL(zynqmp_pm_request_wake);
> +
>   /**
>    * zynqmp_pm_set_requirement() - PM call to set requirement for PM slaves
>    * @node:		Node ID of the slave
> diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h
> index bdbf855b5eef..ad3f2bd0c470 100644
> --- a/include/linux/firmware/xlnx-zynqmp.h
> +++ b/include/linux/firmware/xlnx-zynqmp.h
> @@ -12,6 +12,7 @@
>   
>   #ifndef __FIRMWARE_ZYNQMP_H__
>   #define __FIRMWARE_ZYNQMP_H__
> +#include <linux/types.h>
>   
>   #include <linux/err.h>
>   
> @@ -87,6 +88,8 @@ enum pm_api_cb_id {
>   enum pm_api_id {
>   	PM_GET_API_VERSION = 1,
>   	PM_REGISTER_NOTIFIER = 5,
> +	PM_FORCE_POWERDOWN = 8,
> +	PM_REQUEST_WAKEUP = 10,
>   	PM_SYSTEM_SHUTDOWN = 12,
>   	PM_REQUEST_NODE = 13,
>   	PM_RELEASE_NODE = 14,
> @@ -521,6 +524,12 @@ int zynqmp_pm_is_function_supported(const u32 api_id, const u32 id);
>   int zynqmp_pm_set_feature_config(enum pm_feature_config_id id, u32 value);
>   int zynqmp_pm_get_feature_config(enum pm_feature_config_id id, u32 *payload);
>   int zynqmp_pm_register_sgi(u32 sgi_num, u32 reset);
> +int zynqmp_pm_force_pwrdwn(const u32 target,
> +			   const enum zynqmp_pm_request_ack ack);
> +int zynqmp_pm_request_wake(const u32 node,
> +			   const bool set_addr,
> +			   const u64 address,
> +			   const enum zynqmp_pm_request_ack ack);
>   int zynqmp_pm_set_sd_config(u32 node, enum pm_sd_config_type config, u32 value);
>   int zynqmp_pm_set_gem_config(u32 node, enum pm_gem_config_type config,
>   			     u32 value);
> @@ -795,6 +804,20 @@ static inline int zynqmp_pm_register_sgi(u32 sgi_num, u32 reset)
>   	return -ENODEV;
>   }
>   
> +static inline int zynqmp_pm_force_pwrdwn(const u32 target,
> +					 const enum zynqmp_pm_request_ack ack)
> +{
> +	return -ENODEV;
> +}
> +
> +static inline int zynqmp_pm_request_wake(const u32 node,
> +					 const bool set_addr,
> +					 const u64 address,
> +					 const enum zynqmp_pm_request_ack ack)
> +{
> +	return -ENODEV;
> +}
> +
>   static inline int zynqmp_pm_set_sd_config(u32 node,
>   					  enum pm_sd_config_type config,
>   					  u32 value)

Acked-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal