Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp10238161rwb; Fri, 25 Nov 2022 02:38:04 -0800 (PST) X-Google-Smtp-Source: AA0mqf4a2qYur9FSzqONiLsZwkvs35H8nWFMv2qIyGTTjJj69F4AnI9dFsvzEQ4HsOelCEBF4n8H X-Received: by 2002:a17:906:442:b0:7ad:7d4a:ec2c with SMTP id e2-20020a170906044200b007ad7d4aec2cmr16353866eja.710.1669372684468; Fri, 25 Nov 2022 02:38:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669372684; cv=none; d=google.com; s=arc-20160816; b=f5tRWDjgcakgtS/Qxtskj6afog5o3Nnn/HFBG1qhxXGKYfA0xLtg24q8XIkZ1GDuw9 Uf5pMje8IsCXve0rH6q6ibnZ92p+hhO1G55h3odOID5HbI4qCb1sOpKKWs0nEjTQLWup 0WEXciQoYzvHZbsqlNQVx4Z/ZmB2O/zpke4fBbvJqYF3uCeiVyk86w8Y9z8mBua0AnJZ xqZa4pZ/LWB3i52HOaZFUFCHfqf4Eg41aEKMTKQ4cjxfbu2mj92HWONjHrU1f/HTap2q kXMDEzKv7uBeztEJHwBCx1omEPVodMJMoto+8Lh6fMj/xAOo8/eREqNVWUFOAqj3E2XE GXQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=hrGPbt7+gFrjOqTTDVA9r8HJGdi2ZWQrKu6kob6wExQ=; b=UWznSkzpDtKTdtFplRlu6q9hFjMtI6KAu2xbPcfyEyZaZw0QOEOTSY7nmaHPCF7cr0 hLsNrYvK/BOswnirjUqJ2be2i8t7AgoXaDtpxTZR6v8OEZgKFrmqObVcB2aa3WwaZWTi gXmUndVd8rjZ3JfhYytB5KwQEnZ63DLIs4+RlfGuCAchotvk4gtpKMtMoh1zst21G7z/ 1HQ6y8BPnWkgKdq9Z9PhA2WU0ude69Xw0WNBWgfxNiAMaFZIWkwkhZU+j4lUK/6w6h/f qzVDXHA76KygQbEYoLc2OOgQsZyTT+6z7oyx20rorIqiYiW63zTlHvm4hhKLeGZrdkXq ptZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HSxmUv5F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n9-20020a05640205c900b00453688643fasi3277723edx.260.2022.11.25.02.37.43; Fri, 25 Nov 2022 02:38:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HSxmUv5F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229527AbiKYJwc (ORCPT + 86 others); Fri, 25 Nov 2022 04:52:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229980AbiKYJwQ (ORCPT ); Fri, 25 Nov 2022 04:52:16 -0500 Received: from mail-yw1-x112b.google.com (mail-yw1-x112b.google.com [IPv6:2607:f8b0:4864:20::112b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08A424B75F for ; Fri, 25 Nov 2022 01:50:08 -0800 (PST) Received: by mail-yw1-x112b.google.com with SMTP id 00721157ae682-3a7081e3b95so36754657b3.1 for ; Fri, 25 Nov 2022 01:50:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=hrGPbt7+gFrjOqTTDVA9r8HJGdi2ZWQrKu6kob6wExQ=; b=HSxmUv5FKMmGGgQMiYABH+USehR8qx4VYLZNSXjSsNxFAYaLigsuYU2V6FTKkuXQGl VjUj99v7MF25itLp1fwr5PfVEzjdQ4PCztIiXL7aoGdpVM80JTx55W18b2YAqGihxOJl OPITq8Cir3YtTo8TbQhCq3SaEBsJKz+58uO7hAskLQqpxND60e8DOJhrzQhkVed7M4oP JyZ6Tng/432MbYrAkyO4lG3PesKgFSXtjtz0RH/R9IzOt3GJmYlXZEy6mcLveDDlueuR yx9dz6QuJNuihbZJA50hb1m04nn4CQKK3PkQtCOy8vDoMt8tjB33UG+bjZR3tbCk5gDa KiPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hrGPbt7+gFrjOqTTDVA9r8HJGdi2ZWQrKu6kob6wExQ=; b=NswR3h1kjYamXQRSrhjx47UTieFinnMC1ta+rYtTzPtDokZaBMuhxnwW0XnMs9HdkX maEk3VrIZIiuOoZICLGDv5Whl2d+us7m0l4xmK4Pw5XnE012/8XjSPCmV4p0C0j2Ink4 wF381bPB7oWn9u+E9JrtWkTHjvRX0A9pjSdRaGNmCJ8Y29QbLFWFTfEfmK5UuJV7IJC/ wK/53jCGFWomxBv1SWMF3xFUYYDq6W0c5ykqO97VB4eBhs+Lxmor5q0KWg1oE/k6o9ov old/+707wwzaEfOQwowoHyg16tl5m44t971Jq8lTcnMPOkNn4k1bTpW66ocXaqx4wo1E lw5A== X-Gm-Message-State: ANoB5pnasew3K+8YukaQVtDopEOUdBwdMf0llY5nyb5YDdmoN51SupxF 1ltg+mbVs+jb6wj9d/mKt/SMop5DwUM6pZEXTiKYbA== X-Received: by 2002:a05:690c:285:b0:3ab:189e:3465 with SMTP id bf5-20020a05690c028500b003ab189e3465mr15273059ywb.343.1669369807253; Fri, 25 Nov 2022 01:50:07 -0800 (PST) MIME-Version: 1.0 References: <20221125070156.3535855-1-zhangpeng362@huawei.com> In-Reply-To: <20221125070156.3535855-1-zhangpeng362@huawei.com> From: Linus Walleij Date: Fri, 25 Nov 2022 10:49:56 +0100 Message-ID: Subject: Re: [PATCH] pinctrl: pinconf-generic: add missing of_node_put() in pinconf_generic_dt_node_to_map() To: Peng Zhang Cc: baruch@tkos.co.il, ldewangan@nvidia.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, sunnanyong@huawei.com, wangkefeng.wang@huawei.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 25, 2022 at 8:02 AM Peng Zhang wrote: > From: ZhangPeng > > of_node_put() needs to be called when jumping out of the loop, since > for_each_available_child_of_node() will increase the refcount of node. > > Fixes: c7289500e29d ("pinctrl: pinconf-generic: scan also referenced phandle node") > Signed-off-by: ZhangPeng Good catch! Patch applied. Yours, Linus Walleij