Date: Sun, 12 Aug 2007 07:17:21 -0700
From: Paul Jackson <pj@sgi.com>
To: Fredrik Noring <noring@nocrew.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Improving read/write/close system call reliability when used
 with pthreads
Message-Id: <20070812071721.f35d7373.pj@sgi.com>
In-Reply-To: <70E19A0A-2728-4ADA-B984-A36182C1F575@nocrew.org>
References: <70E19A0A-2728-4ADA-B984-A36182C1F575@nocrew.org>
Organization: SGI
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1375
Lines: 39

Fredrik wrote:
> required-fds.patch (not sure Apple Mail can handle this properly  
> though...):

You suspected correctly - Apple Mail line wrapped it at 72 columns
(added newlines in any line going past column 72.)  This makes it
impossible to apply the patch without alot of hand editing.

As you probably also suspect (correctly, again), given the volume of
patches we handle on lkml, the burden is on the submitter to get the
patch format correct, so it applies cleanly.

You will have to experiment some, sending the patch to yourself and
being sure that it applies cleanly.  I'm not an Apple Mail expert, so
can't help; sorry.  Perhaps some other email program ...?


For example, this line wrapped:

fs/open.c                 |   63 +++++++++++++++++++++++++++++++++++++ 
+++++++++

and more critically, in the patch, many lines, such as:

+/* file descriptors required to complete current I/O operation  
successfully */
+	struct list_head required_fds;


-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/