Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sherry Sun <sherry.sun@nxp.com>
To:     gregkh@linuxfoundation.org, jirislaby@kernel.org
Cc:     linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-imx@nxp.com, atsushi.nemoto@sord.co.jp,
        tomonori.sakita@sord.co.jp
Subject: [PATCH V3 2/3] tty: serial: fsl_lpuart: disable Rx/Tx DMA in lpuart32_shutdown()
Date:   Fri, 25 Nov 2022 18:19:52 +0800
Message-Id: <20221125101953.18753-3-sherry.sun@nxp.com>
In-Reply-To: <20221125101953.18753-1-sherry.sun@nxp.com>
References: <20221125101953.18753-1-sherry.sun@nxp.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JTo2DVud1fL1TO2w3owc7WGT60FrOHdqX0plzxC7auOrv2Y4f5LeJf3J0ORF?=
 =?us-ascii?Q?2jLP2JNpukS/+ktXzn8K95Te6xLswAWuy9pBsHPASsUmODvr/7BngKw7DPL9?=
 =?us-ascii?Q?dSDaDFkzk+9AwBlMrtLhofMsR07ItkR4m84nQDHOP25bLKEUyEtADgrdTz4U?=
 =?us-ascii?Q?zoMqHkRPQfoNPdCMUIEplPXuoe1/s1SmixbQb2QS0Xz6kGyFJKPiX8k9CRzb?=
 =?us-ascii?Q?lEgXxt7lNC803c2VllYNsza9alsiWQEoGpFPG4xb6sEuQVS5gf6QrCCxl7Gv?=
 =?us-ascii?Q?/etPFmpJMf0dTHiOmYJZs8FiNpy/VkRxrXa6lOnlR23U8kNioxjFvUQ7XJiw?=
 =?us-ascii?Q?g53gpyd/oElQtD9tZdf+N5tAxp4TEoOr+XNSWEJYDWPujTCL2zwLVNg9CWSk?=
 =?us-ascii?Q?QwghaVKsZ8gnyhEWlDplI13CtqkWPMe6EL5toS5lxjSUtT3MIVWyc+WnHtuZ?=
 =?us-ascii?Q?CL6Ld9UTBe2zbeA9S+7Zd7F4YpsV6aDcDr8CFPROjtAM1KBzLac8jrdsPqyR?=
 =?us-ascii?Q?yzc0OEEY2GikNjeWxIJGjF3yJo4Z8pPrGookF9q3VTLCeo8ACdNOZZVGhLy/?=
 =?us-ascii?Q?KitwmPXrPpri1phIb0jn0Frv7blwP3QGjTGZHYSgrSI+4kFPGHThkBxUUiyE?=
 =?us-ascii?Q?iG5cyFhw3NNW94vkirF2ylVfijsr3go0ch0yO9e5Fr7rrdPcAy44VuIsETQL?=
 =?us-ascii?Q?FraoadzPjI4gcVKXASasK4dk7POvDpNWdxNLCVid4HQz/U+UgW1l18/tIUq9?=
 =?us-ascii?Q?eUjxDO+xSlvpnes1FwX78t7FA7lCuMe1/loIPe4BBUikdT/tRhv0b1SCMTI8?=
 =?us-ascii?Q?qSzlNLvzoaY7UqK59lHLAipltggXoUkDzL9ZlLTe6cFL717Cm9G0Lki6vxz4?=
 =?us-ascii?Q?nuU/8o4FwFjIYlV/53JLJ8rVc5O1BBG7UJXYkhAIc/qrqrn0+3zzaFPhvIWD?=
 =?us-ascii?Q?lypCup31u1NSt2Y2dB5Ht+0bQyfu3VQEQD0fh7VD5aOuakqu3w+mc5TlMNf+?=
 =?us-ascii?Q?M0ky2Id4/4wYCsH9H7mZOEZ6WnSZE6nwmh/99xm02IrneFnyJl2RtIxrPws1?=
 =?us-ascii?Q?wcBEpSztjDLk/iE4w+nPs4QJWt9A9gDvHyU/FkJpmqHePQL83hyMk9X9oN2T?=
 =?us-ascii?Q?iC4NrYUFR6ZeXbFJdZDijpCuOjRo7plZ10e9Se3JGVj5nlOPNMsufKu7Aq0n?=
 =?us-ascii?Q?D4R420diaOEdMqOm9NIN7QEixe8v2zCPlztmi3iW9qInCPbQU/La3qHDi2iI?=
 =?us-ascii?Q?3rDy15WCcPNs8S+QNUSnxHlhW1JilFPQFThpu0q4g5OyWSBvv2YhKma4LoLB?=
 =?us-ascii?Q?RYbFKD3c5l/umuvilTPN5tsdh4VzfHsSb0RQ4twbpAgQcQSYSvztyAvkPP2K?=
 =?us-ascii?Q?y09qiX6SJF5FpEmwyf+miquzsKRCy2FQ3aK0IoY6jqHRVOB13tJDKc9Xwmei?=
 =?us-ascii?Q?95zFsAxtGM0nMJJK5N1epyrhwLmZxrAUAoa5obCol/n6EYAm+6aLPn0tS2zz?=
 =?us-ascii?Q?j6Cf8M7mdYJKt5oLPz7wa0GxA/blxfgl3C+v1u9L8xwk7TYg4MPdfLq0owWl?=
 =?us-ascii?Q?a85bpv5vWIyYMRz4u7MSVmBdqrnQejl3Kvd+Te8W?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 30e48755-a469-4bf9-0ab8-08dacecf2302
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8404.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2022 10:23:47.0059
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CpjBYtH7ZJ2BxHDTfQjytZQFBvSaL7BUI0faNZZoJsp64Gy4Y49v+GKBAogNM4wfmDNKlk/37bj7tYvnGJV73w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6927
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

UARTBAUD_RDMAE and UARTBAUD_TDMAE are enabled in lpuart32_startup(), but
lpuart32_shutdown() not disable them, only free the dma ring buffer and
release the dma channels, so here disable the Rx/Tx DMA first in
lpuart32_shutdown().

Fixes: 42b68768e51b ("serial: fsl_lpuart: DMA support for 32-bit variant")
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
 drivers/tty/serial/fsl_lpuart.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index 9b8d32262f1e..88697ddcd8c4 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -1799,6 +1799,11 @@ static void lpuart32_shutdown(struct uart_port *port)
 
 	spin_lock_irqsave(&port->lock, flags);
 
+	/* disable Rx/Tx DMA */
+	temp = lpuart32_read(port, UARTBAUD);
+	temp &= ~(UARTBAUD_TDMAE | UARTBAUD_RDMAE);
+	lpuart32_write(port, temp, UARTBAUD);
+
 	/* disable Rx/Tx and interrupts */
 	temp = lpuart32_read(port, UARTCTRL);
 	temp &= ~(UARTCTRL_TE | UARTCTRL_RE | UARTCTRL_ILIE |
-- 
2.17.1