Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221122202245.449198-1-nfrayer@baylibre.com> <20221122202245.449198-2-nfrayer@baylibre.com>
 <db869c2f-d34f-1ce5-22f9-634a8454ee79@ti.com>
In-Reply-To: <db869c2f-d34f-1ce5-22f9-634a8454ee79@ti.com>
From:   Nicolas Frayer <nfrayer@baylibre.com>
Date:   Fri, 25 Nov 2022 11:36:14 +0100
Message-ID: <CANyCTtSYQKtgXZ0c5VaLoMUPaPwq3ZyMcONkJfig75eA0q7E5Q@mail.gmail.com>
Subject: Re: [PATCH 1/3] arm64: arch_k3: Removed ti mailbox and sci select
To:     Vignesh Raghavendra <vigneshr@ti.com>
Cc:     nm@ti.com, kristo@kernel.org, ssantosh@kernel.org,
        linux-arm-kernel@lists.infradead.org, jassisinghbrar@gmail.com,
        catalin.marinas@arm.com, will@kernel.org,
        linux-kernel@vger.kernel.org, khilman@baylibre.com,
        glaroque@baylibre.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Le jeu. 24 nov. 2022 =C3=A0 15:29, Vignesh Raghavendra <vigneshr@ti.com> a =
=C3=A9crit :
>
>
>
> On 23/11/22 1:52 am, Nicolas Frayer wrote:
> > In order to build ti mailbox and ti sci as modules,
> > remove their automatic selection by ARCH_K3
> >
>
> $Subject: s/Removed/Remove,
> s/ti/TI
> s/sci/SCI
>
> > Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com>
> > ---
> >  arch/arm64/Kconfig.platforms | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platform=
s
> > index 912529ac58b3..5f16eb498dbf 100644
> > --- a/arch/arm64/Kconfig.platforms
> > +++ b/arch/arm64/Kconfig.platforms
> > @@ -126,8 +126,6 @@ config ARCH_K3
> >       select PM_GENERIC_DOMAINS if PM
> >       select MAILBOX
> >       select SOC_TI
> > -     select TI_MESSAGE_MANAGER
> > -     select TI_SCI_PROTOCOL
> >       select TI_SCI_INTR_IRQCHIP
> >       select TI_SCI_INTA_IRQCHIP
> >       help
>
>
> Why not use "imply" instead of "select". This should allow TI_SCI*
> drivers to be built as modules if required. Would make 2/3 and 3/3
> redundant.
>
> Also, note that 1/3, 2/3 and 3/3 have to go through 3 different trees,
> so not a great idea to post as a single series.
>
> Regards
> Vignesh

Thanks Vignesh, I'll send a v2 using imply and drop 2/3 and 3/3