Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8cd6fc0f-0824-46e3-2b4a-aca5d968c6a7@linaro.org>
Date:   Fri, 25 Nov 2022 12:39:58 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH v2 1/2] dt-bindings: mfd: syscon: Add tesla compatibles
 found on FSD SoC
Content-Language: en-US
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To:     Sriranjani P <sriranjani.p@samsung.com>, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, lee@kernel.org,
        devicetree@vger.kernel.org, alim.akhtar@samsung.com,
        pankaj.dubey@samsung.com, ravi.patel@samsung.com,
        Sam Protsenko <semen.protsenko@linaro.org>,
        Chanho Park <chanho61.park@samsung.com>
Cc:     linux-kernel@vger.kernel.org
References: <20221125070657.28335-1-sriranjani.p@samsung.com>
 <CGME20221125070709epcas5p329c4a6d9caf4e9903b60f2e6624fb7b3@epcas5p3.samsung.com>
 <20221125070657.28335-2-sriranjani.p@samsung.com>
 <13a33962-ac55-e3f1-933a-a9addf9bc10d@linaro.org>
In-Reply-To: <13a33962-ac55-e3f1-933a-a9addf9bc10d@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 25/11/2022 12:29, Krzysztof Kozlowski wrote:
> On 25/11/2022 08:06, Sriranjani P wrote:
>> Add compatible for Tesla SYSREG controllers found on FSD SoC.
>>
>> Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
>> ---
> 
> Thank you for your patch. There is something to discuss/improve.
> 
>>  Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
>> index 4e4baf53796d..8c3334999bec 100644
>> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
>> @@ -69,6 +69,7 @@ properties:
>>                - samsung,exynos5433-sysreg
>>                - samsung,exynos850-sysreg
>>                - samsung,exynosautov9-sysreg
>> +              - tesla,fsd-sysreg
> 
> I think we made mistake starting from 5433. Before (Exynos3/4/5) there
> was only one block called actually SYSREG. For example on Exynos5433 we
> have SYSREG_DISP, SYSREG_CAM1 and so on. These are different so we
> should have dedicated compatibles. The same for Tesla - please provide
> dedicated compatibles per each block.
> 
> I'll fix Exynos5433. Maybe someone can also fix Exynos850 and Autov9.

To clarify - in case of Tesla, you do not need the fallbacks, so you
just add few of:
   - tesla,fsd-xxx-sysreg
within the enum.

For Exynos850 and Autov9, just like for Exynso5433, we should keep it
backwards compatible, so we need fallbacks.

Best regards,
Krzysztof