Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp10476423rwb; Fri, 25 Nov 2022 05:07:39 -0800 (PST) X-Google-Smtp-Source: AA0mqf4aByIj84IvXb3q+v1W6sc9hE2GYmsQL2leAudJX8/3RUxdHQ7ZH2L6lmgndiS5vLhHC1k4 X-Received: by 2002:a05:651c:1601:b0:277:3a1:e86d with SMTP id f1-20020a05651c160100b0027703a1e86dmr7509882ljq.152.1669381649764; Fri, 25 Nov 2022 05:07:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669381649; cv=none; d=google.com; s=arc-20160816; b=JhPHLzsUYTHJ8oWcQfN3plQMv0+8tyStFs4SwtnoeoChTkLQFHiotit4ppx082tU0Y 3v6Ayfwkz5LXDRgPBT46jfL9VqS0m1VQW8gLW2QtT7F4oPkXU1+2ikI9rV5I+wRl5cM0 2xS4nwQ8M2z90ROiJmJV1i3uIxw/6txav5Yi1AHqAKZpSIDGyDOEIOd4Qrn5nFsAb9Sq PwqUooYQMqVSd6mX1jrRFPG68S2TWg1a5cWdafj8SBQKQ9ZWvWD9ZNgj/Noir29/NCnt 3BcEHiT1ybddJI8o/nNSAUWMGSYznzFTr046S3biKRplFvljUXN9UBrCiyVSH23MjGUb 3R0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=zZ2ZehKQcdxMxJsx8EzMJxJT6Cwgp1fwgx/QiSFKeMo=; b=eGvSmsljgyu0mmT4PGryBRKcyNE7l+ZMxZjXz2pLrNnk7ogcNVzvC8UWbUiUdK6esP Acu/x/zqMIHReUPCdYTG1GftMjEGMQR2A1exrLeR1vvQZain3gBjW+jgmAStWz061DbS elY/nvAdUXEBqMmQzt6EQ3AzyConZza3ss21CNdX4JpMj7noorT460rUZTxNd+FGwzNz H9p49H6E1jYzqPecyRNNQfLKshfoQ+19aJrdc2I/qy+KsvId8JZFx4hc7qORmq6BuInn O5b0eYiRXv0XfuoHHoIrOb1YxUkprypHLnQ+r05dt8aejesMvP1kOjdiFgnDfqpZQFBv CV5Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qb31-20020a1709077e9f00b007adb3888ad9si3976369ejc.351.2022.11.25.05.07.08; Fri, 25 Nov 2022 05:07:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229958AbiKYLnr (ORCPT + 86 others); Fri, 25 Nov 2022 06:43:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229554AbiKYLnp (ORCPT ); Fri, 25 Nov 2022 06:43:45 -0500 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E12ADBE1D; Fri, 25 Nov 2022 03:43:44 -0800 (PST) Received: from canpemm500010.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4NJXzx4p5Hz15Mv1; Fri, 25 Nov 2022 19:43:09 +0800 (CST) Received: from localhost.localdomain (10.175.112.70) by canpemm500010.china.huawei.com (7.192.105.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 25 Nov 2022 19:43:42 +0800 From: Wang Yufen To: , , , CC: , , , , , Wang Yufen Subject: [PATCH 1/2] RDMA/hfi1: Fix error return code in parse_platform_config() Date: Fri, 25 Nov 2022 20:03:50 +0800 Message-ID: <1669377831-41386-1-git-send-email-wangyufen@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.112.70] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500010.china.huawei.com (7.192.105.118) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In the previous while loop, "ret" may be assigned zero. Therefore, "ret" needs to be assigned -EINVAL at the beginning of each loop. Fixes: 97167e813415 ("staging/rdma/hfi1: Tune for unknown channel if configuration file is absent") Signed-off-by: Wang Yufen --- drivers/infiniband/hw/hfi1/firmware.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/hw/hfi1/firmware.c b/drivers/infiniband/hw/hfi1/firmware.c index 1d77514..c179dfe 100644 --- a/drivers/infiniband/hw/hfi1/firmware.c +++ b/drivers/infiniband/hw/hfi1/firmware.c @@ -1788,6 +1788,7 @@ int parse_platform_config(struct hfi1_devdata *dd) * being used. */ while (ptr < (u32 *)(dd->platform_config.data + file_length)) { + ret = -EINVAL; header1 = *ptr; header2 = *(ptr + 1); if (header1 != ~header2) { -- 1.8.3.1