Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp10542960rwb; Fri, 25 Nov 2022 05:41:24 -0800 (PST) X-Google-Smtp-Source: AA0mqf4eAwGmxovAb/D5iiGh95h5jf3p3Ovst6UDNDARvo7iyUFbzN9IKKmtpJwGW8gLixiH4I9V X-Received: by 2002:a17:906:bcc1:b0:73d:715c:5730 with SMTP id lw1-20020a170906bcc100b0073d715c5730mr31643239ejb.293.1669383684103; Fri, 25 Nov 2022 05:41:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669383684; cv=none; d=google.com; s=arc-20160816; b=uzDiKYcn7499xEnRY+9mD4r5qwqI9JGMGDBAJYkRHwxqBCyz6JsbEf4jkjHQplJGl2 Zss0AjJYmWNW3i3fRZUq+zl04JHFLqJtnlyoVr4r2ytjMNso68B1basYkoXIQ4XwXyt4 yBI2X0QAZ4/gI0xcvl8NjPX9S0gOprUsPv1IAL81Bvstdhs4E70coRyRuQq6c6SIp4jC 18Mm70vK2uffMo2mwRA8FFGv3D3oxRE7WEuRax+Hrz7SWDEziSu8QPLgi24zQKMU/YXV 4sJR/w8BmMNV1w7DQ/b1FzuJX6j25eAQReGhlzdojbhH4iKgsF+T/g37uMhXXqmW+YG9 Nq7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0vN53Jicp2EQLGwxHenx0pNuudpw6RE4UZUcHo5SquA=; b=Zi0b1zyZH5TFk/x4GQxhrngDfv8T1IMpX9IPt2hw9Xvruah/KZxzDVwWDT9vO4DkqH DnWtGPEiEc6KdQBM3h/xlZotVGouOtSm0t5lTozZtHlben7+91TmtJiaspCWQGf6XpBv q0Bj3qlbBvWCdYxU8LLPiz1nwEQjLboQaFg6xPy45EGFs87ZmxM1Ttr4x45mVSc8Qy/8 IISMWNduxHXhjHwj/x7bbeYChNih+cs6lT7jITqbfYFI8JrBq31k4JsbabeY3suHyLlx VK0lwN0JMfgCaK8E9xhQAkyzSxo6vEB25np6qZ/zsyJ8JbBMGkD6C80VQLCkY1Y+gf19 G7BA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=FZdFGvNZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hz3-20020a1709072ce300b007ae72fcabb3si4055471ejc.838.2022.11.25.05.40.37; Fri, 25 Nov 2022 05:41:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=FZdFGvNZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229740AbiKYNSU (ORCPT + 86 others); Fri, 25 Nov 2022 08:18:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229706AbiKYNSO (ORCPT ); Fri, 25 Nov 2022 08:18:14 -0500 Received: from relay11.mail.gandi.net (relay11.mail.gandi.net [IPv6:2001:4b98:dc4:8::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF99732B8D; Fri, 25 Nov 2022 05:18:12 -0800 (PST) Received: (Authenticated sender: maxime.chevallier@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id AC810100004; Fri, 25 Nov 2022 13:18:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1669382291; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0vN53Jicp2EQLGwxHenx0pNuudpw6RE4UZUcHo5SquA=; b=FZdFGvNZ+6wfMb4AaDqlr+5u/y02N0LfnuwXdaIOqZbpRmii5u/VTHguLkaR2klLjp06Za FT4x8kZTrcAkyyMcyE+jtQpMdch88/iLNOmAB9rUeR/DfnEDb6CkJmzXUULesE7wKU5It4 /WDvLmsF5guHQNjIh7daVXMXkpqrEFvVEVjohe7jlyE+eHpEvyCPRSZBH1qXzPdotJDLSX 8ZsMn4Fke+SZE0Cu+v+7H5+mwALAxhvUym2Vg7ZGOvCmnN9fkZ7FRkEPULzMo+IG/jDJs9 gwDwdJ/1bKwA+DDQDBmNaqFuc3hg3UOQJTGyVkkGP3mMDfEln3y8pYWrLAkn3Q== From: Maxime Chevallier To: davem@davemloft.net, Rob Herring Cc: Maxime Chevallier , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Florian Fainelli , Heiner Kallweit , Russell King , linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , devicetree@vger.kernel.org Subject: [PATCH net-next 2/3] net: pcs: altera-tse: don't set the speed for 1000BaseX Date: Fri, 25 Nov 2022 14:18:00 +0100 Message-Id: <20221125131801.64234-3-maxime.chevallier@bootlin.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221125131801.64234-1-maxime.chevallier@bootlin.com> References: <20221125131801.64234-1-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When disabling the SGMII mode bit, the PCS defaults to 1000BaseX mode. In that mode, we don't need to set the speed since it's always 1000Mbps. Signed-off-by: Maxime Chevallier --- drivers/net/pcs/pcs-altera-tse.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/pcs/pcs-altera-tse.c b/drivers/net/pcs/pcs-altera-tse.c index e86cadc391e8..be65271ff5de 100644 --- a/drivers/net/pcs/pcs-altera-tse.c +++ b/drivers/net/pcs/pcs-altera-tse.c @@ -102,7 +102,6 @@ static int alt_tse_pcs_config(struct phylink_pcs *pcs, unsigned int mode, if_mode |= PCS_IF_MODE_USE_SGMII_AN | PCS_IF_MODE_SGMII_ENA; } else if (interface == PHY_INTERFACE_MODE_1000BASEX) { if_mode &= ~(PCS_IF_MODE_USE_SGMII_AN | PCS_IF_MODE_SGMII_ENA); - if_mode |= PCS_IF_MODE_SGMI_SPEED_1000; } ctrl |= (BMCR_SPEED1000 | BMCR_FULLDPLX | BMCR_ANENABLE); -- 2.38.1