Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 25 Nov 2022 14:32:47 +0100
From:   Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To:     Akihiko Odaki <akihiko.odaki@daynix.com>
CC:     <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
        <intel-wired-lan@lists.osuosl.org>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "Yan Vugenfirer" <yan@daynix.com>,
        Yuri Benditovich <yuri.benditovich@daynix.com>
Subject: Re: [PATCH net v4] igb: Allocate MSI-X vector when testing
Message-ID: <Y4DD/5BtgD3TjdW2@boxer>
References: <20221125133031.46845-1-akihiko.odaki@daynix.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221125133031.46845-1-akihiko.odaki@daynix.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sA61TY3AdwOz8a12LhsLsrtWA2dkpAbM7PQ9XW4HdapvnSifkIx5GxpcQsBa?=
 =?us-ascii?Q?snoyJdBn+pZfs8j7GPafIlAOgoBzjqvQDzZfbSf2Hq4KKhxJblDaLz8mogAG?=
 =?us-ascii?Q?hXTfK/SZNwK8kfUlhkSIjpu8pqjMkTVPYfc5TnPk7YoCw57L/Ur+YBbGIuSu?=
 =?us-ascii?Q?Lfz564Tk44Dl0rxeEQdYGVlaxEA+CZdDGtdWOaT05d6P/PyV13UeJzw7iC+i?=
 =?us-ascii?Q?eFJb/ymf5iJjZl60qT4gK+3s+Ce90MGl18kgw6pT7cZolM76AVyvwKksUBTA?=
 =?us-ascii?Q?dBByn5soncMHEBFp8qVSAdKZYOjtt2x5HFLFVhcVDqsbfl0aGHQtpAukAhP7?=
 =?us-ascii?Q?Spq9jm3E2q3u8BuFuQUUU4ZCUHv++uqL4lKBL+wzHXz48DrXNoHjEfq2Fihl?=
 =?us-ascii?Q?uK/fXGBToxER/1atBM7stj789OAzDtkP2YxoidOQyQir5/10SlKJhE3DGSLk?=
 =?us-ascii?Q?vOfZ98rYhgSXgNGM1bqSEWqS9g/o15ONdUU+BXaShwbu9eWwnrTLvq5K2CjW?=
 =?us-ascii?Q?Xzh3mUrOa30/TgIqTNp0ymrs72LmI/+FXokQ5ipJ96m6SkHW7km8cVWtDgT/?=
 =?us-ascii?Q?Lna5grSI4k3iVpZcXWIsCIGYiDkn56qDC4qjQ5jBQCcvHgW2j02wFQbohvg8?=
 =?us-ascii?Q?1/ENSHKrTGrxRKoJVcbdAlXZ5xJr2ST+omLIbl3+M2r2ECkDP9n16Mtq4Sx9?=
 =?us-ascii?Q?pDJbMe2rS0FJ777iSuKH3KCBX9m1e6r/GAP/zb5qupEv1noKzr4+u88WoT59?=
 =?us-ascii?Q?pKnqgaxI7CK1at9ISkBtGqyU8VGKhv2kDYKMYM+ytCYYTIWv/5oLNI2sC+fV?=
 =?us-ascii?Q?V8KcwB0Npea0dk5Ga2bx24y+ap8gE7ypx5ilpFewDw7nVMEW5/P15MABtk0q?=
 =?us-ascii?Q?cB5FiXVSGi1k9uQAnXjCkQV0bGKWPAW88j61SxwNM+FW7NiRcE83QMHbyQTm?=
 =?us-ascii?Q?nYLL88fXJYCgRjmAxrhlWRCYhyItPaNlX14W2hzHBm+wkvFA7FBjY+XxlxX6?=
 =?us-ascii?Q?mIq1bW3maYYCR9DY4SVt3DSRpdtpblb5uOfTG3dtoV18DNRODaK434djNNtj?=
 =?us-ascii?Q?r5xrsWlK5u8KjAqVhraO7TvhuoMdHWoV5h7XCWIcOM66F2yuyCzoOykA2VNR?=
 =?us-ascii?Q?9NkDUbxz9k85t3H1TIOAddUMcSpL7RnApkRtIQx+ldPiF34WWNRb9K0h6tOq?=
 =?us-ascii?Q?0o69T927Lp5M6jkER3ANoJOrudf7QKMxNQt//NiCp8+gpLjh3rJSNy2Xd2NS?=
 =?us-ascii?Q?pGdBMfQgeOaMM8RT2IJvI11w3ooF15VcPb28Cd+ucqRQpOAhaaDy7ViiFJsO?=
 =?us-ascii?Q?Zjy1r/TwHnURLSOi8OEXor/zOPbeOH1OB3OkmuNHPaqX6y3ecCeYUJyZ6upJ?=
 =?us-ascii?Q?YVw2v8pUc90PQEvOS/p5QWFfRB1y1D+bq1935NjQ/3tD3AjxYX1ZqSVy8QLA?=
 =?us-ascii?Q?zaCpWQimv/yzjKzyHK9XczklFGJsgu8PnI3KoHgW/O8cPfdbUFymDG2BFsj4?=
 =?us-ascii?Q?x4bFf8LYbFVnJGNV1pl5CBRqQ5VDHHG6AZzqeX0rWMCRLejI3WFwbhlIgGGn?=
 =?us-ascii?Q?zIVtWXpiu/x6NJ1OcGMaa1EydAakJqtzZr92uZGX9+W9a8Q2vnRLy4+RaS7h?=
 =?us-ascii?Q?FQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f990c1b-8e3a-4d90-5bde-08dacee98f67
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6117.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2022 13:32:55.6213
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: A3DLbkxAGP4Esk2L7Em72AsFO/+LV6jRT1Wj0Nl8EIN+UclFygnuwi0b5eQlbIkbhKN2T6Y3uCORA2cCdJLJvp1094BOKeHkBlMCO8ZuUYo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5154
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Nov 25, 2022 at 10:30:31PM +0900, Akihiko Odaki wrote:
> Without this change, the interrupt test fail with MSI-X environment:
> 
> $ sudo ethtool -t enp0s2 offline
> [   43.921783] igb 0000:00:02.0: offline testing starting
> [   44.855824] igb 0000:00:02.0 enp0s2: igb: enp0s2 NIC Link is Down
> [   44.961249] igb 0000:00:02.0 enp0s2: igb: enp0s2 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: RX/TX
> [   51.272202] igb 0000:00:02.0: testing shared interrupt
> [   56.996975] igb 0000:00:02.0 enp0s2: igb: enp0s2 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: RX/TX
> The test result is FAIL
> The test extra info:
> Register test  (offline)	 0
> Eeprom test    (offline)	 0
> Interrupt test (offline)	 4
> Loopback test  (offline)	 0
> Link test   (on/offline)	 0
> 
> Here, "4" means an expected interrupt was not delivered.
> 
> To fix this, route IRQs correctly to the first MSI-X vector by setting
> IVAR_MISC. Also, set bit 0 of EIMS so that the vector will not be
> masked. The interrupt test now runs properly with this change:
> 
> $ sudo ethtool -t enp0s2 offline
> [   42.762985] igb 0000:00:02.0: offline testing starting
> [   50.141967] igb 0000:00:02.0: testing shared interrupt
> [   56.163957] igb 0000:00:02.0 enp0s2: igb: enp0s2 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: RX/TX
> The test result is PASS
> The test extra info:
> Register test  (offline)	 0
> Eeprom test    (offline)	 0
> Interrupt test (offline)	 0
> Loopback test  (offline)	 0
> Link test   (on/offline)	 0
> 
> Fixes: 4eefa8f01314 ("igb: add single vector msi-x testing to interrupt test")
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>

Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>

> ---
> V3 -> V4: Added Fixes: tag
> 
>  drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c
> index e5f3e7680dc6..ff911af16a4b 100644
> --- a/drivers/net/ethernet/intel/igb/igb_ethtool.c
> +++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c
> @@ -1413,6 +1413,8 @@ static int igb_intr_test(struct igb_adapter *adapter, u64 *data)
>  			*data = 1;
>  			return -1;
>  		}
> +		wr32(E1000_IVAR_MISC, E1000_IVAR_VALID << 8);
> +		wr32(E1000_EIMS, BIT(0));
>  	} else if (adapter->flags & IGB_FLAG_HAS_MSI) {
>  		shared_int = false;
>  		if (request_irq(irq,
> -- 
> 2.38.1
>