Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 25 Nov 2022 20:18:26 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
        "Jason A. Donenfeld" <Jason@zx2c4.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/tls: Fix tls selftests dependency to correct
 algorithm
Message-ID: <Y4DAosu+ahAWpqrr@debian.me>
References: <20221125121905.88292-1-tianjia.zhang@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="FFvArqS5lY3fuL30"
Content-Disposition: inline
In-Reply-To: <20221125121905.88292-1-tianjia.zhang@linux.alibaba.com>
Precedence: bulk


--FFvArqS5lY3fuL30
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Nov 25, 2022 at 08:19:05PM +0800, Tianjia Zhang wrote:
> Commit d2825fa9365d ("crypto: sm3,sm4 - move into crypto directory") moves
> the SM3 and SM4 stand-alone library and the algorithm implementation for
> the Crypto API into the same directory, and the corresponding relationship
> of Kconfig is modified, CONFIG_CRYPTO_SM3/4 corresponds to the stand-alone
> library of SM3/4, and CONFIG_CRYPTO_SM3/4_GENERIC corresponds to the
> algorithm implementation for the Crypto API. Therefore, it is necessary
> for this module to depend on the correct algorithm.
>=20

I feel a rather confused. What about below?

```
Commit <commit> moves SM3 and SM4 algorithm implementations from
stand-alone library to crypto API. The corresponding configuration
options for the API version (generic) are CONFIG_CRYPTO_SM3_GENERIC and
CONFIG_CRYPTO_SM4_GENERIC, respectively.

Replace option selected in selftests configuration from the library version
to the API version.
```

> Fixes: d2825fa9365d ("crypto: sm3,sm4 - move into crypto directory")
> Cc: Jason A. Donenfeld <Jason@zx2c4.com>
> Cc: stable@vger.kernel.org # v5.19+
> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
> ---
>  tools/testing/selftests/net/config | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests=
/net/config
> index ead7963b9bf0..bd89198cd817 100644
> --- a/tools/testing/selftests/net/config
> +++ b/tools/testing/selftests/net/config
> @@ -43,5 +43,5 @@ CONFIG_NET_ACT_TUNNEL_KEY=3Dm
>  CONFIG_NET_ACT_MIRRED=3Dm
>  CONFIG_BAREUDP=3Dm
>  CONFIG_IPV6_IOAM6_LWTUNNEL=3Dy
> -CONFIG_CRYPTO_SM4=3Dy
> +CONFIG_CRYPTO_SM4_GENERIC=3Dy
>  CONFIG_AMT=3Dm

You mean the correct algo option is CONFIG_CRYPTO_SM4_GENERIC, right?

--=20
An old man doll... just what I always wanted! - Clara

--FFvArqS5lY3fuL30
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCY4DAmgAKCRD2uYlJVVFO
o7jsAPwJXlW94Bdpkl3DdQ06mf2SmEZpwOw/nm18Cb/VgMiGVgEA3jMOxgyJv+n1
AUocNbw9UZDY4GEUxCAwW20s9MSiZgo=
=qUZX
-----END PGP SIGNATURE-----

--FFvArqS5lY3fuL30--