Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221125092601.3703-1-abelova@astralinux.ru>
In-Reply-To: <20221125092601.3703-1-abelova@astralinux.ru>
From:   Jonas Gorski <jonas.gorski@gmail.com>
Date:   Fri, 25 Nov 2022 15:14:50 +0100
Message-ID: <CAOiHx=nc46Hj4wDGC0ci8+SrAkJZ9i_7-yZU1D8cWkpS6prGoQ@mail.gmail.com>
Subject: Re: [PATCH] MIPS: BCM63xx: Add check for NULL for clk in clk_enable
To:     Anastasia Belova <abelova@astralinux.ru>
Cc:     Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Maxime Bizon <mbizon@freebox.fr>,
        Ralf Baechle <ralf@linux-mips.org>, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, 25 Nov 2022 at 10:28, Anastasia Belova <abelova@astralinux.ru> wrote:
>
> Check clk for NULL before calling clk_enable_unlocked where clk
> is dereferenced. There is such check in other implementations
> of clk_enable.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> Fixes: e7300d04bd08 ("MIPS: BCM63xx: Add support for the Broadcom BCM63xx family of SOCs.")
> Signed-off-by: Anastasia Belova <abelova@astralinux.ru>
> ---
>  arch/mips/bcm63xx/clk.c | 3 +++
>  1 file changed, 3 insertions(+)

Makes sense, especially since clk_disable() already has a NULL check
(in case anybody else wonders).

Reviewed-by: Jonas Gorski <jonas.gorski@gmail.com>