Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 25 Nov 2022 15:58:34 +0100
From:   Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To:     Suman Ghosh <sumang@marvell.com>
CC:     <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <sgoutham@marvell.com>, <sbhatta@marvell.com>,
        <jerinj@marvell.com>, <gakula@marvell.com>, <hkelam@marvell.com>,
        <lcherian@marvell.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [net PATCH V2] octeontx2-pf: Fix pfc_alloc_status array overflow
Message-ID: <Y4DYGjdcOzRryTLn@boxer>
References: <20221123105938.2824933-1-sumang@marvell.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221123105938.2824933-1-sumang@marvell.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UxJsO4g2/6sVoYgngUc/cOy6Cw4MSQUyUcz/o3QQgeUoEcjHfPgu/U3I3n4p?=
 =?us-ascii?Q?d09sKomducFQRg+perYpSkdbmRD93NIUsS0NwNz5kS9636QLnhUPv15pGtQo?=
 =?us-ascii?Q?+wk/opJ4HX01qSROSTvL0dKx9Y+FDhqqLwfRcuSrR89ym2/+kMuNf0Bo44mD?=
 =?us-ascii?Q?ccyAU5oy+iRGj1ptH3NZ/M29BWka4U47TN/rsKNUSxJob6PkgAxdT3Hqj1nA?=
 =?us-ascii?Q?epSqMPslun19khcCIqCECEhnCMEPi24dasmHkSYrSqE3p6+dDnZw05tNo7i7?=
 =?us-ascii?Q?DXJRSllBbuhHqVQPwFdVuhDljdlLJcIYOpSzwM6T7qxCPxmtlrho1i7f6Eep?=
 =?us-ascii?Q?eSy1hCVHsA5b6LsxSj1ZQtK4OL/luq8dCzNfc8jGl1RYRkpNLGz8LOPb+8Ga?=
 =?us-ascii?Q?q2+755Ro/M5V33ILcwsY8ns1wgLsAy4q58CtLhuvZMGvHKJte99VkKEUf38G?=
 =?us-ascii?Q?j+BM2XpDgddK+Se7x1dgbixYgWZTUmoj2ZmVAWh6+aqSQW3Uiic5sl99+9Xe?=
 =?us-ascii?Q?EVS7QVps2Z0t+OF5BGLC9t9C6GBJAWQLZqRbDHjWAI5SxilBe+zLoJ1HgZaa?=
 =?us-ascii?Q?EYp5HcxSnLEgZKqkqQ5gLMepp56PZ0WzI7ylTGmgwCSQFkkWL+v47JsDgawm?=
 =?us-ascii?Q?co6KrJRo9oUPClld5kCRnnkGyrCX3gTvW0zJjx+rQEFECaSvU3cZ6UgYA5fr?=
 =?us-ascii?Q?mqUumuEIGorN23n1GEnM+mpS2oB5GXgDqy5lHYNV8/xjONMOxkyxYZjNM2zt?=
 =?us-ascii?Q?G6QWzdNcIYPVL3E8GAsLktdwftR89lQ5VAX/x4pVyC/dd4WgxFDHNGBpmXra?=
 =?us-ascii?Q?VlZa4SVmZYfwcyIVcoqSq+vqFlaFvczepwzF8LiLo3qfnmEEiAfA95WKBV/t?=
 =?us-ascii?Q?Eh8mBik5IbspuT86E9oIuZAafk0xMRHcs5ngPEIjEcDztkEvh8QG5Z+8eTpD?=
 =?us-ascii?Q?mPst/xp3QfU3vYJ1gZ49oJVo45zh7FGKHD9KohPRljl1s9RyjmRUMm/rESBG?=
 =?us-ascii?Q?17TRH0XTsDCmB2Xw7ba2/ZJ0FSp85VKFlu2zO4+zl3XIcIxbDgYAARhVv2pf?=
 =?us-ascii?Q?YAI5jn1VK6DRAhjg4BiQ52Uh7buC/+lDZ6m4mtdWLJAlcUDOhjVPnXQbS+MY?=
 =?us-ascii?Q?9F9mAJxay+7ZO3jjaA+t/SSsPpEIbtVSFF3MFL5HI2fc9l4JFVP129fdwEdb?=
 =?us-ascii?Q?dullkCepk4wx97So4hXNzb5crKQNIOhV3q1OiOCDIxn8+5qYfJ+/yEewhFvy?=
 =?us-ascii?Q?QY34mtkUM50LFkR0D4ys4S+AGeJzKdsF1d+xQ+Tas8J9IyLZcnO8SITg0t1x?=
 =?us-ascii?Q?lKRqz8N+ZJJR/4T7JpYDB9IECL/GLvvGRNicYnK75V0PxEFcRHpH6vruMkCZ?=
 =?us-ascii?Q?WQ1KYZxNsmMICVZ3I+rxtN70a5NQFU+lz9X4YjVQhkG7nKtVv/mbKfjPDti5?=
 =?us-ascii?Q?iZmo1s+5MmRFM+Svlz44l1507MWKLOIJDj1lZ44RsjHq4sYE0zl/8Wlrqd4i?=
 =?us-ascii?Q?XU8s2+vsbXVOnyhBcSC3zH67zpX+18bnVSmKbzhbrQLzNN/BgwKv0Bop4bsp?=
 =?us-ascii?Q?0APrNKdmgDaIobcg1YLcwlBmrwGck1Kd37m+74QQUWzf+RMbP5GJiLLJTLtI?=
 =?us-ascii?Q?OQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 857da77c-d593-4e9c-642a-08dacef58e06
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6117.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2022 14:58:47.2845
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rAzTkyT+DQ+tyd3uuxu7TTEJSW2GdcaLvYavHSk7mj8Wn6MwCvX+HSZKTkhvUfvNyf+OfldHd3cf5Mc1kNR/bDv6WwS91MbbNZFxqzD4E34=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4585
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 23, 2022 at 04:29:38PM +0530, Suman Ghosh wrote:
> This patch addresses pfc_alloc_status array overflow occurring for

Nit: use imperative mood

> send queue index value greater than PFC priority. Queue index can be
> greater than supported PFC priority for multiple scenarios (e.g. QoS,
> during non zero SMQ allocation for a PF/VF).
> In those scenarios the API should return default tx scheduler '0'.
> This is causing mbox errors as otx2_get_smq_idx returing invalid smq value.
> 
> Fixes: 99c969a83d82 ("octeontx2-pf: Add egress PFC support")
> Signed-off-by: Suman Ghosh <sumang@marvell.com>
> ---
> Changes since v1:
> - Updated commit message.
> 
>  drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>

> 
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
> index 282db6fe3b08..67aa02bb2b85 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h
> @@ -884,7 +884,7 @@ static inline void otx2_dma_unmap_page(struct otx2_nic *pfvf,
>  static inline u16 otx2_get_smq_idx(struct otx2_nic *pfvf, u16 qidx)
>  {
>  #ifdef CONFIG_DCB
> -	if (pfvf->pfc_alloc_status[qidx])
> +	if (qidx < NIX_PF_PFC_PRIO_MAX && pfvf->pfc_alloc_status[qidx])
>  		return pfvf->pfc_schq_list[NIX_TXSCH_LVL_SMQ][qidx];
>  #endif
>  
> -- 
> 2.25.1
>