Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 25 Nov 2022 16:56:51 +0100
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Frank Jungclaus <frank.jungclaus@esd.eu>
Cc:     linux-can@vger.kernel.org, Wolfgang Grandegger <wg@grandegger.com>,
        Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
        Stefan =?utf-8?B?TcOkdGpl?= <stefan.maetje@esd.eu>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND 1/1] can: esd_usb: Allow REC and TEC to return to
 zero
Message-ID: <20221125155651.ilwfs64mtzcn2zvi@pengutronix.de>
References: <20221124203806.3034897-1-frank.jungclaus@esd.eu>
 <20221124203806.3034897-2-frank.jungclaus@esd.eu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="33cwzs42srezyfdd"
Content-Disposition: inline
In-Reply-To: <20221124203806.3034897-2-frank.jungclaus@esd.eu>
Precedence: bulk


--33cwzs42srezyfdd
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 24.11.2022 21:38:06, Frank Jungclaus wrote:
> We don't get any further EVENT from an esd CAN USB device for changes
> on REC or TEC while those counters converge to 0 (with ecc =3D=3D 0).
> So when handling the "Back to Error Active"-event force
> txerr =3D rxerr =3D 0, otherwise the berr-counters might stay on
> values like 95 forever ...
>=20
> Also, to make life easier during the ongoing development a
> netdev_dbg() has been introduced to allow dumping error events send by
> an esd CAN USB device.
>=20
> Signed-off-by: Frank Jungclaus <frank.jungclaus@esd.eu>

Please add a Fixes tag.

https://elixir.bootlin.com/linux/v6.0/source/Documentation/process/handling=
-regressions.rst#L107

> ---
>  drivers/net/can/usb/esd_usb.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/can/usb/esd_usb.c b/drivers/net/can/usb/esd_usb.c
> index 1bcfad11b1e4..da24c649aadd 100644
> --- a/drivers/net/can/usb/esd_usb.c
> +++ b/drivers/net/can/usb/esd_usb.c
> @@ -230,10 +230,14 @@ static void esd_usb_rx_event(struct esd_usb_net_pri=
v *priv,
> =20
>  	if (id =3D=3D ESD_EV_CAN_ERROR_EXT) {
>  		u8 state =3D msg->msg.rx.data[0];
> -		u8 ecc =3D msg->msg.rx.data[1];
> +		u8 ecc   =3D msg->msg.rx.data[1];

unrelated, please remove.

>  		u8 rxerr =3D msg->msg.rx.data[2];
>  		u8 txerr =3D msg->msg.rx.data[3];
> =20
> +		netdev_dbg(priv->netdev,
> +			   "CAN_ERR_EV_EXT: dlc=3D%#02x state=3D%02x ecc=3D%02x rec=3D%02x te=
c=3D%02x\n",
> +			   msg->msg.rx.dlc, state, ecc, rxerr, txerr);
> +
>  		skb =3D alloc_can_err_skb(priv->netdev, &cf);
>  		if (skb =3D=3D NULL) {
>  			stats->rx_dropped++;
> @@ -260,6 +264,8 @@ static void esd_usb_rx_event(struct esd_usb_net_priv =
*priv,
>  				break;
>  			default:
>  				priv->can.state =3D CAN_STATE_ERROR_ACTIVE;
> +				txerr =3D 0;
> +				rxerr =3D 0;
>  				break;
>  			}
>  		} else {

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--33cwzs42srezyfdd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmOA5cAACgkQrX5LkNig
010adAf+JqrrWFgc6phKSI+7QqpLsN9JB9bQCPb4OjM0XSmjgo3CC3Oga+K0G/Uw
dNzFtDVX98O1Z49SOPQKIh5Bo5e25POxaFJlGpWTWzoXsZUZqSX+0jZJ4KBeuhLQ
AkjbwB+Ddb8xlj0yC18WvfHlMnIIxnR1okCeGxtr779XP3okg9W0BbK2jC/GIzlN
HynmYfjCOTGfHBroUUB4HETnh5zzXqZtPrJt150U4IwuN3e63NfWeFyQcYapL5L8
0W1sYADZ8mDVE8zYgcxNNLITZj0rlK8IKSYtvKUo4kE/ROZRDrLeaajYg9oxhXRS
VYj5lAYHJbK0tXLxZeQP4pXG42HRIA==
=rXgd
-----END PGP SIGNATURE-----

--33cwzs42srezyfdd--