Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Tharunkumar.Pasumarthi@microchip.com>
To:     <andriy.shevchenko@linux.intel.com>,
        <Kumaravel.Thiagarajan@microchip.com>
CC:     <linux-kernel@vger.kernel.org>, <linux-serial@vger.kernel.org>,
        <gregkh@linuxfoundation.org>, <jirislaby@kernel.org>,
        <ilpo.jarvinen@linux.intel.com>, <macro@orcam.me.uk>,
        <jay.dolan@accesio.com>, <cang1@live.co.uk>,
        <u.kleine-koenig@pengutronix.de>, <wander@redhat.com>,
        <etremblay@distech-controls.com>, <jk@ozlabs.org>,
        <biju.das.jz@bp.renesas.com>, <geert+renesas@glider.be>,
        <phil.edworthy@renesas.com>, <lukas@wunner.de>,
        <UNGLinuxDriver@microchip.com>, <colin.i.king@gmail.com>
Subject: RE: [PATCH v5 tty-next 1/4] 8250: microchip: pci1xxxx: Add driver for
 quad-uart support.
Thread-Topic: [PATCH v5 tty-next 1/4] 8250: microchip: pci1xxxx: Add driver
 for quad-uart support.
Thread-Index: AQHY+kGw646UxkiGXUmyIL2ickY+t65Cx7aAgA0MWhA=
Date:   Fri, 25 Nov 2022 15:45:01 +0000
Message-ID: <PH7PR11MB595813B2AB661CD50517DEB89B0E9@PH7PR11MB5958.namprd11.prod.outlook.com>
References: <20221117050126.2966714-1-kumaravel.thiagarajan@microchip.com>
 <20221117050126.2966714-2-kumaravel.thiagarajan@microchip.com>
 <Y3Xv6XOwddNq6Gmr@smile.fi.intel.com>
In-Reply-To: <Y3Xv6XOwddNq6Gmr@smile.fi.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?d1wtU75B9NgRnr/9bGa03bEEMa2AauanYX9TcK4POFHrRVuQj8nrnDyIYuUT?=
 =?us-ascii?Q?+BSeOOK+9OJ//b927vS+nuaRi/3Z/vkA52TLT8Mcugr8g9OK0MwN6gPPKAGH?=
 =?us-ascii?Q?Twwx5z0xHpZa3O68UsMwWO6vCLgqcLYLt/wYluSWLTfW91vNNw9Z4R/MlCoA?=
 =?us-ascii?Q?ES2hmcmKOqYHrwKfGrgkaAyeeWebyDELDb4AeE42v4u6c/FPQ/IrIsjZj6MR?=
 =?us-ascii?Q?CgzC+6+a+3eTyu8lYBeZBbOdze9gzhYFcRNt54GrXHfnmGBlSXBunmcgNshQ?=
 =?us-ascii?Q?Z5foaKajviJDATjZ75uFCKINiJr6BpQ4juUSLTKqWPdedtZ33TtYEDIfOkcV?=
 =?us-ascii?Q?xnYMgkbaLCEKhk9nsGDiMmRimun6fr3zyRORV8VFm9DDstBfh/qDMEJjVqGV?=
 =?us-ascii?Q?DzdUyTKhYdb85I/qZ7ix1I/ygJzvZKYz+JJVBL6nso1BOAvdpcoePz9AqLz3?=
 =?us-ascii?Q?xS+jvh+nbVRMp5/3Z5IAYpWaBeG/qWUVmhxzFU7lSqSgLr3fDvOG24Zo4KxX?=
 =?us-ascii?Q?Ufp5x+KwpKskh3IUm9VfcvYEmfV6EPV7kl23Gqgcr98OzWmYFLcSLWB2xGaN?=
 =?us-ascii?Q?LplrWj3CdmQrgzcqaV1eDT7pIRb091qDFS0wjepu+o8JyzXrQVu9d21uuyBc?=
 =?us-ascii?Q?Qbj006t3r5HMs73F6n2mE9RkfMnI5BHYVAb/kA4WjhqgbWzz99c97O6gBNAW?=
 =?us-ascii?Q?XYLZNndQPKqiwM0EzVfFpTWCVfH6PtfAzt/Umogkux2aG5OAg7D6KGMgYnII?=
 =?us-ascii?Q?vbc1lqgA9y8hPjhJfQdphNMwBaSs/cYdNZdyyZFMOxx4+1kqETxeQ7XVtOva?=
 =?us-ascii?Q?YMB3V6WJW+grRvBvsBQDPtaNgnXS1ZQ6iCCx/hz1Yvnkg91hNKvUIok26NTo?=
 =?us-ascii?Q?9QgjJVi7hcfhx0/y659ZlK4qBpSk81ER3H/gqy4hENaimAm/eMfucPXRrcpD?=
 =?us-ascii?Q?LcfLxXhXDf8IYxKtdthImzvM9xMYqV2E84OjxKOiq2LqKx7r8cwXORqdJGBM?=
 =?us-ascii?Q?ZErVpZzjN80wEBTySZAvZsJM4a62X67VcybE60KDS27tirSG5hxObd8GGSHe?=
 =?us-ascii?Q?p9Uu6Hln5fL2JGTPdzHNchoc0E7Z2GF5P9R+c/gyRzqMxFrLbE72ah/unrdn?=
 =?us-ascii?Q?f8l/31VGJ9UopGGVS8FNFaRL9ZM/bTJQvbkyKRBrJk/VwbFiO97/kn2F4Bk+?=
 =?us-ascii?Q?tWvuCTxrm0GHI4gwxLTeMK5JJz2jCgHUGQiGz5PCzkbKy+Vr5sSdF++84IpK?=
 =?us-ascii?Q?omu9KoqFYEqSOVTzoMdX98DX4t9Im8pcQX/guIOOAzztwQ43H3FHpJ6d14HI?=
 =?us-ascii?Q?JBBurHrx03v2/nB30FjpFqHbLh/6uuSiA00tGmxP0e4pcQskaGsVx87QmvQ4?=
 =?us-ascii?Q?bQgSUj+JQoLbaNfTIddoxxpULAGmwNoak4aoQqdiazDBKyWvZAYp6PKAsmpX?=
 =?us-ascii?Q?s22jkmjgBjVTRhlYxHmuLlBOJW6W2dQ8OG7HdhOUzfZPQjAVVrQd3VEstSfc?=
 =?us-ascii?Q?kvQcJiQHAnp5tESbmwL5fsayJ2cyEc+MBTYQAlDXC+o04D/yl4eCcEiThvhJ?=
 =?us-ascii?Q?Dgvo1pUNEoerMpMV96//JP3zChr8H63C64TqY6XPJmnxrKcCDktaqpGKUT5M?=
 =?us-ascii?Q?Uw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5958.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bad5a328-7054-4e96-5fcc-08dacefc03e9
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Nov 2022 15:45:01.8427
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: WubmPmdQOoQLJMkbTLB5Ar2hBExTE2WmYAQ/EHrVLVpB5cQqx9n4Li0f4dbZIwI2tJFmotoYoMpxCl3D5boksJ3YxksVYSydwDtkY/oX4XaKIOCtiBBJHI9xv69+0vfZ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5436
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Thursday, November 17, 2022 1:55 PM
> To: Kumaravel Thiagarajan - I21417
> <Kumaravel.Thiagarajan@microchip.com>
> Subject: Re: [PATCH v5 tty-next 1/4] 8250: microchip: pci1xxxx: Add drive=
r for
> quad-uart support.
>=20
> > +     case PCI_SUBDEVICE_ID_EFAR_PCI11414:
> > +             irq_idx =3D idx;
> > +             break;
>=20
> Try to make this entire switch-case more compact. It's possible.

Hi Andy,
I am planning to use look-up table for this in-order to avoid computation w=
ithin switch case. Does this approach sound good?

Thanks,
Tharun Kumar P