Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Alim Akhtar" <alim.akhtar@samsung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
        "'Sam Protsenko'" <semen.protsenko@linaro.org>
Cc:     "'Lee Jones'" <lee@kernel.org>,
        "'Rob Herring'" <robh+dt@kernel.org>,
        "'Krzysztof Kozlowski'" <krzysztof.kozlowski+dt@linaro.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-samsung-soc@vger.kernel.org>,
        "'Sriranjani P'" <sriranjani.p@samsung.com>,
        "'Chanho Park'" <chanho61.park@samsung.com>
In-Reply-To: <016293da-92b1-16e9-9a8d-ecab34c2f0c6@linaro.org>
Subject: RE: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add
 dedicated SYSREG compatibles to Exynos5433
Date:   Fri, 25 Nov 2022 22:10:40 +0530
Message-ID: <01a201d900ec$aaaf5740$000e05c0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Language: en-us
Thread-Index: AQIt87tfTwup8v8WQwS48SHvnyDBrAHgnMUHAkbd/d0Bcz2GTwF+lQpiAr6nA3gCgQusgK1DJvFw
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <20221125112201.240178-1-krzysztof.kozlowski@linaro.org>
        <20221125112201.240178-3-krzysztof.kozlowski@linaro.org>
        <CAPLW+4kwFCLaiowajdCnA09eT4emOB-3d-6cbA=ZYyRLwYuCxw@mail.gmail.com>
        <dfd956d5-d62d-52ac-c485-afc71c441df5@linaro.org>
        <CAPLW+4mWq5Q4Ht1Upx2Xw3fMfNvvSK6fEPbLFru1NLpKHLbKOg@mail.gmail.com>
        <CGME20221125150130epcas5p3ce8a3b75cf80ea9df35093db4d684eb2@epcas5p3.samsung.com>
        <016293da-92b1-16e9-9a8d-ecab34c2f0c6@linaro.org>
Precedence: bulk


>-----Original Message-----
>From: Krzysztof Kozlowski =5Bmailto:krzysztof.kozlowski=40linaro.org=5D
>Sent: Friday, November 25, 2022 8:31 PM
>To: Sam Protsenko <semen.protsenko=40linaro.org>
>Cc: Lee Jones <lee=40kernel.org>; Rob Herring <robh+dt=40kernel.org>;
>Krzysztof Kozlowski <krzysztof.kozlowski+dt=40linaro.org>; Alim Akhtar
><alim.akhtar=40samsung.com>; devicetree=40vger.kernel.org; linux-
>kernel=40vger.kernel.org; linux-arm-kernel=40lists.infradead.org; linux-
>samsung-soc=40vger.kernel.org; Sriranjani P <sriranjani.p=40samsung.com>;
>Chanho Park <chanho61.park=40samsung.com>
>Subject: Re: =5BPATCH 3/4=5D dt-bindings: soc: samsung: exynos-sysreg: add
>dedicated SYSREG compatibles to Exynos5433
>
>On 25/11/2022 15:57, Sam Protsenko wrote:
>> On Fri, 25 Nov 2022 at 08:47, Krzysztof Kozlowski
>> <krzysztof.kozlowski=40linaro.org> wrote:
>>>
>>> On 25/11/2022 15:22, Sam Protsenko wrote:
>>>> On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski
>>>> <krzysztof.kozlowski=40linaro.org> wrote:
>>>>>
>>>>> Exynos5433 has several different SYSREGs, so use dedicated
>>>>> compatibles for them.
>>>>>
>>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski=40linaro.org>
>>>>>
>>>>> ---
>>>>>
>>>>> Cc: Sriranjani P <sriranjani.p=40samsung.com>
>>>>> Cc: Chanho Park <chanho61.park=40samsung.com>
>>>>> Cc: Sam Protsenko <semen.protsenko=40linaro.org>
>>>>> ---
>>>>
>>>> Hi Krzysztof,
>>>>
>>>> Just curious: what is the rationale for adding those more specific
>>>> sysregs? AFAIR, e.g. in Exynos850, different SysReg instances have
>>>> pretty much the same register layout.
>>>>
>>>
>>> On Exynos5433 all these blocks have different registers. Are you
>>> saying that Exynos850 has four (or more) sysregs which are exactly the
>same?
>>> Same registers? Why would they duplicate it?
>>>
>>
>> Ah, no, you are right. Just checked it, they are different. Just first
>> couple of registers are similar between blocks, that's why I memorized
>> it wrong.
>>
>> So as I understand, adding those new compatibles follows =22describe HW,
>> not a driver=22 rule? Because AFAIU, right now it'll fallback to
>> =22syscon=22 compatible anyway.
>
>Yes, they describe hardware. Of course all of these sysregs are similar as=
 they
>are just bunch of SFR/MMIO-region, but they have different roles/features.
>For example some other devices (users) of syscon/sysreg should reference
>specific device, not any sysreg.
>
Yes, these are dedicated / extended SFR region to provide IP/Block specific=
 side-band signals / configurations.

>On several other architectures we use specific compatibles, so I think for
>Samsung we should do the same.
>
Yes, most of the SoC's sysreg are dedicated/included in the IP block itself=
 now a day, so make sense to have a dedicated compatible.

>Different case was for Exynos 3/4/5 where there was only one SYSREG.
>
AFAIR, this is correct.

>Best regards,
>Krzysztof