Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 25 Nov 2022 19:30:52 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Alexander Stein <alexander.stein@ew.tq-group.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] regmap: cache: downgrade log level for no cache
 defaults message
Message-ID: <Y4EX7DLt/Lvde/SJ@sirena.org.uk>
References: <20220921071054.3132504-1-alexander.stein@ew.tq-group.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="yp5XM8ipNl8d+MS7"
Content-Disposition: inline
In-Reply-To: <20220921071054.3132504-1-alexander.stein@ew.tq-group.com>
Precedence: bulk


--yp5XM8ipNl8d+MS7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Sep 21, 2022 at 09:10:54AM +0200, Alexander Stein wrote:

> Having no cache defaults is not a mistake, especially for devices
> which do have some kind of strapping values which can't be provided
> statically. For this case a warning is the wrong log level, the initial
> cache values do need to be read form hardware. Reduce level to info.

>  	if (!map->reg_defaults_raw) {
>  		bool cache_bypass = map->cache_bypass;
> -		dev_warn(map->dev, "No cache defaults, reading back from HW\n");
> +		dev_info(map->dev, "No cache defaults, reading back from HW\n");

This is a warning which is only generated in the case where we have a
non-sparse cache where we won't read from the hardware in the csae of
missing values and will instead just substitute zero as a default value.
It's warning that we might end up changing values for the device
unexpectedly in the case of a read/modify/write cycle that doesn't
actually check what the device currently has set.

In this case if you can't use a rbtree cache I would recommend
bootstrapping by initially reading without a cache first to get the
default values, then replacing the regmap with one that uses the
defaults you just read.  You'll need some care over suspend/resume
though.

--yp5XM8ipNl8d+MS7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmOBF+sACgkQJNaLcl1U
h9CK6Qf/ZjTUtwgqo+qDCVj8jMeBqAXGwcxD7fv7GCC4hf6NeeNQeATHZAfR/gJv
9FoQkYcJ6D/rQQdlwn9tcyEn4ulO/UAav4OWqSLAVi/D/iiW7NPURyiBwdovQVub
Kn0wH/byMDMGLilxr8haxi8GJKcEusVQj9DwWOqOPSC9kilP1m20VwDczdEk9M0d
6R9q2laPG6Ehmd2w/FljR9qZuZyJE98TfPkwrz/XQGmf1T6brDyA1/kNMokk0dt+
MPe66HGeCTH0n63W6IReKZ6AJrvdTlBXAz7uYkoRyz8dbSzUCKAJOOSyKbCeJJ6/
rgtCL4GO3GegcbjxDm2O4z03MwsgbA==
=UX2o
-----END PGP SIGNATURE-----

--yp5XM8ipNl8d+MS7--