Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Chanwoo Lee <cw9316.lee@samsung.com>
Cc:     alim.akhtar@samsung.com, avri.altman@wdc.com, bvanassche@acm.org,
        jejb@linux.ibm.com, martin.petersen@oracle.com, beanhuo@micron.com,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: ufs: core: Fix unnecessary operation for early
 return
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1v8n2r2ie.fsf@ca-mkp.ca.oracle.com>
References: <CGME20221111062328epcas1p2c2d1f52fed1068579a1dad7fb4e60f52@epcas1p2.samsung.com>
        <20221111062301.7423-1-cw9316.lee@samsung.com>
Date:   Fri, 25 Nov 2022 19:19:29 -0500
In-Reply-To: <20221111062301.7423-1-cw9316.lee@samsung.com> (Chanwoo Lee's
        message of "Fri, 11 Nov 2022 15:23:01 +0900")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Fm4fiLO//8HvN+4CRhoeFDst6xtva7sX/loMbMD97oQgQcHrpVQiuyW9h5aY?=
 =?us-ascii?Q?PebiOpR2yM3HO5/s74Id5xMzhTxPMIp90BSCFiqJOi5oOCQINw7hgk5Bah7d?=
 =?us-ascii?Q?BXDqtJ9zCAbokL5QBajmKWq0cDhIwPpd0+c7hy4gQ22YL7J2ukvuwgQF5KvL?=
 =?us-ascii?Q?RusE1gQyde3uaX7o65wxhQwhnLoot8DZlgckc3VN6YDIEgkndA5B9/JEmWW+?=
 =?us-ascii?Q?vLtPuJ+jYd5hikJI/XsQL5ndyRlQw9EG90Y2NfaS2QgINlOVSmk6CNaEk5Bf?=
 =?us-ascii?Q?i67jMnm486p57PfaGC78ZfrywPN0wfWmELggGbKHTEcFrM30xJKWlXL/+Tnf?=
 =?us-ascii?Q?yjG3QK/Y66wtyyix7E6DcSLKUAbsx/wtalIl8fch4tWFxSq3KM+EmwC64F9B?=
 =?us-ascii?Q?esDY/u3dZDf8nEatQa2eeMcYPoi97jxDwVSVAbUWPpkAOzMu7itM68r6N+bM?=
 =?us-ascii?Q?awxXtPJjSclIW7IQ5IpyUQJiLM+xMYSiQQZO5IiZAbfu0orFTPgW62oEssv7?=
 =?us-ascii?Q?Kgwkn4Hki0RnMmwqsaiFpe70PrikgonGnsLC+HjXsTHoeO+gM9Cj6Lx/uiw2?=
 =?us-ascii?Q?UNmGloo3pAEHUL8sspKg4yIXw21tEafTudI47ZZHZLaJK6p9O7/UmSGPbXno?=
 =?us-ascii?Q?iUPOiKdd5E3Qcco2J1t+ucmkqGr6XbpwxuownPe2yv0mP+f3c4gsOg+sT2na?=
 =?us-ascii?Q?RWA7HFNGVwZ9KmXBG39rNNFyc5O4Jer4Blu7loTd9N7CT4/vvTXIQT7Vl7ZB?=
 =?us-ascii?Q?EXazcENSidMJbBH8uOu0VsiX/e9DlBYVrzizlFsPv4ewWNhZUUTjmtdMXGDE?=
 =?us-ascii?Q?UGU5CpzvMoHk67LgLIo8jgcZSZBkcIGDkJIrXpOhO09guN+y7ktx8cBRJOER?=
 =?us-ascii?Q?Ex5ab7XFERcBLeS2d6Y1SQRxf4LAoVPMNDuxAExBMo9ckvnvVufeTIm27iUg?=
 =?us-ascii?Q?scAUW1hYmrQlZjLoLUctQA2jtYEzm13wxY/lXoMtsWt/CGy4JGmxkv0ggx/0?=
 =?us-ascii?Q?Fr/OqLVgxXNlOqci4gskQxahOY18QyVr8vr1FzA3ZtUmb75jYuWg9Vmh9oXe?=
 =?us-ascii?Q?uO3SbxCBu9/74gc2B5as2LHDNj/BU0pm6HvbkR0CPydQrjOp3preIsC/z5Ii?=
 =?us-ascii?Q?8BZ7pS6p7tThYXDpZoPlzxo51RIJ6+W7itwRX1ZTpiFPOQf6b5CF5SzIFSKf?=
 =?us-ascii?Q?4LqzIZPElSB7P4EcMNnU3aPzPZFIPHWn1bhAQtL8yc5cRkIDhDKV2SG9bGh2?=
 =?us-ascii?Q?xHjvqbbj/vfQs3BkrePEghrc8aHyixeJsJdU74ozfVCuIHt/j/UmDq10BXZ4?=
 =?us-ascii?Q?WW59SEKFBMNdLt/F3h2AUuYRf3t6fO/zreLZ9S/1tIROR8NOmWVBkmvRC5TN?=
 =?us-ascii?Q?uO5+UyGdSE/I/zuEIhJp9SLNBtSD8gnVy3EtfazJcczL5YmcYGmWKadKs7Li?=
 =?us-ascii?Q?1ZnCnzNPgSAXZ8t469MDBKv7A0E8o11StLkRl3WDfjLUtRPPYo3/2QSvZgu1?=
 =?us-ascii?Q?iNEjEed0+lHWXB32RyIArnaoUq26UP/lWkR/9pZiOuCpSdddhExz8kCsxbsx?=
 =?us-ascii?Q?/npakeXepV+qPH4NT2HrdeKI5s/fFfZK7rAhPFvbvFwWlU6LuQ6noBb4heus?=
 =?us-ascii?Q?4g=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?ITK8KsTxW8MhIavaNkEqsxPpQU8mX1fj/hNzVdcbaBaRg7ajdxvSPA36i63l?=
 =?us-ascii?Q?60hsU/ekHCiD9KysPVZFOAIlDezlvV3iuCpmdM/F6aSifMWrsR2ngNWjqZMN?=
 =?us-ascii?Q?/pb92ulB/PZ1RAcbZQTRDwhDFoUlYiNYla7hG3jBFQyVilCt7CNUSV/qMaZ9?=
 =?us-ascii?Q?TM0fo8vzX7dvQC3Gv8JFsb7YKHZZz6G6ikmxp9kOm3kfBR4yVQfCKEG4fegc?=
 =?us-ascii?Q?hkjh8ShAgdl6ZsVABXo6WLxUsd3x+n4L3loCXdoSii0E1Yg+yxk+Y1vo3L/b?=
 =?us-ascii?Q?ve7Tz8blEXRhJzvDpsrDd71r2b7dvjdyOyUgsxyxzbpWCBbFwsJWBX30xRJa?=
 =?us-ascii?Q?5i3p/G5iusMa5d4bKnK3+q7dKiiWLei/AaI+Z64oNCX9fMC2jgbJ8xXZI1I0?=
 =?us-ascii?Q?b4hXwZoQhrqkytFsR8yLya+5OwkGzNvyO7ZOX93AOcoyuZ/AkpqU13BQe5HQ?=
 =?us-ascii?Q?t7vHtfZou0xsKwOcnAynkjSbNx2ipgFeunnOCcrIdDLIuPcpqaznGqkDWD8i?=
 =?us-ascii?Q?3+a5EbQw9G1Ub+KElxAWEpDGUNQFISM2mi0jP0RcX43YAf8HrkPL6a2acMpU?=
 =?us-ascii?Q?ERXANmz1Lz24TrurVJdClhGpIczrc2W6TWBqIN16VwllqcX1z1/sMjUDzsK2?=
 =?us-ascii?Q?v4pNx25jMw+wAM9GMtdTBuh2g0C2r3v7jGTo25T/weWdJnCYbQFKo61f3mfv?=
 =?us-ascii?Q?JupHzqr7fOOt7JIlSRZQzRw9bR1L17l2r+g4WkX0PAkHmofTCFttixrYiFp+?=
 =?us-ascii?Q?s/EM+vlkeMTELTL6IpbSLH61/hi4Sn4SI4z1/805BmTiqnK7h/iDGa0LK66T?=
 =?us-ascii?Q?SMU8SDZ4CvfA9M+aSsdbE2mMjvMY0zqc+hqZq/mrSIj+95JjuT/aG6XoQZR3?=
 =?us-ascii?Q?64c84QyppTwZlL7XldZyxiM9NiDcPmEf9YanudG/vNikqN+/o3ACFI6Q90rI?=
 =?us-ascii?Q?/Grr4eXe1DuoUyEtl9VV58vsJ8PFFk9Opt/+TW0kFPg=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 463731b2-7842-4bde-5801-08dacf43e643
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Nov 2022 00:19:36.0841
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rczYhfn5KQL1w+58bkginFTAUqh9AYqvPXay56sdk3wFlknJFn+i1zOrrvvQ3/FZnbevtxfTM07Hpoo1souu3IKSvKAknuBE5q1I2frZXWE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB6391
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-25_12,2022-11-25_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=867 spamscore=0
 adultscore=0 bulkscore=0 suspectscore=0 phishscore=0 malwarescore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2211260000
X-Proofpoint-ORIG-GUID: K-6VDi33kT1zfeSV_dk3-AJlVbq7EwXc
X-Proofpoint-GUID: K-6VDi33kT1zfeSV_dk3-AJlVbq7EwXc
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Chanwoo,

> For early return, bitmap_len operation is not required.  Modified to
> reduce unnecessary operations.

Applied to 6.2/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering