Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc:     error27@gmail.com, harshit.m.mogalapalli@gmail.com,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Hannes Reinecke <hare@suse.de>,
        Douglas Gilbert <dgilbert@interlog.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: scsi_debug: Fix a warning in resp_verify()
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1k03ir2hl.fsf@ca-mkp.ca.oracle.com>
References: <20221112070031.2121068-1-harshit.m.mogalapalli@oracle.com>
Date:   Fri, 25 Nov 2022 19:19:58 -0500
In-Reply-To: <20221112070031.2121068-1-harshit.m.mogalapalli@oracle.com>
        (Harshit Mogalapalli's message of "Fri, 11 Nov 2022 23:00:31 -0800")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uy5l5waj/8PR0+v39ktS+rtrRPQAoWHZZjTEHLMtFzijxiFyAD7bkU+VSTGK?=
 =?us-ascii?Q?i10w8ISS0WB1UkHbfr+/xtxo1ZEYF/jdGsEmEWRtAFPGR9Nyj+YLYSSl3yah?=
 =?us-ascii?Q?64xYJey88JxSA6gZzCPNSAl9T1kMaBgbLrlHi1xxwWwxvgnCTKsmbPL+FHAX?=
 =?us-ascii?Q?sx57UWlZje1h0l/6p4Jfhv3zOfo2Km2AmAxWepyYsGBsfKefhytbCEEpPeIK?=
 =?us-ascii?Q?lIZ2mCmDG2dQalifh8Ao52/P8PkTj9YB3UJQ6Lt9d+Z079S/1x1Pm8O+ah9P?=
 =?us-ascii?Q?0k8cFmc4NA3RZIaV5uZkvz39ht8FYL8ZaytS9IRQ9fGeW9GNgymxKdq1JET7?=
 =?us-ascii?Q?9OoOt0GwgctWqO+TG5zxwqGSKoGzhA4KfenJGZMiwlVLte8BsNAxRr3vUNKl?=
 =?us-ascii?Q?3wCUQ1XKpFDQOpAZO9JBesmeODQUFOLZeFZNeocj4ttHOrsmcSbsU7XHVN6X?=
 =?us-ascii?Q?ueB1cW7UG111jpB4LGNNpVtQAYXkwdPojlbEACmlrnhu8qqIpgKiRUsp1KGg?=
 =?us-ascii?Q?N8KSX+nX36IXW5KuN1pcbGZ1UNs6NzlUyoCHRGyqAY99evnS6PfJSDtJD6z5?=
 =?us-ascii?Q?A4I7v9FeDYTFDkHev713nLmNA927L+f5oDQlIrPq5XB6UxHBarUnV8MBJSQx?=
 =?us-ascii?Q?EuAk7X3Qqhn2HEmOn258SJn9GcIR7yxBiLCF9uc//WSUjcp5uEJ7k1/umDJE?=
 =?us-ascii?Q?vpUf5VEdyd9mwPAGGYYZ8MfAplD7cnGaraVC+H+K5Ebewuf8IaqQhRosN19v?=
 =?us-ascii?Q?cOedl/XOp8P+dPRyUGmYNwXYyXoAeSsfxDGtFZU1xrc4xMs9qWU+3NFomEc0?=
 =?us-ascii?Q?zG1+7gtXX+w7y+rH0fKTukhi2LxY5GJLtEOc4eswsZ6MmmAWwgYrDicOYufk?=
 =?us-ascii?Q?o3kb899DZcrmcr86RaVWvFNWubw85pq95gwKryAcrFQ21K7qvazx9dsvJpRG?=
 =?us-ascii?Q?CtmAwTA6+9tAjBQ3wT8SSPINUIIOrxkE0A2xDArwtZVC+bDbwjzT9LMYwrm5?=
 =?us-ascii?Q?m/hFSAh802nTi4y+UdyziJDaFtP2roBvLDY4udX4hLjiXMJ/IhdFTJHyEqTy?=
 =?us-ascii?Q?CARvNo0/Rhrn47BDGx1/vcFtWwBElLmcbl0xnTNsGcSORVQckXBlLlDKkWTW?=
 =?us-ascii?Q?fhL/eueNzvWfaDgPiV7n6uawi/CVoqd8N96Mey7KCoyi+jwHZC1mdrejh1CN?=
 =?us-ascii?Q?NrGS9wQtkIHPnb6zMc2sd0pKRIvjAkp3eg7dGYT+oSkA0xyiEDm6JSxafyv0?=
 =?us-ascii?Q?JpINiXfPtsLcb3hjpyXf7/G2oCEcFGz480/vqtZrW/PBCJSi4Kvgtzb+awL6?=
 =?us-ascii?Q?LwL2u6ymKLa4QgwogHKCsGPlNDP9lkTg95LJ5DW2CyoL0sY1wdqtuZjXnPcG?=
 =?us-ascii?Q?ZxJtKypG3kU49iHY2gEr1ptUsqhsi5O8K+s6bknAVFXY2L8nGg9xeGP2/4fg?=
 =?us-ascii?Q?JSv1oJ+/gnt3zkAISorEl225WaarA1OfLEjOzN+6ZQZgeyuzrsgfkktKLlhP?=
 =?us-ascii?Q?nEgkECQgHS78RuQJvpAedn+TC3DEw4n7N6hbz9YP2VTVa+ZDn9PtUyPd/hyV?=
 =?us-ascii?Q?97X7MaejzCdzYd42BUZ5ZLknoPBtSgpUEQxRKtM36/R/WMTF+HX6PtW5BI8S?=
 =?us-ascii?Q?yQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?2O4UjyKxYacS+bzpCJSoTsGxsE6+HIrahWmvyoVmlgbQod9YDECepEpQ6OQS?=
 =?us-ascii?Q?41RLqF9ZHLD+W6p1mtkl0LQ7aMGc519aQpPvAhFe9K80h5xhcuAj9nw8g7Ww?=
 =?us-ascii?Q?WAcIoqOnxhP/sv3dS5JG0P97D3NpLM3l6SQkTs9kC/4xTUxBY+J7d1zSzwDx?=
 =?us-ascii?Q?IHNp7b1H9XTTL4Mfk5qV6JtyxWzGt7JsF+jWkfYRX86C/NwCF3KSOHtovuf/?=
 =?us-ascii?Q?lNN407YhiCGh2vtIooe6upmYxdNbqqeJphlb1BUZfH+OVmJ4dW1mPXEycdUc?=
 =?us-ascii?Q?YHow5ZMQSOxw9MGbsA1phmHEfI8zpZPNoym2c4fn/IbTVORVoedNoTM1yrWv?=
 =?us-ascii?Q?dFYJXfSwJQwI+48nveWaEwEkxBE33451IAZmsnHJeJKWH4kAOgU0xCyI0/u4?=
 =?us-ascii?Q?uYLt2SC07WlOoZ2lITR4lSrypkr30KYUxzK97XZz8pGWkIMghRNkxCZT8rrr?=
 =?us-ascii?Q?WkRiD9+mXd4372QocLOQgh+DRznjLazrBylaOfjwGs3Zp9aZU9vT1Fgx3Pfu?=
 =?us-ascii?Q?hbEtpm/Y77ZInWdgyFFwgz1oVhpHUMYLv00SIiE40LF2Vjds4WkepX00mpC2?=
 =?us-ascii?Q?tDJdCHdd6uDB7DxSqe3Wl6iZ/wlJGOSh1eo+3RpV2bBeVHUAigIce2ue/Mcn?=
 =?us-ascii?Q?8ANUlBoFjtooc76Jx5ZaZ7E1JLNI7qcT4pWGncT7maVozfblpWz4ViQImsiF?=
 =?us-ascii?Q?mbiDjs7QoS5vmEHJjHOFWhUYSPN/MgIKAnvHXWw1qJHfiEliE46SnqFeEFoF?=
 =?us-ascii?Q?tfjA2FezX3zhtNXF03Al2mLNX9rAXBkY/pWTsgVu3XdSVQEc8EwiayIaS9rY?=
 =?us-ascii?Q?HFAwb+qjxUKcQL2vP7UR4VEVZdAYAqq0HnDgDPfRAybNYwBcJYnTXpCA9Auv?=
 =?us-ascii?Q?vic0saSBvbM8BOsXLp532JG91wxAnRsbxVHngSUttLVcPYK0Bj7DH9ceIHhp?=
 =?us-ascii?Q?+6wlOwxiaXYLr4VdeAoxWA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fb576280-9472-4ce7-8cdd-08dacf43f4ea
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Nov 2022 00:20:00.6691
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5XdYwBRyJtuzkq/h+FhFCn+FM5s0zz53US6+XBQOjsDMmTr+yzRAP7/IconYmkOP6vv/goEJiOyg+RaenjmiwFAVi8w9FkgZzYkFrhaRgJc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB6391
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-25_12,2022-11-25_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=761 phishscore=0
 suspectscore=0 bulkscore=0 mlxscore=0 spamscore=0 adultscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2211260000
X-Proofpoint-GUID: SchleKigY2Ng-SHDyiC9ObWPuXaNN7FD
X-Proofpoint-ORIG-GUID: SchleKigY2Ng-SHDyiC9ObWPuXaNN7FD
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Harshit,

> As 'vnum' is controlled by user, so if user tries to allocate memory
> larger than(>=) MAX_ORDER, then kcalloc() will fail, it creates a stack
> trace and messes up dmesg with a warning.

Applied to 6.2/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering