Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <acf780ec-11e4-bd1c-e931-c430f5e43edd@roeck-us.net>
Date:   Fri, 25 Nov 2022 16:34:43 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] watchdog: iTCO_wdt: Report firmware_version
Content-Language: en-US
To:     =?UTF-8?Q?Thomas_Wei=c3=9fschuh?= <linux@weissschuh.net>,
        Wim Van Sebroeck <wim@linux-watchdog.org>
Cc:     linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221125221240.2818-1-linux@weissschuh.net>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <20221125221240.2818-1-linux@weissschuh.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 11/25/22 14:12, Thomas Weißschuh wrote:
> Synchronize the reported information in dmesg and the watchdog APIs.
> 
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/watchdog/iTCO_wdt.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/watchdog/iTCO_wdt.c b/drivers/watchdog/iTCO_wdt.c
> index 34693f11385f..9b3c9f8b0b93 100644
> --- a/drivers/watchdog/iTCO_wdt.c
> +++ b/drivers/watchdog/iTCO_wdt.c
> @@ -437,11 +437,10 @@ static void iTCO_wdt_set_running(struct iTCO_wdt_private *p)
>    *	Kernel Interfaces
>    */
>   
> -static const struct watchdog_info ident = {
> +static struct watchdog_info ident = {
>   	.options =		WDIOF_SETTIMEOUT |
>   				WDIOF_KEEPALIVEPING |
>   				WDIOF_MAGICCLOSE,
> -	.firmware_version =	0,
>   	.identity =		DRV_NAME,
>   };
>   
> @@ -562,6 +561,7 @@ static int iTCO_wdt_probe(struct platform_device *pdev)
>   		break;
>   	}
>   
> +	ident.firmware_version = p->iTCO_version;
>   	p->wddev.info = &ident,
>   	p->wddev.ops = &iTCO_wdt_ops,
>   	p->wddev.bootstatus = 0;
> 
> base-commit: 0b1dcc2cf55ae6523c6fbd0d741b3ac28c9f4536