Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6b50524f-4f24-d14e-9d3f-f03f25ca549b@windriver.com>
Date:   Sat, 26 Nov 2022 09:41:46 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [v2][PATCH 1/1] net: phy: Add link between phy dev and mac dev
Content-Language: en-US
To:     Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>
Cc:     hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221125041206.1883833-1-xiaolei.wang@windriver.com>
 <20221125041206.1883833-2-xiaolei.wang@windriver.com>
 <Y4E3EOTXTE0PuY6B@lunn.ch>
From:   "Wang, Xiaolei" <xiaolei.wang@windriver.com>
In-Reply-To: <Y4E3EOTXTE0PuY6B@lunn.ch>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UUtiTkJTNk1QdnVzRlZDaUlRS2pTYmFzaWNHc0dSRlVTL3c2OTVGTENTdndv?=
 =?utf-8?B?MWZWdnl2aUIzdVIvVjU4c1dBcmJuWUhoMmdnWU9rRmV4ZDgyMks0ZG1KZHlw?=
 =?utf-8?B?dDJtcDkzdWlYeXd6Q0N4aTZydlNPWGFmSjlTT1NnZmhvdUMycy8vTHZTMkgx?=
 =?utf-8?B?dFY1QVBJSXJzME1qSFFSZjliK1AvaXRQQTgzSWxsTW1XMGZYUlJ0ZmpHUllv?=
 =?utf-8?B?RFR3Q0xVTDkvWmN6MWtqU2RMbCs5SUNQNHNJRktiSG5pM1crRFdHRVFzNS9H?=
 =?utf-8?B?aHlmMnNucU00UmZVbXlhTW52VU1jTy9GdnhRQk01OG5Jc1hwYzNVVjdySVpM?=
 =?utf-8?B?OTkrR2p0R1A4TFRPQkdieVlUZkdYTGUrOVptVE5pNkp0OVNVcXFOWkQvT0lV?=
 =?utf-8?B?enVPUWdvc3gvZU90UW9Zcms5NHh0d25YQWZ2WHNKMGphT3N0T0N6eUh2eWZ5?=
 =?utf-8?B?UkswTGlveGxscVZuR1V3Y2s4KzhURGNaQUJ1NnhMdmJ0bG4rWjJhQ2E5Z2p1?=
 =?utf-8?B?KzZyVm1wdTFWb0ZxM1I2aGdUV1phaGh4dHBQMHpNc282NzR1R3RjSVI1Y0FT?=
 =?utf-8?B?eTM5WVU4dk1UNVVrZTR4TjhDOXMyRmFwcDBTN0hSMklZTnNESXJ4N252YTNS?=
 =?utf-8?B?OUdHRWZySllLaEhYdXlaa1lSYXhyek5YQThwUXlGblB3Qjc0eXpzWWtwNGtN?=
 =?utf-8?B?SGRsbUhHQVhkZEtYZWlFaVhSV21CRlV6Zm9mRjloVmdtWDhyRjdBNWt1Tm9G?=
 =?utf-8?B?eS9NTFliVzduUGoyTTc4YzFpYnJuT1JHb0lBdGwvQW10RUZFTExvV3RVaEhV?=
 =?utf-8?B?TGFidlJMNGxMdHhZSWRqNmxTclZ5TUEvTzgzVCszYmhmNlBkdElHU08wdEtj?=
 =?utf-8?B?YlZYZWdtTWVpTEtjdnZ2c2lXa1QrWS9wY2dVTWxDWnNnSHJxSGRFVHR3ejRX?=
 =?utf-8?B?bStDYS9RS095SjMwL1NTN3hmUldNTlQ0MVdWZXNkNHN0azY3clVtNU0rM0ZO?=
 =?utf-8?B?dmpTOEJMQkRHQkRucy94YXVDd3pVWmNUeXl5elArMEtRZnlVb1FFQ3BFZTky?=
 =?utf-8?B?WEJFTksxWEZaVnh0Zy84OFJMVzkwNWZDSS9GSkhjNzV2VldmTWxva2tia3VO?=
 =?utf-8?B?USs5ZWprMU9KQXlTYlQxbWJNdUEvV09pRk9udndIT0VWRG9GRVQ3S2ZyVnpE?=
 =?utf-8?B?RVhoNUdXV3NDYmE1VzBYQ245dXRxeUdKWUU1ZW5jcFBzdXZNbjVkL1dkYkty?=
 =?utf-8?B?dkEvNXptSzNId215SnI2MjdiMFFPb3hRUVBOM0NqeDJlYmE0V2tOWXBCb1k5?=
 =?utf-8?B?L0FERWJ4NkJ2THBXZkhUaXhWSVY1V3plQ2dLK2ptM0dkM2pkUHVYckNQWUVw?=
 =?utf-8?B?Qzd3MElnSXpZdGxNenhYWWFZY1puK01sNFdaWGhyK2lZaE43Ny9nWTltSmYr?=
 =?utf-8?B?ZUl5ZDlBTXBNbHJxWkMzcmp2eTBxa3NhZlBFRnViTmFaaFFDV1UyVURiR1Vp?=
 =?utf-8?B?WHB6M3YwN0xIeEM1OElVT3gxQmJ6YXMzMzhjcjhtb1FtS3NSUENGbVZFNTRO?=
 =?utf-8?B?S2NRdUFSL0FNQURnT05QVXh2TDR0R2VwazNPQUlsWVU2OGlKZEpSaG54RmUr?=
 =?utf-8?B?b0lvSmwrVGxpZjRLSFJFVTdIYStnT1FTMU9vM2xyOUt0MjA0d2V0Ujk4ZzJQ?=
 =?utf-8?B?REZFOEJSY2IzTWJseTJTWnpabDBlQ3NEOFN6NTZJdUVZMzFYUkdQMjhmVVl5?=
 =?utf-8?B?L3BvYVVqeTNySjkvQXVqS1FyczcvQ0o5aFVGd0dZTWJNVXQ5ZzBMZ1pCUURm?=
 =?utf-8?B?aFc2aWlKdWNqVDBaUzAyc0c3U3NQWXFlOXY2ak9KcGw2QUlvYjZYOFZpNWRS?=
 =?utf-8?B?MnBFR3FKTWpwaTNXa29RdDRadVRCenNxNHdzbm14aE9yZDVTZ29WTTI4UmFK?=
 =?utf-8?B?V2lvdXVtbmhyZ0NuMXhiNCtYcjdWNWJMbUVJTEV5Nlg4eXgwbHo3LzhJcjcr?=
 =?utf-8?B?c3hVN1NqNlN5QVZmN28yeVk1eExSVzFNVUtyVWFUNWtXdnM3V1ROYXhhS3dP?=
 =?utf-8?B?QURUam1lTllFM1V2Q2R3L1pDZXlIdkFtd2UyZEVDU2JwbzZwc3N6eDM2aFNK?=
 =?utf-8?B?SHpvQkxaWXhXNE9vUU1CTlgyd2dUM0tZSjZBTmpLOGsraVpkRFoya2V0akpx?=
 =?utf-8?B?TkE9PQ==?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ab63dbb-ef6a-4850-d04b-08dacf4f65d9
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5764.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Nov 2022 01:41:54.6673
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jHW+unZSrsIoUSxkoVp+RsVEdRL9jafmgGvQzycxEfu+vH9NRPTbRve5oyeFbZfxZ2yX614Y+/3A7JYk2Y7VtkxYqcTePvMipTKOUi14xl0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5872
X-Proofpoint-GUID: mjmPl2V6OUO4fBtJJ3K8a5UxX9O4WOHC
X-Proofpoint-ORIG-GUID: mjmPl2V6OUO4fBtJJ3K8a5UxX9O4WOHC
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-26_01,2022-11-25_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0
 phishscore=0 spamscore=0 clxscore=1015 priorityscore=1501
 lowpriorityscore=0 mlxlogscore=556 impostorscore=0 adultscore=0
 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2211260009
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

add Florian

thanks

xiaolei

On 11/26/2022 5:43 AM, Andrew Lunn wrote:
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
> On Fri, Nov 25, 2022 at 12:12:06PM +0800, Xiaolei Wang wrote:
>> If the external phy used by current mac interface is
>> managed by another mac interface, it means that this
>> network port cannot work independently, especially
>> when the system suspend and resume, the following
>> trace may appear, so we should create a device link
>> between phy dev and mac dev.
>>
>>    WARNING: CPU: 0 PID: 24 at drivers/net/phy/phy.c:983 phy_error+0x20/0x68
>>    Modules linked in:
>>    CPU: 0 PID: 24 Comm: kworker/0:2 Not tainted 6.1.0-rc3-00011-g5aaef24b5c6d-dirty #34
>>    Hardware name: Freescale i.MX6 SoloX (Device Tree)
>>    Workqueue: events_power_efficient phy_state_machine
>>    unwind_backtrace from show_stack+0x10/0x14
>>    show_stack from dump_stack_lvl+0x68/0x90
>>    dump_stack_lvl from __warn+0xb4/0x24c
>>    __warn from warn_slowpath_fmt+0x5c/0xd8
>>    warn_slowpath_fmt from phy_error+0x20/0x68
>>    phy_error from phy_state_machine+0x22c/0x23c
>>    phy_state_machine from process_one_work+0x288/0x744
>>    process_one_work from worker_thread+0x3c/0x500
>>    worker_thread from kthread+0xf0/0x114
>>    kthread from ret_from_fork+0x14/0x28
>>    Exception stack(0xf0951fb0 to 0xf0951ff8)
>>
>> Signed-off-by: Xiaolei Wang <xiaolei.wang@windriver.com>
> This needs Florians review, since for v1 he thinks it will cause
> regressions.
>
>          Andrew