Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc:     jejb@linux.ibm.com, martin.petersen@oracle.com,
        linux-scsi@vger.kernel.org, dave.hansen@linux.intel.com,
        David.Laight@ACULAB.COM, linux-kernel@vger.kernel.org,
        x86@kernel.org
Subject: Re: [PATCHv2] scsi: Fix get_user() in call sg_scsi_ioctl()
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq11qpqmmq4.fsf@ca-mkp.ca.oracle.com>
References: <20221117232304.1544-1-kirill.shutemov@linux.intel.com>
Date:   Fri, 25 Nov 2022 22:14:02 -0500
In-Reply-To: <20221117232304.1544-1-kirill.shutemov@linux.intel.com> (Kirill
        A. Shutemov's message of "Fri, 18 Nov 2022 02:23:04 +0300")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?eqy9XC2gkH1nVIkNc9Q6Y8ZK3FoQXm2+Y0rBOu521m2u1BJnlxtuYGOLockE?=
 =?us-ascii?Q?80AkUQPUvCWtyl7T1jZt0qHi/BcdtT3j5unBGvS0xjsblXhVLc9PrEQdqukG?=
 =?us-ascii?Q?gYwqSQTG9P1rvBCCbGf7ZwZqR1gwcASuq/CunwsJGu83DQHf+Uvc/ibjXyza?=
 =?us-ascii?Q?0uSlGhGZ4Wwv3EqBvc2PBf+S0o3r3KZxSMIg9JQVYeZo6YywfqjqQ23CFndp?=
 =?us-ascii?Q?PPfFHonU5liMKO/kadDX1mRqklI+IJUH8aqQQooxdJJiJcyCCOFp4LdFXXEn?=
 =?us-ascii?Q?RSCOSbEmu6rBxhZj6N6xRnrS4D8y+INpTPGSN4rnsS+Tchuzi+iGDcKbY49X?=
 =?us-ascii?Q?EAvM8gUozlCHfcWKq6Q9MSBrd22kcr0BZAw3nswKc2eCWnT6L0PdnkSB5jjx?=
 =?us-ascii?Q?34Y/CvWusokeiUxNeyqBTy2Uh5L0r6Cc2xwP1MKA5XcXCtDo2F+btPI2CE+Q?=
 =?us-ascii?Q?CLbaWfpiM9F1Tjaff799zvZXBRLDLDfDoFD7UpqRtWGQ3Qe2cDDBUvQ2rfZ/?=
 =?us-ascii?Q?+QDuoU2IBA5IHypl6QEXOwPK3qQ/87qkj2IlD5M+IUQ9UV1xdZW+l9+WLAIv?=
 =?us-ascii?Q?ZQup3sVzyRbGe4ur1lsb8mGI7WWiE+/j/UzNJqTCh5S6U4eEJeD+k/tdbwcq?=
 =?us-ascii?Q?h8p9lK/mLs6zqo8wzTl47bUGIM2uJlfulxd7Fntca5BnFCLz4fcCw2vWRG4b?=
 =?us-ascii?Q?PHHl/oPEBoMwi6FypOdWPvR8lPs+dpVt0dBE6srI/DfrtiQLCoAliuRMVRxZ?=
 =?us-ascii?Q?QALg/hLPrANBKQF3o/a4pt/tijWIQu6eq4dmMLrfnty73n0PyPTDLzu8+Glr?=
 =?us-ascii?Q?Sf8CCHDi4XAQehNRCuQVBBNgtQGunXsWGZuWDlJNB2RswknKezPuCYdnfsxW?=
 =?us-ascii?Q?Iu5j8gSpr6T+6ZoIotH2QCNSChpfcdmM3GbQIpuru/zHFCMcPOllGcDimeex?=
 =?us-ascii?Q?wsaWTMk5VbtnwdbeUU0xVUkZ4wBFMBGFK8o1RSiLlyH3PejnH6sZ5BdiNzd8?=
 =?us-ascii?Q?Rq0+6U15aHHPD3t3wUednp6hXvMEtCWLZWyFfUeI9p2Idsw+R1lHo1evMqCP?=
 =?us-ascii?Q?CXgqjq/2Iwz6hDBLV3Rss99hsL7awuvOd/3G50xKiL57aP1vJFLOGQ1Kb8Rx?=
 =?us-ascii?Q?adbPLjyRy0wq7xWqqsa7+3T+trI3+j5L4/rqJkKF0OHftVK9+VWUwznJQ8XR?=
 =?us-ascii?Q?QU/if8tJfJTQ+qYIJfC3dRIYbXGNTM/fA8LB68sNcxVZ3GlgknXZGu1e8uO7?=
 =?us-ascii?Q?B7e7XLjmtjujdJGfXOvyHbbHYj2z7QQUwsC6HpQ3734/LBIhhPw4un9Z8BBq?=
 =?us-ascii?Q?drA9+U5DOdI/ZNgPOgHXpOd0G6zlJ6AZPYtdtqItCDtVPpWB0o3hYkNC1DIb?=
 =?us-ascii?Q?qeHWTzqetPiAUExTmbxap35Gy1HAEdMvfmr6FU/jYGlGneWt8KKu31nlgOEP?=
 =?us-ascii?Q?oXQKbVCepV1Zy+JZWKxbw5fRaXn7vsNDlBioAwbcX8bLWcJiDrRGNqxPurUG?=
 =?us-ascii?Q?Kk6KP179q2v7Ga5rEh5UFvvrhjxS92ZQ0zdqpWtta2GBA5EOh62i/3Ep3x7C?=
 =?us-ascii?Q?v9MjdABtIsl8BCZohzvvFlOewn8jeONpyvpYOniafYBragdCf/TFcHhsCD/D?=
 =?us-ascii?Q?vw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?qfVYXNJ/YPnLVT5zwItXFHc+dD7egN5Csk6jvGXJotS3b2/mLS9c4JT3OUTe?=
 =?us-ascii?Q?nqurD9jmxAzujBk/Z9TnGuGMMj0XerQj6VJ63aGHZA/tE0D4LDnyp6Ek3H2x?=
 =?us-ascii?Q?/YZRQvZcR04idyMsXJdhIa+SoDUg/bnQ3GuvM8qK/oKT1CA+Y0E80x1CtAc9?=
 =?us-ascii?Q?/QW4aVCsCIeDq5Tk6NjsFBzOpXmUoh1t43mVFNtFC9sid8el6amaesCK6pa2?=
 =?us-ascii?Q?R+KVxztOZGcZV0P0wrSHtKfNoHPtZAuCJkCcVhMedyOjCoOFI0+4jujcW7pP?=
 =?us-ascii?Q?i/7u0m1rUzbo4aeWPqUuVSV25+U0PwcZsAzRj129JxcIK7t4z0mdYQHTther?=
 =?us-ascii?Q?ru4Wqi0eVgV85Z6dLbxi3c1QJxts3/yYORdN/dm5IkJt85EPaByuO0bCId8j?=
 =?us-ascii?Q?yNVcZdSVvtVQA9ZOGfmD1+seEhcBg7OshRo/nEZqDo+6zYpRvISfuw78qBy0?=
 =?us-ascii?Q?FGDolFnwUh4HBMAd71N9EhMwb/e9P3vIEjX6h9IoX+z9M+1bzEE69z1KJ7lI?=
 =?us-ascii?Q?ggpbpPHIoR44CLQ0XCBbCC7eiNq7kLPvVXO1bhE+hcinWB1/2PAj+Vv92+2W?=
 =?us-ascii?Q?XhFyRvRhFrqe+c7TGHTjCj2JN0MjAECnKucznXsRo2gCHCCKUD1wQsKOQwgO?=
 =?us-ascii?Q?mPS/T5mMaZ3XiXyygkKlOMyVPrST8DBGnjMuLqK2UY+DsQVSvGwTk3BXfnzE?=
 =?us-ascii?Q?YA4EyuoNncstovQdiBAfaGyeAKq021YAGmnn44gZDpxdd4svvZjhTDGG75M8?=
 =?us-ascii?Q?nqX1PQRG8VJnPCN9qmahkdPlvjgPNSAwbdOHvEY5kGUo8ORlqjC4xrHwZgBu?=
 =?us-ascii?Q?GiNj/lZpGaKASbsYVJTHHbWNKenN4hnEsfOcvaAptKeUnSPCJ1cN2txB+rSL?=
 =?us-ascii?Q?xQntApPzKAL4DEDKJT3YKPzoQYggiS8B3alw0y6LlR0wlgloAV2GCO9mL4Tn?=
 =?us-ascii?Q?BrFctcfrL/WpLgQWG19+ZopONVXF+Mm3M3C+8lSniHs=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dc6b1a8f-d2d2-4bb3-0951-08dacf5c45f6
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Nov 2022 03:14:04.5913
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qfYcSpNlZfUeC86sZw5L3r/1efjK6Stzum6SxJN4g8/D961Bj0u9IA1MqRx9BBI+UMAB5+iubpCXCC22gPb3wtMgyNSwxoCv4INNbCxLErY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB6047
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-26_02,2022-11-25_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=866 suspectscore=0
 spamscore=0 malwarescore=0 adultscore=0 mlxscore=0 phishscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2211260023
X-Proofpoint-ORIG-GUID: bwDZ955fqu76DRlRpXZzdYBfUKY9KZeh
X-Proofpoint-GUID: bwDZ955fqu76DRlRpXZzdYBfUKY9KZeh
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Kirill,

> get_user() expects the pointer to be pointer-to-simple-variable type,
> but sic->data is array of 'unsigned char'. It violates get_user()
> contracts.

Applied to 6.2/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering