Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e583b75d-feeb-bb33-1567-e7dde4f04ed7@xs4all.nl>
Date:   Sat, 26 Nov 2022 11:39:52 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [PATCH 4/4] media: i2c: s5c73m3: switch to using gpiod API
Content-Language: en-US
From:   Hans Verkuil <hverkuil@xs4all.nl>
To:     Linus Walleij <linus.walleij@linaro.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Sylwester Nawrocki <s.nawrocki@samsung.com>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
References: <20221115221145.2550572-1-dmitry.torokhov@gmail.com>
 <20221115221145.2550572-4-dmitry.torokhov@gmail.com>
 <CACRpkdbARhDuqSiOZM6GZynHsQWau8JhsEa2zcpsPZSLuD07Kg@mail.gmail.com>
 <e4609919-d9be-33c4-1488-352443523b14@xs4all.nl>
In-Reply-To: <e4609919-d9be-33c4-1488-352443523b14@xs4all.nl>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 26/11/2022 11:34, Hans Verkuil wrote:
> Hi Linus,
> 
> On 17/11/2022 10:06, Linus Walleij wrote:
>> On Tue, Nov 15, 2022 at 11:11 PM Dmitry Torokhov
>> <dmitry.torokhov@gmail.com> wrote:
>>
>>> This patch switches the driver away from legacy gpio/of_gpio API to
>>> gpiod API, and removes use of of_get_named_gpio_flags() which I want to
>>> make private to gpiolib.
>>>
>>> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>>
>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> There are now two patches that do this switch to using the gpiod API:
> this one, and one from you:
> 
> https://patchwork.linuxtv.org/project/linux-media/patch/20221108100604.1500909-1-linus.walleij@linaro.org/

And a third one as well:

https://patchwork.linuxtv.org/project/linux-media/patch/20221116194307.164543-1-mairacanal@riseup.net/

> 
> Any preference?
> 
> Regards,
> 
> 	Hans