Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 26 Nov 2022 14:02:14 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Wang Yufen <wangyufen@huawei.com>
Cc:     bvanassche@acm.org, jgg@ziepe.ca, leon@kernel.org,
        dennis.dalessandro@cornelisnetworks.com,
        linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
        bart.vanassche@wdc.com, easwar.hariharan@intel.com
Subject: Re: [PATCH v2 2/2] RDMA/srp: Fix error return code in
 srp_parse_options()
Message-ID: <Y4IARpGaqfvHtu75@smile.fi.intel.com>
References: <1669433704-2254-1-git-send-email-wangyufen@huawei.com>
 <1669433704-2254-2-git-send-email-wangyufen@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1669433704-2254-2-git-send-email-wangyufen@huawei.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Sat, Nov 26, 2022 at 11:35:04AM +0800, Wang Yufen wrote:
> In the previous while loop, "ret" may be assigned zero, , so the error
> return code may be incorrectly set to 0 instead of -EINVAL.
> Add out_with_einval goto label and covert all "goto out;" to "goto
> out_with_einval:" where it's appropriate, alse investigate each case
> separately as Andy suggessted.

It's better now, though you missed something...

...

>  		case SRP_OPT_TARGET_CAN_QUEUE:
> -			if (match_int(args, &token) || token < 1) {
> +			ret = match_int(args, &token);

Check for ret?

> +			if (token < 1) {
>  				pr_warn("bad max target_can_queue parameter '%s'\n",
>  					p);
> -				goto out;
> +				goto out_with_einval;
>  			}
>  			target->target_can_queue = token;
>  			break;

...

>  			target->scsi_host->can_queue);

The below can't be like this, right?

> +out_with_einval:
> +	ret = -EINVAL;
>  out:
>  	kfree(options);
>  	return ret;

-- 
With Best Regards,
Andy Shevchenko