Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <372591f3-c7c3-4c50-dad7-fcd386454709@huawei.com>
Date:   Sat, 26 Nov 2022 21:19:07 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.0
Subject: Re: [PATCH v2 2/2] RDMA/srp: Fix error return code in
 srp_parse_options()
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC:     <bvanassche@acm.org>, <jgg@ziepe.ca>, <leon@kernel.org>,
        <dennis.dalessandro@cornelisnetworks.com>,
        <linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <bart.vanassche@wdc.com>, <easwar.hariharan@intel.com>
References: <1669433704-2254-1-git-send-email-wangyufen@huawei.com>
 <1669433704-2254-2-git-send-email-wangyufen@huawei.com>
 <Y4IARpGaqfvHtu75@smile.fi.intel.com>
From:   wangyufen <wangyufen@huawei.com>
In-Reply-To: <Y4IARpGaqfvHtu75@smile.fi.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2022/11/26 20:02, Andy Shevchenko 写道:
> On Sat, Nov 26, 2022 at 11:35:04AM +0800, Wang Yufen wrote:
>> In the previous while loop, "ret" may be assigned zero, , so the error
>> return code may be incorrectly set to 0 instead of -EINVAL.
>> Add out_with_einval goto label and covert all "goto out;" to "goto
>> out_with_einval:" where it's appropriate, alse investigate each case
>> separately as Andy suggessted.
> 
> It's better now, though you missed something...
> 
> ...
> 
>>   		case SRP_OPT_TARGET_CAN_QUEUE:
>> -			if (match_int(args, &token) || token < 1) {
>> +			ret = match_int(args, &token);
> 
> Check for ret?

Yes, there's a ret check missing here, will change in v3

> 
>> +			if (token < 1) {
>>   				pr_warn("bad max target_can_queue parameter '%s'\n",
>>   					p);
>> -				goto out;
>> +				goto out_with_einval;
>>   			}
>>   			target->target_can_queue = token;
>>   			break;
> 
> ...
> 
>>   			target->scsi_host->can_queue);
> 
> The below can't be like this, right?

Yes, I'm sorry for the breakage, also will change in v3
Thanks!

> 
>> +out_with_einval:
>> +	ret = -EINVAL;
>>   out:
>>   	kfree(options);
>>   	return ret;
>