Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp12170209rwb; Sat, 26 Nov 2022 05:29:19 -0800 (PST) X-Google-Smtp-Source: AA0mqf6whcGY/GOWUtH+BKNCEk5m4SxZwJJEhZF6sKMm/SWU+3vHFh62Tjj/LXToaSaXCw7Vtczc X-Received: by 2002:a17:902:db0c:b0:189:1963:d0d7 with SMTP id m12-20020a170902db0c00b001891963d0d7mr23925157plx.100.1669469359707; Sat, 26 Nov 2022 05:29:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669469359; cv=none; d=google.com; s=arc-20160816; b=m9EJGiad6e7oZ2MHmLJt8zhnP+q3ALgEtUz+/WsUvLCY4OOj6rkoZdBNEP2cddAl73 77hbhr2V8B9wo9gpd2Io9kFK5RhTgtehpnYyC95VcIBrQLigiPoMJeq7Bfv9lZ3TuAyH +3226BrkpflszgXD+NcljWsHIbinRsURGzp22Pryo1lt2+sYhGrZzRnKoeGhB8U1+LZi K1DxJzbd0GyELFZJdDng4l1DwrnFr0RSDl79Puqji9lmo3YgxgXs8VLvXlLoIrsceDiX ia9XutpMkYeA9HZGuSMpzPOqhIzb/GZ9ohQUh4kQLyNL2O5enci6QlW56utN0LRPKTrD ZPng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=Na6FyrdsS1wwt6jy4jKZXGg53Il9zjDGwsbPs6Y7vs8=; b=nvfIEJ3Ny/um8hP0Ja+86Ziw9hePw82owY7j3If3BNmN8sToZs30zjt7Hq1VX2oky8 0z99Hu9eiDDquzQyrEoLMHvbEP2nxMaNdxcoBm+XusMU963kqV0w6IRfm80cSPO6u7iw LHqJ62RPfbpq1gA+Axmt/2edknSyJAGWniPdQCXujXmWnUr19tIhBNTyshxu8k1gHts5 btCzL6O1xYO6vvZjNcfHFS1BYiiWSvarHTHvIo7vIUT0dpPiuVUKuzMiPYGCFu9DFVce DDDuYolGR+ImiwWKMQ/YSA1fweY2V6woo8iZyu0JmF6fM2/EVS8+zOr6x9wDVIbk2ufn pXzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ojwqnhX4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n16-20020a17090aab9000b00218d51d0c92si8527665pjq.184.2022.11.26.05.29.05; Sat, 26 Nov 2022 05:29:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ojwqnhX4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229590AbiKZNZS (ORCPT + 84 others); Sat, 26 Nov 2022 08:25:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229582AbiKZNZQ (ORCPT ); Sat, 26 Nov 2022 08:25:16 -0500 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19C381A061 for ; Sat, 26 Nov 2022 05:25:15 -0800 (PST) Received: by mail-lj1-x229.google.com with SMTP id l8so8009573ljh.13 for ; Sat, 26 Nov 2022 05:25:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Na6FyrdsS1wwt6jy4jKZXGg53Il9zjDGwsbPs6Y7vs8=; b=ojwqnhX4HWIRw/01nosPbAo+kI1IeXq4oX6pTqV7VqEAjHwiSgIMn8vz/cI9OG/fvZ lwRlXt2Ob7aRq1D+/MBJQlUvc4cdmFsC+8i8jq2hfEqaFNwyITvTyja+ZySaXx9WiPbL AhxTVSiyyTcurXiBz5+0uBt7dQP2fvzP+amc9BH1XQhwhtDeXAwKn7v4GVWaKeRG5FTr oQoSF9ZqxnDo9qt2+F1geCe7WYPySfPEui0AKJe39HxvhG82a6QOUpxX1koK/CYvMMrt Dx6zVKKQ94b/YCeYD/fQxWKOP128ad71EABMwSJxRnV/iRgWeHcxDGDX9EKfRqgK7Ofn UnEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Na6FyrdsS1wwt6jy4jKZXGg53Il9zjDGwsbPs6Y7vs8=; b=MFKyL+9dQHeJLGQ0bRNNPcZCztwGpYA5FyQatRy/wmXQjElTL0CKhwDQN/SKg387+j yRwwrZgHRZuUMqueOeRkQcicjJYQ64OVcQO0Tc8KbYrgU20Wx7/WikChvh78xVvD18Sa kjTCAlj2fkVH8oTJ4CwKjLLtMmjqu7O/prgUdg3b6FisGbIuV0N8VyflrcvaVgJylkni 0ZLsTCQs3HMsWA2seUysTPMry6TVYTZkh4UuKgZir035mFWKQJpsRh8iISHME7hpGa/T j5+DWfHZB5m7Ba6cI381VUf0JaOd8JXheR18IVP9sIYyQVk1QpY9Y/scWx4kGPrs0Cy0 JNWA== X-Gm-Message-State: ANoB5plPu10MhUPo4Tq8KhgVinMAzxZy9ZwbsBtSJ1EmDGA1mQMqK2Bi nKLjfmDBjB9K4etUHU6ZKuzzSw== X-Received: by 2002:a2e:aa14:0:b0:277:63f7:492c with SMTP id bf20-20020a2eaa14000000b0027763f7492cmr8428769ljb.259.1669469113410; Sat, 26 Nov 2022 05:25:13 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id t6-20020a199106000000b004b4b5d59cbcsm922230lfd.265.2022.11.26.05.25.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Nov 2022 05:25:12 -0800 (PST) Message-ID: Date: Sat, 26 Nov 2022 14:25:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 1/3] dt-bindings: net: sun7i-gmac: Fix snps,dwmac.yaml inheritance Content-Language: en-US To: Samuel Holland , Chen-Yu Tsai , Jernej Skrabec , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski Cc: LABBE Corentin , Maxime Ripard , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, netdev@vger.kernel.org References: <20221125202008.64595-1-samuel@sholland.org> <20221125202008.64595-2-samuel@sholland.org> From: Krzysztof Kozlowski In-Reply-To: <20221125202008.64595-2-samuel@sholland.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/11/2022 21:20, Samuel Holland wrote: > The sun7i-gmac binding extends snps,dwmac.yaml, and should accept all > properties defined there, including "mdio", "resets", and "reset-names". > However, validation currently fails for these properties because the > local binding sets "unevaluatedProperties: false", and snps,dwmac.yaml > is only included inside an allOf block. Fix this by referencing > snps,dwmac.yaml at the top level. > I don't understand where is the problem and how does your patch solve it. The old syntax is correct and your change does nothing, no fixing, no impact. It actually looks like noop with big explanation :( > Signed-off-by: Samuel Holland > --- Best regards, Krzysztof