Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221125144141.477253-1-krzysztof.kozlowski@linaro.org>
 <3719828c-0ac5-34c9-a04b-251cbeb5f6ef@linaro.org> <a135f93a-235a-27b8-f649-69d62f6ebd30@linaro.org>
 <54f500cb-d7d0-8af1-eb58-99fbe71791a5@linaro.org>
In-Reply-To: <54f500cb-d7d0-8af1-eb58-99fbe71791a5@linaro.org>
From:   Neil Armstrong <neil.armstrong@linaro.org>
Date:   Sat, 26 Nov 2022 17:03:39 +0100
Message-ID: <CAB6niQ4808JEgdQEvRvaYqq8YmFCGo_YLnxXo+rjpSgxQxu+7g@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: amlogic: align LED node names with dtschema
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, 26 Nov 2022 at 15:24, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 26/11/2022 15:16, Krzysztof Kozlowski wrote:
> > On 25/11/2022 18:16, Neil Armstrong wrote:
> >> On 25/11/2022 15:41, Krzysztof Kozlowski wrote:
> >>> The node names should be generic and DT schema expects certain pattern:
> >>>
> >>>    amlogic/meson-sm1-bananapi-m5.dtb: leds: 'blue' does not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
> >>>
> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>> ---
> >>>   arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts | 4 ++--
> >>>   1 file changed, 2 insertions(+), 2 deletions(-)
> >>>
> >>
> >>
> >> <snip>
> >>
> >>
> >> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
> >
> > Aren't you maintainer of the platform? This means I should take care of
> > this patch?
>
> Ah, this will be picked up by Kevin or Jerome? So this tag means only
> Reviewer's statement of oversight, right?

Of course I'll pick it.

Neil


>
> Best regards,
> Krzysztof
>