Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <655fd7e303b852809d3a8167d28091429f969c73.1669486407.git.andreyknvl@google.com>
In-Reply-To: <655fd7e303b852809d3a8167d28091429f969c73.1669486407.git.andreyknvl@google.com>
From:   Andrey Konovalov <andreyknvl@gmail.com>
Date:   Sat, 26 Nov 2022 19:16:17 +0100
Message-ID: <CA+fCnZceUx+Vqj7nUPiLrexnmU11KkGGtJ3-9KfXm336e+cv3w@mail.gmail.com>
Subject: Re: [PATCH mm] kasan: fail non-kasan KUnit tests on KASAN reports
To:     David Gow <davidgow@google.com>
Cc:     Marco Elver <elver@google.com>,
        Alexander Potapenko <glider@google.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        kasan-dev@googlegroups.com,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Andrey Konovalov <andreyknvl@google.com>,
        andrey.konovalov@linux.dev
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Nov 26, 2022 at 7:15 PM <andrey.konovalov@linux.dev> wrote:
>
> From: Andrey Konovalov <andreyknvl@google.com>
>
> After the recent changes done to KUnit-enabled KASAN tests, non-KASAN KUnit
> tests stopped being failed when KASAN report is detected.
>
> Recover that property by failing the currently running non-KASAN KUnit test
> when KASAN detects and prints a report for a bad memory access.
>
> Note that if the bad accesses happened in a kernel thread that doesn't
> have a reference to the currently running KUnit-test available via
> current->kunit_test, the test won't be failed. This is a limitation of
> KUnit, which doesn't yet provide a thread-agnostic way to find the
> reference to the currenly running test.
>
> Fixes: 49d9977ac909 ("kasan: check CONFIG_KASAN_KUNIT_TEST instead of CONFIG_KUNIT")
> Fixes: 7f29493ba529 ("kasan: switch kunit tests to console tracepoints")
> Signed-off-by: Andrey Konovalov <andreyknvl@google.com>

Hi David,

Could you please check whether this patch resolves the issue with
non-KASAN KUnit tests for you?

Thank you!