Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f518b66b-6ce0-6828-8e67-a1f572b951b4@axentia.se>
Date:   Sat, 26 Nov 2022 22:44:19 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH] mux: mmio: drop obsolete dependency on COMPILE_TEST
Content-Language: en-US
To:     Jean Delvare <jdelvare@suse.de>
Cc:     LKML <linux-kernel@vger.kernel.org>
References: <20221124133737.659429ce@endymion.delvare>
From:   Peter Rosin <peda@axentia.se>
In-Reply-To: <20221124133737.659429ce@endymion.delvare>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QStsMGpWMC9ZK0Jmb004Q0todHl1ZHJkN0ZNOTRGRk1tT1JyQWFvVHpUVVor?=
 =?utf-8?B?Y0hwMmduOTExbUlRcW16VTJrYmdVT0lJemQxWlBYUGpWR0J5eENRRnlLck02?=
 =?utf-8?B?Skt6QzJPb1hlaENmMUorNXl3M0JEWGdCdnZsTmlxNStKdVRMRzJEMFJGMzVJ?=
 =?utf-8?B?Y3BGVHdteDRWdUZLT3lyckRqdFhiUVllTG5rQytEVENBaExsYmxYdjZHZVBE?=
 =?utf-8?B?TDBEbkJvU1pxRFNDWmpYdzl6ZEdzYTFLNTA0a1dtVi9rTlpET0cyMnRBY1g3?=
 =?utf-8?B?REovNmo5WHRpbTlGRHRmR0p3dlhac2I0VndndFVrV2x2Y1MwaXZPclpMR2lx?=
 =?utf-8?B?c1VSVG0vbWgrVXA1WXBrNlN2cW9Yc01aZ0pXd0RML0JVU285enFIOEttMEps?=
 =?utf-8?B?Y0E3cERxa2ppcjZHNUFLYjVtZHAvT3VzaEtoRndJcGZjNEI5Mmc3YmlySytN?=
 =?utf-8?B?UnA3alpLdDJHQm8zUUdwV0t1VjlpR3hiQlRucnUrWC9VTVduenVMSVpVS3dL?=
 =?utf-8?B?ZXZQdjVmdSs2YmlsMUY2bVBCWUFtZFRNajNtMndHd0FHdEF1QnFCcXY1U0RE?=
 =?utf-8?B?V2NQYm14WGZ3c0VISHJReUp4cW9jck9aNHFvVUNEVEVQYWcyK1Q1WlorUjdJ?=
 =?utf-8?B?c3JtZ3RORjFxRThLRTRNWGhVK0srSmh4MDN0a0t6OHJmNjRlUWNSekJEK2Zs?=
 =?utf-8?B?VFJDdDk3eE9OV0FSZG41a3cra2IwQjlIa0c3MmxIL1J5aUhHaC9lODF4Y1lo?=
 =?utf-8?B?d0VHdmljNGljaTkvY2hJaWV6bXZoYitCTVdYdzd0RDVoaW9aZjBybTJYc1c4?=
 =?utf-8?B?MkNGUnFlUGR5Mi9DdHh2VitZMHBWMzhFb014ZW9HSGxRTzBRWHZ4d1RtZXBW?=
 =?utf-8?B?MXI2QllHclk5QkdlbUNmZWJHd1ZYK2ZzZWg1WXJXM1JXV2NmLytpWng3ZUNv?=
 =?utf-8?B?bEYrUnl2K1J5a2ZicjBQTXBsY3h0WTJEU09Id3hpMytHaURPWkFwWHhwclBH?=
 =?utf-8?B?OXJheURvQTZKcVpJeDhNKzArMEF5TzZaUU5md3kyYnY2VjhteXNJY0VQN2hh?=
 =?utf-8?B?Q3BtY0lEcWtNaFl3a09XQXlGV2N0UjFiUlRnc2JvTDdzakRxSTk5QTIycEJ2?=
 =?utf-8?B?VTdZelNFZTJTOCtBeDZwaHBNYnErUWExa3dyVlQvSDBzd1ZMQ01WUVM2cHRw?=
 =?utf-8?B?WnhvMmJpdEEvMCs4NEdzNGN2aFFGNWlPUzRYNkc4aDdPVDhJbURua2lWSy9U?=
 =?utf-8?B?YnVWakdMN3g1eEkwSEFVN1lHcnlJVWo1dzk3cWNnUnBMRVovVkZ0Q2R6Zlcz?=
 =?utf-8?B?VjJKbjZpZ3crQTh0TWRCa04zaUNkTVR1MFBHbUNkbHVLY0RNbDhBQWpNakU3?=
 =?utf-8?B?TS9wbnAzRTBRU2dNMjVNNEFqSDBuNE5Gc1hjL2xsNjFSa3E4VVhGeWE3UUEx?=
 =?utf-8?B?OEJVTE9TMS85NUgxUld3NUQ1NEZ2ZWltaGlxWWVWVzZlRWZ6eFMvYXRkL2gz?=
 =?utf-8?B?eXB0V1NpYjVnZkRLU3E5enJVN0lGZlVBVnJNWHBMWXlyenF2RktpaEdRa3pX?=
 =?utf-8?B?SkFkTUNyU2Y1MldzK0NFTzlmM0lFbVlvR2hWRHYwYm5kc1pGS1pXU0Y2ZmNY?=
 =?utf-8?B?clZ0VFFwRDlRS2VWL08rR0hXbUtPTUFCd3luTlZZZDhhZXBJVXBLdkVTOU4w?=
 =?utf-8?B?ck13OU9neFFIbXhVNzQybnBFOGRiaFVCYzNMc09xMTd4eTVoNHd5d2ZwY1Vo?=
 =?utf-8?B?empHTWlUVTJzWjNqQXoyTFZLcHZIZElBQWtsOElJOFBySzQ4ZktlTXdQZVJM?=
 =?utf-8?B?cGNpODZkS1ZjcFpHeUV6ZlZVcHRRRjFsT2w3dVpNZzhuRFlFYjZlZ0xOU1Bk?=
 =?utf-8?B?TzVDNWZQWGtQTDRrYkc0T3ZsaUFMcmd2M3hqME5kdTl2di9sNC9TcXRvb1Zv?=
 =?utf-8?B?Ti9odjhlamdWM0NPZ0dSWFdrOGZXOEc0NStGYzErd2hvRzVQcVpnVVNNbmxq?=
 =?utf-8?B?bUt1SW9RWktRM2JkUW50OXVZY1FNci9tMml3SDFNRk9qRFRyT2U5RmhjZXFR?=
 =?utf-8?B?Nk8rSU5xeTMxaEcxa2pQYUNQUkh5SWR3TDBUSFpRM3ZsY2t3ZWF5RWdwVlJC?=
 =?utf-8?Q?OiWQ1zqVMdZ/zOCzM82aKI5lW?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: ce36ebe8-b056-418b-9cf5-08dacff76090
X-MS-Exchange-CrossTenant-AuthSource: AM0PR02MB4436.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Nov 2022 21:44:21.2495
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XadQpdWaL1qPibppMNC9l4oMv7CqNghKlMaxhnshn3wxA8jWquJrB0u6LV0cteDa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR02MB7773
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi!

2022-11-24 at 13:37, Jean Delvare wrote:
> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
> is possible to test-build any driver which depends on OF on any
> architecture by explicitly selecting OF. Therefore depending on
> COMPILE_TEST as an alternative is no longer needed.
> 
> It is actually better to always build such drivers with OF enabled,
> so that the test builds are closer to how each driver will actually be
> built on its intended target. Building them without OF may not test
> much as the compiler will optimize out potentially large parts of the
> code. In the worst case, this could even pop false positive warnings.
> Dropping COMPILE_TEST here improves the quality of our testing and
> avoids wasting time on non-existent issues.
> 
> As a minor optimization, this also lets us drop of_match_ptr(), as we
> now know what it will resolve to, we might as well save cpp some work.
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Peter Rosin <peda@axentia.se>

Yes, entirely reasonable. I have pushed this out to the mux for-next
branch. That said, it's probably a bit late for the upcoming merge
window...

Cheers,
Peter

> ---
>  drivers/mux/Kconfig |    2 +-
>  drivers/mux/mmio.c  |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> --- linux-6.0.orig/drivers/mux/Kconfig
> +++ linux-6.0/drivers/mux/Kconfig
> @@ -47,7 +47,7 @@ config MUX_GPIO
>  
>  config MUX_MMIO
>  	tristate "MMIO/Regmap register bitfield-controlled Multiplexer"
> -	depends on OF || COMPILE_TEST
> +	depends on OF
>  	help
>  	  MMIO/Regmap register bitfield-controlled Multiplexer controller.
>  
> --- linux-6.0.orig/drivers/mux/mmio.c
> +++ linux-6.0/drivers/mux/mmio.c
> @@ -131,7 +131,7 @@ static int mux_mmio_probe(struct platfor
>  static struct platform_driver mux_mmio_driver = {
>  	.driver = {
>  		.name = "mmio-mux",
> -		.of_match_table	= of_match_ptr(mux_mmio_dt_ids),
> +		.of_match_table	= mux_mmio_dt_ids,
>  	},
>  	.probe = mux_mmio_probe,
>  };
> 
>