Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <e3017eda-3764-4ff0-71fc-0f33f5ad8085@roeck-us.net>
Date:   Sun, 27 Nov 2022 07:01:47 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH] hwmon: (hih6130) Modify mismatched function name
Content-Language: en-US
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, jdelvare@suse.com
Cc:     linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
References: <20221127134351.87394-1-jiapeng.chong@linux.alibaba.com>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <20221127134351.87394-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/27/22 05:43, Jiapeng Chong wrote:
> No functional modification involved.
> 
> drivers/hwmon/hih6130.c:185: warning: expecting prototype for hih6130_show_humidity(). Prototype was for hih6130_humidity_show() instead.
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3264
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

NACK. We don't start changing function names because some robot
thinks we should. Please do not submit such patches against the hwmon
or watchdog subsystems.

Guenter

> ---
>   drivers/hwmon/hih6130.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/hih6130.c b/drivers/hwmon/hih6130.c
> index d9394e19fea8..764e6e185d98 100644
> --- a/drivers/hwmon/hih6130.c
> +++ b/drivers/hwmon/hih6130.c
> @@ -172,7 +172,7 @@ static ssize_t hih6130_temperature_show(struct device *dev,
>   }
>   
>   /**
> - * hih6130_show_humidity() - show humidity measurement value in sysfs
> + * hih6130_humidity_show() - show humidity measurement value in sysfs
>    * @dev: device
>    * @attr: device attribute
>    * @buf: sysfs buffer (PAGE_SIZE) where measurement values are written to