Date: Sun, 12 Aug 2007 12:15:26 -0700 (PDT)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Andi Kleen <ak@suse.de>
cc: dean@arctic.org, patches@x86-64.org,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [1/12] x86: Work around mmio config space quirk on AMD
 Fam10h
In-Reply-To: <200708121203.23741.ak@suse.de>
Message-ID: <alpine.LFD.0.999.0708121205210.30176@woody.linux-foundation.org>
References: <20070809241.425881000@suse.de> <20070809124128.886BE14F3B@wotan.suse.de>
 <alpine.LFD.0.999.0708120216470.30176@woody.linux-foundation.org>
 <200708121203.23741.ak@suse.de>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1144
Lines: 29


On Sun, 12 Aug 2007, Andi Kleen wrote:
> >
> > Damn you, Andi.
> 
> Thanks for the kind words.

Should I be impressed by the fact that 16% of your patches caused bootup 
problems, when we're really close to a -rc3, and *long* past the point 
where we want to address regressions rather than cause them?

I simply want you to be more careful.  *Much* more careful. As it is, I 
end up always being afraid of merging your patch-series (and yes, I should 
have found this even earlier when reading through the diff rather than 
after I had already applied it, but I didn't, and we had a broken kernel 
for a few hours as a result. I didn't see any bug-reports about this one, 
so hopefully nobody noticed, but it still grates me).

Bugs happen, but (a) they should happen during the merge window, not when 
we're in stabilization phase and (b) the percentages here were just not 
very good.

			Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/