Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 22 Nov 2022 06:34:33 -0500
From:   William Breathitt Gray <william.gray@linaro.org>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     linus.walleij@linaro.org, brgl@bgdev.pl,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        michael@walle.cc, broonie@kernel.org
Subject: Re: [PATCH v3 6/9] gpio: i8255: Migrate to gpio-regmap API
Message-ID: <Y3yzySLwPlN2MgQz@fedora>
References: <cover.1669100542.git.william.gray@linaro.org>
 <283c5af8825596d55b943b593eab561c912a088f.1669100542.git.william.gray@linaro.org>
 <Y35bgFmiMW3uTm/O@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="a8TFj+G0T0TRQ8kJ"
Content-Disposition: inline
In-Reply-To: <Y35bgFmiMW3uTm/O@smile.fi.intel.com>
Precedence: bulk


--a8TFj+G0T0TRQ8kJ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 23, 2022 at 07:42:24PM +0200, Andy Shevchenko wrote:
> On Tue, Nov 22, 2022 at 02:11:03AM -0500, William Breathitt Gray wrote:
> > +/**
> > + * struct i8255_regmap_config - Configuration for the register map of =
an i8255
> > + * @parent:	parent device
> > + * @map:	regmap for the i8255
> > + * @num_ppi:	number of i8255 Programmable Peripheral Interface
> > + * @names:	(optional) array of names for gpios
> > + * @domain:	(optional) IRQ domain if the controller is interrupt-capab=
le
>=20
> > + * Note: The regmap is expected to have cache enabled and i8255 control
> > + * registers not marked as volatile.
>=20
> Have you considered to catch wrong configurations by BUILD_BUG_ON() /
> static_assert() / another means of validation?

Ideally, I'd like to check for these configurations, but struct regmap
is an opaque type (the definition is in drivers/base/regmap/internal.h).
Do you know if there is some way to query a struct regmap for whether a
particular register has cache enabled or is marked as volatile?

William Breathitt Gray

--a8TFj+G0T0TRQ8kJ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCY3yzyQAKCRC1SFbKvhIj
Ky9KAP42iq/9ni69tKLscqHnxJy12rS4ARDZdLWMji9vF56HjAD/ZoIQOw13blee
jeZ/w1zhsUnqVQJLb40fvdafTMMnBg0=
=vOL1
-----END PGP SIGNATURE-----

--a8TFj+G0T0TRQ8kJ--