Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>
CC:     "x86@kernel.org" <x86@kernel.org>, Joerg Roedel <joro@8bytes.org>,
        "Will Deacon" <will@kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
        Marc Zyngier <maz@kernel.org>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        Jason Gunthorpe <jgg@mellanox.com>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        "Raj, Ashok" <ashok.raj@intel.com>, Jon Mason <jdmason@kudzu.us>,
        Allen Hubbe <allenbh@gmail.com>
Subject: RE: [patch V2 25/33] PCI/MSI: Provide post-enable dynamic allocation
 interfaces for MSI-X
Thread-Topic: [patch V2 25/33] PCI/MSI: Provide post-enable dynamic allocation
 interfaces for MSI-X
Thread-Index: AQHY/bbtFxCOpPjo80emqF3PmRNPf65NVNpwgAB4XYCABc4isA==
Date:   Mon, 28 Nov 2022 01:49:44 +0000
Message-ID: <BN9PR11MB52766BA9CE2BA102FA41297A8C139@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20221121083657.157152924@linutronix.de>
 <20221121091327.869774994@linutronix.de>
 <BN9PR11MB527668DB0B5B9C8D8C36C95F8C0F9@BN9PR11MB5276.namprd11.prod.outlook.com>
 <87r0xsd8j4.ffs@tglx>
In-Reply-To: <87r0xsd8j4.ffs@tglx>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ugbLSNtPqRbvtNACqwcR0LvlwcwXJwVcnvBlts9EV09JvMWEG6p/xJ/OZZnG?=
 =?us-ascii?Q?MkATt3a1xnbfj3vOa6cG6GWDdi6T3eo1pBZ95nwFyOX5C3ayxadRaR0MJtCg?=
 =?us-ascii?Q?E7fErrTIo9eeGkYJnO1kZ8Uu95LG0q4lQqoOe6rGVXxLpOu0poV27/Frh+N+?=
 =?us-ascii?Q?mG6K+cA/VC0o/BTlu/i/dMRXIju8A0OWSZMy0jZhB44fLRXa4hSqKKhyUCNT?=
 =?us-ascii?Q?hYPh5TzXUMhgYYMMFTNONrZT3/U8pl29vyYqNWkz47s0Bi+YF+tHhR/ds9Ih?=
 =?us-ascii?Q?OEXV5pLI0gXcDO0CaJ1GGubLy1AaAAQB5dBtUGKW+0sVB2gAqVSWKEE7/PGb?=
 =?us-ascii?Q?pEczCRgutX9Pe3L0H/bgn22OsYWy8W6tYV8zaJSxKODoxLzUewEsfqLfEMMc?=
 =?us-ascii?Q?vt4xG/+mKhbGoL0qLDwgg0x+LERc2G6Njucu2Kf1FHbm2kWKVhLni4jzkXmE?=
 =?us-ascii?Q?H5O7QbSPaSBv03SR9aC/P7nBBnNMuUeNBK+tGahtrQtmA01b9g1TRPRmOMa5?=
 =?us-ascii?Q?dVCa3/NVN2sQfvGddJ/gJttf97EQI+I7+Nfk9ERIWxobBytRs5bumuEA/S+G?=
 =?us-ascii?Q?fzIDQNmKb2gXvKZkna+eX3vENwS4OdYBAbG0LVH1vNiWPpen5W0j+F743WBo?=
 =?us-ascii?Q?upwm4zh9h2DUf3Ngxehix6Kr28NEgNZLnnx5I1s3njvjAQnNEMa6WQxANMvJ?=
 =?us-ascii?Q?ji0EBhXBv6e6zPcjkOGcUvlp/hAyB8DkcAlvgTP01q2cTTimKSoQawZmdp2e?=
 =?us-ascii?Q?Zl6NagyNCnim3VeyMXQ7Iyw/+RUaCtBKK8BQMHgNd5f3SEGK0p8NlxejDhoQ?=
 =?us-ascii?Q?xHrezc/RWVTFMOEMPqNee7gUsbrtkwuUsEOhcGy1S6M2xh/ear9IQDmP8lmH?=
 =?us-ascii?Q?CfYA/UZBMiMl4QLClIlryC7oS7H2Hso6nlEmzOh4izzDNU68OBOk4s/Dr2Ud?=
 =?us-ascii?Q?VX3wN2SCfgVGyoqpH+dQamKw3+vB5uFHlKmD55MV8JkuWZoGOYolrQd82wXP?=
 =?us-ascii?Q?QEybFLARaWdzqxt0Zb+dXHtghQmPJHJrWaBgfEudvjkUtFoEhWLCOnZJFTyN?=
 =?us-ascii?Q?vBThn3ts59PK+Xvi/F9noB0bUMTVYKcxulmX/pT7b8GHXyjT01HSYwckpdfV?=
 =?us-ascii?Q?C5qMUK0zgoZmeHJCCDeNJtyD8E65+sepxbTWtG71/4W5CYISBgOodO5mOJgp?=
 =?us-ascii?Q?ZzyugTKyrGC6WArzlZqi3x08BI1PQBwdfAh1w81Tpw79p94DgF+zYlb7nxgJ?=
 =?us-ascii?Q?c+ih1qs8jUtPAZD2bfBusT9vNZTmqOKBmAOW2P6kfFsypBNhzI2m3oWbSxzJ?=
 =?us-ascii?Q?EqjjYs3B8EKaqdm5gWxLQjAEzx5LMO6lXn+ablDJT/JJWKwxFlzviHBVekEj?=
 =?us-ascii?Q?E3dLOhys0TSPExJNq3F1S5wc3hQfPCYS+TJVhiDuCUXYgAp8dWuCocoQiDdt?=
 =?us-ascii?Q?a7QgjUk1NSOYkh3vjvPmIS+nS56nTgFKSjnNJCosS0NOjuabjGhFIFsodfUs?=
 =?us-ascii?Q?DOO0GcL83RuYIrm2qxPNNbd106FdMaRTh/B/AW+DrBJUQ0m468czPQzMO13M?=
 =?us-ascii?Q?W4qGemVSEsPA5DBxAlS4aMeCG5JYNAag+Ky6osJZ?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d3e9d714-3cd6-437a-2f52-08dad0e2d2bb
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Nov 2022 01:49:44.2390
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: T0+JIzes3wquZCHDxFkQzKZhft5Nw4bIwbPf7u2c5XxqHFvU3GWjb6dGp6dsbKcSC2gHrN0KbUCipQ1i/3E7TQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7372
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Thomas Gleixner <tglx@linutronix.de>
> Sent: Thursday, November 24, 2022 5:09 PM
> >> +void pci_msix_free_irq(struct pci_dev *dev, struct msi_map map)
> >> +{
> >> +	if (WARN_ON_ONCE(map.index < 0 || map.virq <=3D 0))
> >
> > map.virq cannot be negative.
>=20
> Why? Callers can make up whatever they want, no?
>=20

obviously callers can. Read too fast...

Then following check should be fixed too:

+void pci_ims_free_irq(struct pci_dev *dev, struct msi_map map)
+{
+	if (WARN_ON_ONCE(map.index < 0 || !map.virq))
+		return;
+	msi_domain_free_irqs_range(&dev->dev, MSI_SECONDARY_DOMAIN, map.index, ma=
p.index);
+}