Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>
CC:     "x86@kernel.org" <x86@kernel.org>, Joerg Roedel <joro@8bytes.org>,
        "Will Deacon" <will@kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
        Marc Zyngier <maz@kernel.org>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        Jason Gunthorpe <jgg@mellanox.com>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        "Raj, Ashok" <ashok.raj@intel.com>, Jon Mason <jdmason@kudzu.us>,
        Allen Hubbe <allenbh@gmail.com>
Subject: RE: [patch V2 07/33] genirq/msi: Provide
 msi_create/free_device_irq_domain()
Thread-Topic: [patch V2 07/33] genirq/msi: Provide
 msi_create/free_device_irq_domain()
Thread-Index: AQHY/bblStmeh1OioEClNZ/eww2WyK5MCblggABa9gCAAN5AcIAAgUSAgAXW17A=
Date:   Mon, 28 Nov 2022 01:47:32 +0000
Message-ID: <BN9PR11MB527654DBF7C1319397FE68B68C139@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20221121083657.157152924@linutronix.de>
 <20221121091326.879869866@linutronix.de>
 <BN9PR11MB527604DE2A881FF615B7D0748C0C9@BN9PR11MB5276.namprd11.prod.outlook.com>
 <8735a9gau7.ffs@tglx>
 <BN9PR11MB5276EE7F109A251141E936308C0F9@BN9PR11MB5276.namprd11.prod.outlook.com>
 <87tu2oda0w.ffs@tglx>
In-Reply-To: <87tu2oda0w.ffs@tglx>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rLpQFmctlIb1TBA9lg17cGy5orIbbDwaIVYOpp4AjCi0Ccfvj3P96VfwtU2+?=
 =?us-ascii?Q?kUfYWbxSS3TtZ6dTkGJMJK6fsp9rdUTgcj1KhCDpiSI4fvMrEWfBtqmaLDvo?=
 =?us-ascii?Q?31zeygYgUTmDCSJLf+hihV3cxpcqlqpAA0zMtvKkqL10omS1l4ZTMmF4emKq?=
 =?us-ascii?Q?vqXb1dfR91400mQ9ITYln5D1SZWECoBudQH1b8PHprHcmgpfN0tOExYzGE8S?=
 =?us-ascii?Q?wAx0UhBm01F1GHS7Un58YBr69/o6Dnowg9NGq79pE+k5+0y884WbMLSRqb7z?=
 =?us-ascii?Q?kg0JqUGaL0QGZ5Ahy2gFvWABKEmGITMCVSqGmIWyhyuXH4/O/TYDP+3p3/Zx?=
 =?us-ascii?Q?GhYv5r2f7nC/I3gCIN5BTyA6Y9sh0VlDs91UcUVLlnlj50IhrJlwO5Ij0IVM?=
 =?us-ascii?Q?sVxrs8Zatazb+E7KTzXSChuCwAFnjDhsFvngF54cKG6Yv+VYCmaBrIGpCGsK?=
 =?us-ascii?Q?9fjj1J4Ug1k3InWh9/T8iJv/iMIuiXql5CL0xA9rbQ9/KRro7Kxnz5ZX+zvw?=
 =?us-ascii?Q?wbvf3cN65lh+RL7w7GCGomGsRD45iew4dOrjrWBulppFjNPmYnJszJFRWCvO?=
 =?us-ascii?Q?eJ+gKgsQbnBxkkUwU1xOFELm8u12BQ/86MOE8JqkpDXwqzSm1TqcS7UvzYvR?=
 =?us-ascii?Q?5Wv0J5VdcRSGXT54HSX9X+pdlgFmCENLn/pX7chMVxvaSeRISb6EQpQq/udT?=
 =?us-ascii?Q?OhVbgJMZfGIR0fEpv5Qgg7KT2DPVWY5/eqCvY8Sl+JbQ6seoITv+NeGcj7lh?=
 =?us-ascii?Q?Nyjsk0t1sKrylptORw8MmqGOSyrqNs8MBjD7wXDd6n/neGurm7aXK9n+fkm9?=
 =?us-ascii?Q?bkkIqrQ9VwO8zIhA5a2wUuYO/Rvkl+nq2bw19ykF1g4nnPXUbVmLgZtEgBWl?=
 =?us-ascii?Q?8yq4vPJfQDbL1fbABsz1Xv3KtYN9hfNsl3K31eNRgfYcTu/j7RwhqLA8+Kub?=
 =?us-ascii?Q?A2Zei56vOmDoYxn6eLB5K41+Hl19n2eEDJ7AG/Ebc/lJ8ZMm9fe0On9JIhHB?=
 =?us-ascii?Q?OVg9JNV8hWBXbbFPJwsBnkpih+pCgtBAOzrWBj9Bd6q9QSxMHBrmIpWSxnVz?=
 =?us-ascii?Q?GIDTU/wISiV2Dz0CS3JYE99B9yqs1nSBnnkzftWl6I5ty3yp7K8alZOydCjF?=
 =?us-ascii?Q?aIdWbCiW254gtEURHLS1isiY/WptGgJojFx++/cYP7zUPFY1C5u77vzLNEXL?=
 =?us-ascii?Q?RWq82OBLSBIZobAOYYpdyDEt91f5TtUtYMtDiE9K9sahJtR4cHssJ6BEJTC2?=
 =?us-ascii?Q?4hubFBJ83xVg02C10ZwSYNA4u742ngSiD/nHAIrtFOCm/SKm9T7P4ToTrGgk?=
 =?us-ascii?Q?DQXm3QF+TdTg72eTP+6onZQd9ZZ5CDxvm9M1Lfm7d399iBuNMo4wmCehn+7n?=
 =?us-ascii?Q?WKXF0MUesNM79V19ZiL5S5QikxX+gcMTxxkMZaVCMEIcwqTTnklcsR/xGaks?=
 =?us-ascii?Q?zYeaXqCCevPyGVAzym0p0tIm60dG2Cofd13AzLxMlbHoKPuk1rtU/4s3nsDB?=
 =?us-ascii?Q?jPHjR6DJnIwgDoNEBOeup88rvdaueURkTtmLSg24cl5B7wPRenalkGV/Jkzb?=
 =?us-ascii?Q?ZETemKuuaRY5IgnCmqdNFbn05l8YrXLPPsTBOtxK?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e922ebb-e436-4c7a-7b1a-08dad0e2847c
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Nov 2022 01:47:32.9658
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: B2Q29ZXyoic2xBcRrKBzzm6hsHRAmm5a3LE+tQ4eprg84jl2zDgLiWvkUAoJR1roXB/i1iBqaeEJ7+lDPsR5lQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7372
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Thomas Gleixner <tglx@linutronix.de>
> Sent: Thursday, November 24, 2022 4:36 PM
>=20
> On Thu, Nov 24 2022 at 01:07, Kevin Tian wrote:
> >> From: Thomas Gleixner <tglx@linutronix.de>
> > I looked at it from the outmost invocation:
> >
> > @@ -436,6 +436,9 @@ int __pci_enable_msi_range(struct pci_de
> >  	if (rc)
> >  		return rc;
> >
> > +	if (!pci_setup_msi_device_domain(dev))
> > +		return -ENODEV;
> > +
> >
> > the current style kind of converts meaningful -EINVAL/-ENOMEM/etc.
> > into -ENODEV.
>=20
> But go to the call sites of the various places in drivers which set up
> MSI or MSI-X and check whether anything evaluates those error codes in a
> meaningful way.
>=20
> Some of them print the error code, but that does not help much because
> the error code does not allow you to pin point the place which returns
> that. If you just analyze the pci_alloc_irq_vectors_affinity() call then
> you find at least 10 places, which can return -ENOMEM. So how is that
> meaningful and helpful?
>=20
> All it tells you is that some memory allocation failed. In that case the
> failure of the PCI/MSI[-X] setup is the least of the problems.
>=20
> Where error codes are mandatory are user space interfaces, but in the
> kernel a simple fail/success like we have with many interfaces which
> just return a NULL pointer on fail is sufficient.
>=20
> Just because the kernel historically propagated error codes all over the
> place does not make them useful or meaningful.
>=20

Good learning. Thanks.