Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>
CC:     "x86@kernel.org" <x86@kernel.org>, Joerg Roedel <joro@8bytes.org>,
        "Will Deacon" <will@kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
        Marc Zyngier <maz@kernel.org>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        Jason Gunthorpe <jgg@mellanox.com>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        "Raj, Ashok" <ashok.raj@intel.com>, Jon Mason <jdmason@kudzu.us>,
        Allen Hubbe <allenbh@gmail.com>
Subject: RE: [patch V3 00/22] genirq, PCI/MSI: Support for per device MSI and
 PCI/IMS - Part 2 API rework
Thread-Topic: [patch V3 00/22] genirq, PCI/MSI: Support for per device MSI and
 PCI/IMS - Part 2 API rework
Thread-Index: AQHZAFvm330rC7indkKxPAycpb95SK5TobhQ
Date:   Mon, 28 Nov 2022 02:33:56 +0000
Message-ID: <BN9PR11MB527638D9C74A83FE1D0212D78C139@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20221124225331.464480443@linutronix.de>
In-Reply-To: <20221124225331.464480443@linutronix.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sGCLORDKQ3BJXvFRci9SjpJJF22T/cc9ou8NEGR7C+1lC9Uh8HzdftXYJTDf?=
 =?us-ascii?Q?LodD1NEIer3yPjYQqDACupnSoI6HDd0sz7g9HqLLljvk03IG9htvH8rv7M2a?=
 =?us-ascii?Q?bTLm8LLKf/3/SKmRVe8bWs+2pNBcb0jWtztTgMw8KSaAp52aLpEGJgpbH6iZ?=
 =?us-ascii?Q?0fHnK2UGKCIoeUvR9/Fo7y0Gnc8g/ndUE9fygxTD+AVJyKHrdh0Oh3ZzgM7v?=
 =?us-ascii?Q?DUUX0zo07kNBLD7a4avVmdQxmJrsoVHOQiKeV4Dr2GSm3ijZ27CugBOY+3Rl?=
 =?us-ascii?Q?6qwUJXsMlaPnqlLu/+voT7E5nYILksV7VXHSrwv3TqNv8oYMvhk9rwGYpJ5b?=
 =?us-ascii?Q?JQ3Okw5tffnaZRTOhC47UoDN3wVtyOGmj1ih5t0C9MS2ZezrnNxBGTLIKcCR?=
 =?us-ascii?Q?YuhTx5x5tnmf9whmrYo73tLXExc0zvSk0FlND5n2RCzDOqki6pxBcQlYsSJX?=
 =?us-ascii?Q?P/m/08AhFhAXuy3jVKVnFXSa/hyxIkcKSRywRUOrl+aDl2reSak8QgNgEBPh?=
 =?us-ascii?Q?/91LSfsT0D92LrgF3gsoh86stw74HjKYv/M0S7tpT37LZ1GozbaIMkc8MQ0d?=
 =?us-ascii?Q?F6kImh/ZPHBEYn9qIPaQ0FkH/SgNUx6e0r1JfonogMwF/CnSx+WWp8ECA3kD?=
 =?us-ascii?Q?dN6Qm04VVhWXA6Oh6CMHrIbU2hRyC1Wc2OU3b6ACS0DXNNpCGF+GmKVw8t+b?=
 =?us-ascii?Q?S4le7o6NkM23H/BCI6DLM+9OOiiYtrr9w9PDs9+ygYojKZuDeRmnObPD/Vsq?=
 =?us-ascii?Q?KoZoiODXqRb4lfXKQyLsMdkPjdQUMSs8uU0NISrSK0AL7u8i6B8JDqzvUwmQ?=
 =?us-ascii?Q?G43YPvsL2R5BXoVWt2KySOGiitNKJiTnrF5aoUYLc4sz0IgeqC9oag/7JNXJ?=
 =?us-ascii?Q?zlzhzfxIrUFSdpg9KVMmx8opiGbJtfZlWGgGxdnavny5oykoCC9q9UA86IVk?=
 =?us-ascii?Q?7PSaVns4dqYEKb1DbOG46R+dJK2Zmg/RxFLp+XP9U7IOeHRbwyvJXAmC1tZo?=
 =?us-ascii?Q?dF5s3BD5P7RC7vIPoZrtGQCmruTj90SPEAZVA9tkwbdtoN19V8K6jB7JnXkE?=
 =?us-ascii?Q?G5gRtBMo6X6i+qGzuKo8M9GP8lE/j8wbj/H9a4l/rsJQpirfSZ9ZAUTyRygv?=
 =?us-ascii?Q?KwGCHD6PHYyEy3FehZAlaUa2w83Lp8OVBTe2ZF+pxBj8fo82WfTJw/MWFz0U?=
 =?us-ascii?Q?yZjQywwmGREkaR7o5PJbvbJf2F1Mu1ichFp8xpVODs6Y0idtYevJXRJurxDM?=
 =?us-ascii?Q?1+GKHdUb95aMBz3S2Eo0D2fu2kmUgZSx/8DDqqxDvSN1mg/dtJvfpZSa7bqn?=
 =?us-ascii?Q?KeEzV/GfI8LLONOyimTzDuQbkdH963zkVOUPaanAmMlC7CAgqH97ukb4EMvV?=
 =?us-ascii?Q?n05mhWbl371SvFPRWVEgBgF/hZl/l7TVNsAupmlgdRwqK1CbyBLCKglDY7lF?=
 =?us-ascii?Q?gg25gmsluLsQY199v5J73Xbunfgm5qulhF5Y5KRHmLK/yPGcHY+55//Zm4Oj?=
 =?us-ascii?Q?PZ1ZGXHTehiTWiYwMUiIWSIxFeQgKg8ZHnBQ0L2sLmfUUiam/hO9AnBTaz/R?=
 =?us-ascii?Q?W8Mx4wEi0BMsjeUOm5ju0DLKBaXZwxRVwAfWIsrt?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aacaf593-bdfb-49bf-35c8-08dad0e8ffe8
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Nov 2022 02:33:57.0120
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qCr/E/a+cfEhk/F8mKxpDM9Uzm5JAAnSqSeQExGxwuWFsx+q1meyked6+iHDVl3Q5Z3bQAxm/AlHdD/u25DIBg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5530
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Thomas Gleixner <tglx@linutronix.de>
> Sent: Friday, November 25, 2022 7:24 AM
>=20
> Changes vs. V2:
>=20
>   - Rework the xarray storage into per domain storage (Marc)
>=20
> @Kevin: I did not pick up your Reviewed-by tag due to these changes.
>=20

The incremental change looks good to me:

Reviewed-by: Kevin Tian <kevin.tian@intel.com>

Just one nit.

>=20
> -	xa_for_each_range(xa, idx, desc, ctrl->first + base, ctrl->last + base)=
 {
> +	xa =3D &dev->msi.data->__domains[ctrl->domid].store;

Better to have a macro here given multiple references on the store
in following lines.