Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp14340374rwb; Sun, 27 Nov 2022 22:47:08 -0800 (PST) X-Google-Smtp-Source: AA0mqf5z1H2e9t4Zt5WYZOn7K4lysAw9KfJn+Grg1WX1jv1+DRQ3R+15ndD4LbcFFMFvfzYN05wg X-Received: by 2002:a17:902:db09:b0:188:7dca:6f4d with SMTP id m9-20020a170902db0900b001887dca6f4dmr44095939plx.68.1669618028140; Sun, 27 Nov 2022 22:47:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669618028; cv=none; d=google.com; s=arc-20160816; b=aHbe3SPjPwdfosKDCGus8EL4gR0wAhN1j8bJtqw5oaefYfXyXJxlqM8f/QG6jOEi/W mt90n84ECi1k3Oxnp1gs7iwKyUmT2Q0+vJ6m8+RQb2W7O/UJh/CdpPBF04VqbEHjQbT1 MdV72mLtZ7RF6btf2bPcRh3xweOR5XuUSoIjTHaa5gKdqN8FFNDE5G5jIF4tKM0XlNhd v71PYXck74UCKo7v359F6tx+ZynaQykqkSWK4aFYO3l8A5tvDW72/IIGU4bz6gnhL1O5 nPIHcN6PP9RCDbCSEi7qZ/UoGOpaHWo7o5z3cuSVRZLJqggkZdgZ5OgysyD+dwhA1VGv o49w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:references:cc:to:from:date:subject :message-id; bh=u1ompaKneg3/B5hfY8OJV77ljv/DYxBH6gxc4+e5Jk0=; b=ZB8SetFjqvIfF0SgTpgLCs7YZWA9CZl0Med6Cjs9TYrCiktM1z7b5dtlyJyVA1kg6w wyTNQLyRkbIHEoAHB4a3r8mnNkO0KGix7yDJukzIGck62wjiBdf0dhgxQp7UNHmAaBnd PXYILdX+DahJhNmG3Jpx6+UXfgUS66mv/YXaRERisH0AwP5HAstLqqDSInFVoJcLWOzA 7Lic2AC2gaXVBUA//YbPB/XBSuRLHoLhEiAGzB+dNMVzJ8sJQZiFMFAtjDG0a6doH8TP rcOzqXoVo0U60z4yRUpnDhZAV1hCmNTErOG9BCuB6j6WQuIQCjVWslIOzr0Yw1PIrXvr vhCA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s21-20020a056a00179500b00557c5641be2si11555848pfg.248.2022.11.27.22.46.57; Sun, 27 Nov 2022 22:47:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229751AbiK1GRN (ORCPT + 84 others); Mon, 28 Nov 2022 01:17:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229603AbiK1GRL (ORCPT ); Mon, 28 Nov 2022 01:17:11 -0500 Received: from out30-42.freemail.mail.aliyun.com (out30-42.freemail.mail.aliyun.com [115.124.30.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85F2311174 for ; Sun, 27 Nov 2022 22:17:09 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045170;MF=xuanzhuo@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0VVoRcX4_1669616225; Received: from localhost(mailfrom:xuanzhuo@linux.alibaba.com fp:SMTPD_---0VVoRcX4_1669616225) by smtp.aliyun-inc.com; Mon, 28 Nov 2022 14:17:06 +0800 Message-ID: <1669616200.943005-3-xuanzhuo@linux.alibaba.com> Subject: Re: [PATCH 2/2] tools/virtio: remove smp_read_barrier_depends() Date: Mon, 28 Nov 2022 14:16:40 +0800 From: Xuan Zhuo To: Davidlohr Bueso Cc: dave@stgolabs.net, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, mst@redhat.com References: <20221128034347.990-1-dave@stgolabs.net> <20221128034347.990-3-dave@stgolabs.net> In-Reply-To: <20221128034347.990-3-dave@stgolabs.net> X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 27 Nov 2022 19:43:47 -0800, Davidlohr Bueso wrote: > This gets rid of the last references to smp_read_barrier_depends() > which for the kernel side was removed in v5.9. The serialization > required for Alpha is done inside READ_ONCE() instead of having > users deal with it. Simply use a full barrier, the architecture > does not have rmb in the first place. > > Signed-off-by: Davidlohr Bueso Reviewed-by: Xuan Zhuo > --- > tools/virtio/ringtest/main.h | 17 ++++++++++------- > 1 file changed, 10 insertions(+), 7 deletions(-) > > diff --git a/tools/virtio/ringtest/main.h b/tools/virtio/ringtest/main.h > index 9ed09caa659e..b68920d52750 100644 > --- a/tools/virtio/ringtest/main.h > +++ b/tools/virtio/ringtest/main.h > @@ -140,12 +140,6 @@ static inline void busy_wait(void) > #define smp_wmb() smp_release() > #endif > > -#ifdef __alpha__ > -#define smp_read_barrier_depends() smp_acquire() > -#else > -#define smp_read_barrier_depends() do {} while(0) > -#endif > - > static __always_inline > void __read_once_size(const volatile void *p, void *res, int size) > { > @@ -175,13 +169,22 @@ static __always_inline void __write_once_size(volatile void *p, void *res, int s > } > } > > +#ifdef __alpha__ > #define READ_ONCE(x) \ > ({ \ > union { typeof(x) __val; char __c[1]; } __u; \ > __read_once_size(&(x), __u.__c, sizeof(x)); \ > - smp_read_barrier_depends(); /* Enforce dependency ordering from x */ \ > + smp_mb(); /* Enforce dependency ordering from x */ \ > __u.__val; \ > }) > +#else > +#define READ_ONCE(x) \ > +({ \ > + union { typeof(x) __val; char __c[1]; } __u; \ > + __read_once_size(&(x), __u.__c, sizeof(x)); \ > + __u.__val; \ > +}) > +#endif > > #define WRITE_ONCE(x, val) \ > ({ \ > -- > 2.38.1 > > _______________________________________________ > Virtualization mailing list > Virtualization@lists.linux-foundation.org > https://lists.linuxfoundation.org/mailman/listinfo/virtualization