Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3158c04e-a3d7-9777-4b1c-79cd7b081d6a@ideasonboard.com>
Date:   Mon, 28 Nov 2022 12:15:37 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH v2 2/3] media: dt-bindings: ak7375: Add supplies
Content-Language: en-US
To:     Yassine Oudjana <yassine.oudjana@gmail.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Tianshu Qiu <tian.shu.qiu@intel.com>,
        Bingbu Cao <bingbu.cao@intel.com>
Cc:     Yassine Oudjana <y.oudjana@protonmail.com>,
        Jacopo Mondi <jacopo@jmondi.org>, linux-media@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
References: <20220711144039.232196-1-y.oudjana@protonmail.com>
 <20220711144039.232196-3-y.oudjana@protonmail.com>
From:   Umang Jain <umang.jain@ideasonboard.com>
In-Reply-To: <20220711144039.232196-3-y.oudjana@protonmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Yassine,

I have tested this VCM with IMX519 arducam sensor with a auto-focus 
algorithm plumbed with libcamera [1]

On 7/11/22 8:10 PM, Yassine Oudjana wrote:
> From: Yassine Oudjana <y.oudjana@protonmail.com>
>
> Add supply properties to describe regulators needed to power
> the AK7375 VCM.
>
> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

So,

Tested-by: Umang Jain <umang.jain@ideasonboard.com>

[1] https://patchwork.libcamera.org/project/libcamera/list/?series=3174
> ---
>   .../bindings/media/i2c/asahi-kasei,ak7375.yaml        | 11 +++++++++++
>   1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml b/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml
> index 22b1251b16ee..22a810fc7222 100644
> --- a/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/asahi-kasei,ak7375.yaml
> @@ -20,9 +20,17 @@ properties:
>     reg:
>       maxItems: 1
>   
> +  vdd-supply:
> +    description: VDD supply
> +
> +  vio-supply:
> +    description: I/O pull-up supply
> +
>   required:
>     - compatible
>     - reg
> +  - vdd-supply
> +  - vio-supply
>   
>   additionalProperties: false
>   
> @@ -35,6 +43,9 @@ examples:
>           ak7375: camera-lens@c {
>               compatible = "asahi-kasei,ak7375";
>               reg = <0x0c>;
> +
> +            vdd-supply = <&vreg_l23a_2p8>;
> +            vio-supply = <&vreg_lvs1a_1p8>;
>           };
>       };
>