Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2f0a504e-99a9-deb4-8693-c490d13f52a8@wolfvision.net>
Date:   Mon, 28 Nov 2022 07:54:09 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCHv4 7/7] arm64: dts: rockchip: Add rock-5b board
Content-Language: en-US
To:     Sebastian Reichel <sebastian.reichel@collabora.com>,
        Heiko Stuebner <heiko@sntech.de>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Christopher Obbard <chris.obbard@collabora.com>,
        Benjamin Gaignard <benjamin.gaignard@collabora.com>,
        linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel@collabora.com
References: <20221124144928.35381-1-sebastian.reichel@collabora.com>
 <20221124144928.35381-8-sebastian.reichel@collabora.com>
From:   Michael Riesch <michael.riesch@wolfvision.net>
In-Reply-To: <20221124144928.35381-8-sebastian.reichel@collabora.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S1Y5cGpMSER3YklnVlVtM29tRzVxTkVwOFZ5MHluL0x5UjBGMTY5M0laVzMr?=
 =?utf-8?B?Qk5XV2ZyYmNYbTQ3VTJKYlRuczBLUUlvdFFSL1gzTnZvUVlCL0M4NTUwaXZr?=
 =?utf-8?B?eG96R0hBOWpBQjhPMFlscThLS1lVb2hJTjBnakFEdWdFdE0zZDJGN2ZaQXZo?=
 =?utf-8?B?YUtROUpha0RMdTlrRkF1OXJRU0xLVENEWVExUjhUK2dSWmk2M1Q3Q01DWFRi?=
 =?utf-8?B?UklTV2htZm9qaUpjb2YyaThmdWJveDNqeGZKekZjQy91Qll1V2ZkU0RBYjBa?=
 =?utf-8?B?a3J2Zlc3bXdKOUlRY01VZDdSeXZGNHVCM0RyVXZacWxwYlNjajFWMHc4dDE0?=
 =?utf-8?B?cGlWMEp4dU5GYU5oQUJlRG9lMTVUbnFmeGRTdkJjZTQ0Ym4wL2RIK3JNQytK?=
 =?utf-8?B?bEx2OGxyaDJlZEtFeXZHRG9CRDNVSFUwVWxtaFg1WGtSZWJqV25CNGVweUpO?=
 =?utf-8?B?QW8vanNlcWVWWFJCalYwOFhtMVVvTXVFanBKTU1hNnJzbS9SbVBoZURxY25o?=
 =?utf-8?B?dFh1UEFlZ00wOUlVc21GWnhSdjVySU1wc0V4N0ZoWWdNdDNpVnZCUFpiamU3?=
 =?utf-8?B?RlFqRDVKTDc3RHJTVDNaMjQ3VVMyNmFpVzFGNUtvY1lmanMrUUFscUV1cEt2?=
 =?utf-8?B?REQ4TGQ3NmJsRUNoUmFVZjkxOU5QOFlEbG5RdllNZE9LcTM2dFJjQXRFaWhy?=
 =?utf-8?B?dEptM1pRRXF1ZzRyTHpPblIvd3hoc2RWQU4vcVZWL1lFVlVqQmdFQ09qSU5q?=
 =?utf-8?B?cW5sS2txRkx2dTJrdFVvVDdQUGdQd3ZOMnVaM0QrT29ybm9HakhOM3ZFUDBS?=
 =?utf-8?B?eFFXU1FzQ1FIOGI3SmZxK1B3cWlhVXBHbUhLZ284Y21KeVd5QjM2YThlR2l5?=
 =?utf-8?B?UXYyaWFmb0JaVmw1WEFvRTYzQzd0RFdSbDBIT0tReE1aMTN0aWs0cHNNTWdU?=
 =?utf-8?B?YkU0WTNZcjcrajZzdkZ6cTBURVd3RENpOU1XaUljRVRsamU4YVN0QldiakRR?=
 =?utf-8?B?R3pnVmFZRlIrYks0ZUR5VExpQndpTW05N1lUa1IyQXdBMXlyUE5jWWEzMkdm?=
 =?utf-8?B?YzhiQ0FFOG94TkxBKzhDS0IvVnljbmRKSE9pdEpRaWhQSGV6WFU5RDhRRWU2?=
 =?utf-8?B?UEZmZWNNSjArQzRDalFsZ0lTcjdBanh1U3poRXZCLytOem0wU1VGYXl6R2Jl?=
 =?utf-8?B?TkpROVVhOVB1eGxtZXRKdlBUanQ2MVlhcTFOS1RWblBiVXoxSmF5b2lHeEdr?=
 =?utf-8?B?VXl2SkdURUpidkJvWGtOTkxrZ3FSclFoK3VMaXgxVTZjOERWSlh3Q2JxcnE3?=
 =?utf-8?B?NWNJSiszMFVBUGZlbElicHlvV2tiNk9FemM5VE9OeC9VZDhaU0RBTVMxZDR2?=
 =?utf-8?B?QjBNekd4WWdpYmJTMmEzakpCWXV0bWdDa242OXJRRWRiNzJBNVRHV3J4bm9a?=
 =?utf-8?B?VXRiLzh4UDZBbHpkbUpJMW83cGh2ZUpHM1FlNEdneER0V0QzY1BSQlQydElp?=
 =?utf-8?B?cXJ0eGk5WFFqWHEvb29wL1VZckd0R0RrSWVQZDBRcEFTcHN3Ymo0WE1JQy9s?=
 =?utf-8?B?VHhBekJSVENXeGM0cnRXNXpscGlrb251SVVyMWFaam1WMlpNOWFiNXdxTEp1?=
 =?utf-8?B?RUk4WTNoSCsxRUtvZ1VYa1k0dHhKSlJ4OVRWVHpTK2c1SG00TGhtalRUdVky?=
 =?utf-8?B?YzE5Q0V3S29GUm5jcDEyRW51YnJ3Q3NBY1ltVm96L3loVjZWbGZ6OUNyNGVY?=
 =?utf-8?B?aVFoc1ZVSXBOQi95OWVtRUtUdFdZcmxDNmwxRWFiSTNJR2NRZkRMZURGMmhC?=
 =?utf-8?B?Y1ZQdWt3TXFIUHJsMGpBdjYzOXlxSEwyQ0srenNZcE5jUDR5Q3pFQ0ZoZnd3?=
 =?utf-8?B?WGdrTlFKcmtkMHA0TlRpV2xrNWRiVmxTVk1tOWZXREJVN1ZjcGVhR2svTEZ0?=
 =?utf-8?B?dUV2b0kzUFVZcEtLVGszeXQzdDJHZm90QzJaY1dqUU9zenBvU01wVDhHMVZo?=
 =?utf-8?B?VzhXZENSa1pqOFdFUkVVckhwTWd2QkQ0V1ByWXZ6ZzJlSHJ5TjRHSHhyQU9u?=
 =?utf-8?B?QXlLckJDK2R2d1lRU2VGSVliRmorTUYvT0J4amovalhza1BjU052ZDA3amNT?=
 =?utf-8?B?b05DZ3ZiKzdzTEM4bWEvNmhHc3pBVHNET0ttcXYxOGY5b0x4cmkxaWVUcUpG?=
 =?utf-8?B?VXFSM1cyRHhEUEtYMy9ObTgydmpjWTFsSXBGR043SEhxc1lDQnpJTkJlUHFN?=
 =?utf-8?B?NVB4aGcyNElJRzR5UzROZzJ0VFJnPT0=?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: a366c21b-3ce4-421b-d421-08dad10d5a81
X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB9155.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 06:54:11.1146
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f053+6/TKxNbpCMxXZqlKm99p1a+ZtBiCY832mEYoBFPJq/tjcid7vEs6JRcTOjRbmGgoiryU3U3VbR+gG9kDzQ06ImItfn03OB8aGtEq78=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6079
X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Sebastian,

On 11/24/22 15:49, Sebastian Reichel wrote:
> From: Christopher Obbard <chris.obbard@collabora.com>
> 
> Add board file for the RK3588 Rock 5B board. This is a basic
> implementation which just brings up the eMMC and UART which is
> enough to successfully boot Linux.
> 
> The ethernet controller is connected via PCIe so support will
> come in a follow-up patch.
> 
> Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

Reviewed-by: Michael Riesch <michael.riesch@wolfvision.net>

Thanks and best regards,
Michael

> ---
>  arch/arm64/boot/dts/rockchip/Makefile         |  1 +
>  .../boot/dts/rockchip/rk3588-rock-5b.dts      | 44 +++++++++++++++++++
>  2 files changed, 45 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> 
> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> index 31fa55750a0f..b31aa1b0e9e3 100644
> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> @@ -73,4 +73,5 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-rock-3a.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-evb1-v10.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-rock-5b.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-rock-5a.dtb
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> new file mode 100644
> index 000000000000..baf46bd30b38
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> @@ -0,0 +1,44 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +
> +/dts-v1/;
> +
> +#include "rk3588.dtsi"
> +
> +/ {
> +	model = "Radxa Rock 5B Board";
> +	compatible = "radxa,rock-5b", "rockchip,rk3588";
> +
> +	aliases {
> +		mmc1 = &sdhci;
> +		serial2 = &uart2;
> +	};
> +
> +	chosen {
> +		stdout-path = "serial2:1500000n8";
> +	};
> +
> +	vcc5v0_sys: vcc5v0-sys-regulator {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc5v0_sys";
> +		regulator-always-on;
> +		regulator-boot-on;
> +		regulator-min-microvolt = <5000000>;
> +		regulator-max-microvolt = <5000000>;
> +	};
> +};
> +
> +&sdhci {
> +	bus-width = <8>;
> +	no-sdio;
> +	no-sd;
> +	non-removable;
> +	max-frequency = <200000000>;
> +	mmc-hs400-1_8v;
> +	mmc-hs400-enhanced-strobe;
> +	status = "okay";
> +};
> +
> +&uart2 {
> +	pinctrl-0 = <&uart2m0_xfer>;
> +	status = "okay";
> +};