Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i8771445c:Fastmail
Date:   Mon, 28 Nov 2022 09:21:08 +0100
From:   Maxime Ripard <maxime@cerno.tech>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>, Helge Deller <deller@gmx.de>,
        Michael Schmitz <schmitzmic@gmail.com>,
        dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
        linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH/RFC 2/3] drm/simple-kms-helper: Add mode_fixup() to
 simple display pipe
Message-ID: <20221128082108.ntjhevb4ku6lnvib@houat>
References: <cover.1669406380.git.geert@linux-m68k.org>
 <3b0862187f1c8910089cb0d06a8669caa985042e.1669406382.git.geert@linux-m68k.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="zqy4xi2ywhixazqh"
Content-Disposition: inline
In-Reply-To: <3b0862187f1c8910089cb0d06a8669caa985042e.1669406382.git.geert@linux-m68k.org>
Precedence: bulk


--zqy4xi2ywhixazqh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Fri, Nov 25, 2022 at 09:31:09PM +0100, Geert Uytterhoeven wrote:
> From: Thomas Zimmermann <tzimmermann@suse.de>
>=20
> The mode fix-up function for simple display helpers is equivalent to the
> regular pipeline's CRTC mode fix-up function. It's called to adjust the
> CRTC's display mode for the encoder. Add this function for DRM fbconv
> helpers.
>=20
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

It's not clear to me why you'd need a mode_fixup in the first place.
Like said in the documentation you added, atomic_check is usually the
better option for the atomic modesetting drivers.

So, why is it needed?

Maxime

--zqy4xi2ywhixazqh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCY4RvdAAKCRDj7w1vZxhR
xb4VAQDcYvGXzV71avNSXjnI5sHfzoooq+kEtEPF6PujiPIf0wD8CTGXFvB1JBls
QCJDVxr23M3Ch2byEX26PLsS/N5+FwY=
=K4PV
-----END PGP SIGNATURE-----

--zqy4xi2ywhixazqh--