Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 28 Nov 2022 09:24:41 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Emil Renner Berthing <emil.renner.berthing@canonical.com>
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Atish Patra <atishp@atishpatra.org>,
        "Wesley W. Terpstra" <wesley@sifive.com>,
        linux-pwm@vger.kernel.org, linux-riscv@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] pwm: sifive: Always let the first pwm_apply_state
 succeed
Message-ID: <20221128082441.wsqcpuxqk6cynako@pengutronix.de>
References: <20221109113724.519021-1-emil.renner.berthing@canonical.com>
 <20221109120102.ylnseq2w33rvt7fz@pengutronix.de>
 <CAJM55Z-EVXB6FTWwh_vY_B3LoVv+b7TCQCE7asB8G8wkEwui_g@mail.gmail.com>
 <20221109153311.cszr7fgfmyelwra3@pengutronix.de>
 <CAJM55Z8vpJ0XtQqnsFMLE4rkyV11ePbNjtYx0u4pgM9-MT=Kvg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="kaygonhhwcbbtokq"
Content-Disposition: inline
In-Reply-To: <CAJM55Z8vpJ0XtQqnsFMLE4rkyV11ePbNjtYx0u4pgM9-MT=Kvg@mail.gmail.com>
Precedence: bulk


--kaygonhhwcbbtokq
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Wed, Nov 16, 2022 at 06:41:06PM +0100, Emil Renner Berthing wrote:
> On Wed, 9 Nov 2022 at 16:33, Uwe Kleine-K=F6nig
> <u.kleine-koenig@pengutronix.de> wrote:
> > On Wed, Nov 09, 2022 at 01:45:43PM +0100, Emil Renner Berthing wrote:
> > > How about we merge this bug fix that can easily be backported first
> > > and then look at how it should be handled properly?
> >
> > I thought it wouldn't be that hard to do it right from the start,
> > but I admit it's harder than I expected to get right. My prototype looks
> > as follows:
>=20
> This works for me (modulo the two extra {'s). I'd still prefer merging

Yeah, didn't even try to compile it.

> the simpler version and then this on top for ease of backporting, but
> as long as the race is fixed I'm fine. Will you send a cleaned up
> version of this?

I'd let Thierry decide what he want here. Depending on his choice I can
clean up my suggestion (inclusive compile test) on the then relevant
state of the driver.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--kaygonhhwcbbtokq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmOEcEUACgkQwfwUeK3K
7AnD8gf/dT+Idh5F//NM08TsmrSjFwGL4iPC9RfTbR+drkH+TzqExwotU0ZXtyez
PP7g1a7fBGQyKwwXxmk56rPjoxw4XQIHKdnodzgu8PajwgKKdjTNBhd3HZHUx8I+
2vA+/X60pzU/HBAuXkHm8wLj0BoShsgQYEclABI92tJKbUiM+46D0bTQjAXgrFcf
xT4HrrftNnRB1cdjyD2DJdBSgVZBkr62NJf1LVklhnxMtmwXPHtROWfJqOZsIJBc
drH9DgITkhN6r5oIQtpQ+idbxKYdU137CNSbGbWIFDgwAeammcyPqxXjeVQnk9oT
RcGUSJSsXZ7y5O2nm4FJtqsgl1qjMQ==
=cKDE
-----END PGP SIGNATURE-----

--kaygonhhwcbbtokq--